Jens Axboe [Wed, 1 Aug 2012 07:50:27 +0000 (09:50 +0200)]
Merge branch 'master' into gfio
Conflicts:
iolog.h
stat.c
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 1 Aug 2012 07:39:36 +0000 (09:39 +0200)]
diskutil: ensure that we lock around disk_list access
And also ensure that before we free the disk util structures,
we wait for the disk util thread to exit.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Wade Cline [Wed, 1 Aug 2012 06:45:48 +0000 (08:45 +0200)]
Fix fallocate erroneously returning ENOSYS on Linux systems
Currently, the helpers.c file provides a function defintion for Linux
fallocate that sets errno to ENOSYS and returns failure; this is useful
for a non-Linux OS. However, this definition will override the Linux
implementation of fallocate when 'fallocate=keep' is set. Adding a
preprocessor macro to check if Linux fallocate is defined fixes this
issue.
Signed-off-by: Wade Cline <wcline@us.ibm.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 26 Jun 2012 22:20:12 +0000 (18:20 -0400)]
Merge branch 'master' of ssh://brick.kernel.dk/data/git/fio
Jens Axboe [Tue, 26 Jun 2012 20:24:36 +0000 (16:24 -0400)]
Add missing arch_mips
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 14 Jun 2012 13:11:15 +0000 (15:11 +0200)]
Include end-of-run time in the output
When results are stored, it's convenient to be able to tell
when they were run.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 11 Jun 2012 11:19:13 +0000 (13:19 +0200)]
Revert "blktrace: use for_each_file() instead of open coding the loop"
There's another bug in where we don't have the number of
files in replay mode correctly stored in td->o.nr_files. So
revert this until that bug is fixed as well.
This reverts commit
adfc73488616bac66f910d53c75202d5be8afe87.
Jens Axboe [Mon, 11 Jun 2012 06:58:42 +0000 (08:58 +0200)]
blktrace: use for_each_file() instead of open coding the loop
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Shaohua Li [Mon, 11 Jun 2012 06:56:32 +0000 (08:56 +0200)]
Fix "fio: file hash not empty on exit" with blktrace replay
There are two problems:
1. blktrace data hasn't file close action
2. redirect file fileno isn't correct
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 11 Jun 2012 06:53:53 +0000 (08:53 +0200)]
Add a more verbose/immediate warning if we fail open with O_DIRECT
If we get EINVAL with O_DIRECT open of the file, then that means
that the file system does not support direct IO. Warn as such
from fio.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Bruce Cran [Fri, 8 Jun 2012 06:12:20 +0000 (08:12 +0200)]
Windows 32-bit fio fixes
Fix no-op shift in shmget by casting to 64-bit.
Generate a new Product GUID for fio 2.0.8.
Add the 32-bit MinGW-w64 compiler executable name in Makefile.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 6 Jun 2012 06:20:27 +0000 (08:20 +0200)]
Ensure that non-git basic installs return sane version information
If git wasn't available, we'd return 2.0.8 as the version info
instead of fio-2.0.8 like we otherwise would.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 29 May 2012 11:29:12 +0000 (13:29 +0200)]
Fio 2.0.8
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 11 May 2012 18:38:59 +0000 (20:38 +0200)]
Merge branch 'master' into gfio
Conflicts:
client.c
eta.c
server.c
server.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 11 May 2012 18:33:02 +0000 (20:33 +0200)]
eta: ETA bandwidth was off by 1.024
Same fix as
033bbb51 essentially. Since mtime is a 1000th of a second,
for the usual option of having 1024 be the KB base, we end up being
off by 1.024 if we don't multiply by 1000 before dividing by the
runtime (and then dividing by 1024 to get to next power-of-2).
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Martin Steigerwald [Mon, 7 May 2012 15:06:54 +0000 (17:06 +0200)]
Fix hyphen as minus sign errors by escaping minus signs.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Martin Steigerwald [Mon, 7 May 2012 15:06:26 +0000 (17:06 +0200)]
Fix manpage error warning: macro `hostname'' not defined.
Fix manpage error warning: macro `hostname'' not defined by using
different line wrapping.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Martin Steigerwald [Mon, 7 May 2012 15:06:13 +0000 (17:06 +0200)]
Fix spelling error in manpage.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 7 May 2012 07:56:00 +0000 (09:56 +0200)]
gfio: set option category for create_only
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 7 May 2012 07:54:41 +0000 (09:54 +0200)]
Merge branch 'master' into gfio
Conflicts:
Makefile
backend.c
client.c
fio.h
os/windows/install.wxs
server.c
server.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 7 May 2012 07:46:40 +0000 (09:46 +0200)]
Fix terse bandwidth
Off by 1.024
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 2 May 2012 12:29:21 +0000 (14:29 +0200)]
Merge branch 'master' of ssh://brick.kernel.dk/data/git/fio
Jens Axboe [Wed, 2 May 2012 11:59:09 +0000 (13:59 +0200)]
Remove deprecated rwmixcycle option from the man page
It has no effect, remove it.
Suggested-by: Roger Sibert <Roger_Sibert@xyratex.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 2 May 2012 11:58:02 +0000 (13:58 +0200)]
Add create_only option
If this option is set, then fio will only run the preparation
phase of a job. This means it will create all the files it
needs, but exit after that.
Suggested-by: Georg Schönberger <gschoenberger@thomas-krenn.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 26 Apr 2012 17:39:47 +0000 (19:39 +0200)]
Fix man page type
"one" -> "done".
Reported-by: Roger Sibert <Roger_Sibert@xyratex.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Tao Ma [Thu, 26 Apr 2012 10:15:46 +0000 (12:15 +0200)]
fio: Add to cgroup if parameter "cgroup" is enabled.
Currently, we only add the tasks to cgroup if cgroup_weight is set by
the user. But if we want to test other blkcg parameters like block
throttle, the fio tasks isn't added to the corresponding cgroup and
it doesn't make sense.
So add the task to the corresponding cgroup if the cgroup name is given.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 18 Apr 2012 18:39:48 +0000 (20:39 +0200)]
Fix for crash with more than ~500 jobs
We simply overwrite our status output buffer, not a terribly
good idea.
Reported-by: Roger Sibert <Roger_Sibert@xyratex.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Bruce Cran [Mon, 16 Apr 2012 17:33:03 +0000 (19:33 +0200)]
Windows build fixes
Bruce writes:
SIGUSR1 isn't defined on Windows so I've defined it.
Also, MSI packages need a version string of x.x.x.x where x is between 0
and 65535 so we can't include the git hash. It's easier just to go back
to hard-coding the version for now, and I'll update it (and the product
GUID) when I create a new package (it doesn't need checked in each
time).
Also, Cygwin doesn't like $(SHELL_PATH) but $(SHELL) seems to work -
does $(SHELL) cause a problem on other platforms?
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 16 Apr 2012 09:44:48 +0000 (11:44 +0200)]
Enlarge probe version field
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 16 Apr 2012 09:48:45 +0000 (11:48 +0200)]
gfio: use light yellow as graph background
Easier on the eyes.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 16 Apr 2012 09:44:48 +0000 (11:44 +0200)]
Enlarge probe version field
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 16 Apr 2012 07:52:22 +0000 (09:52 +0200)]
Get rid of fio_version.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 16 Apr 2012 07:42:53 +0000 (09:42 +0200)]
Get rid of fio_version.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Conflicts:
fio_version.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 17:18:49 +0000 (19:18 +0200)]
Fix for non-git versions
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 17:18:49 +0000 (19:18 +0200)]
Fix for non-git versions
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 12:23:17 +0000 (14:23 +0200)]
graph: use rounded graph connections
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 12:06:08 +0000 (14:06 +0200)]
Ensure that init depends on FIO-VERSION-FILE
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Conflicts:
Makefile
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 12:06:08 +0000 (14:06 +0200)]
Ensure that init depends on FIO-VERSION-FILE
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 13 Apr 2012 11:54:02 +0000 (13:54 +0200)]
graph: tighten up tickmark lines a bit
Still have a fuzzy feel at some of the boundaries, not sure why yet.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 12 Apr 2012 09:16:17 +0000 (11:16 +0200)]
graph: add shading for line graphs
Pretty simple, just a continually ligher shade of gray off the
top X border, and rightmost Y border.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 12 Apr 2012 07:18:38 +0000 (09:18 +0200)]
Document the use of the USR1 signal for dumping runtime statistics
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 11 Apr 2012 20:25:26 +0000 (22:25 +0200)]
Fix repeated link of fio
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 11 Apr 2012 20:24:19 +0000 (22:24 +0200)]
Fix repeated link of fio
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 11 Apr 2012 20:07:07 +0000 (22:07 +0200)]
Make fio include the git version in the version output
Makes it easier in bug reporting, don't have to ask people what
they are running...
Here's to you, Kep.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Conflicts:
Makefile
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 30 Mar 2012 08:30:35 +0000 (10:30 +0200)]
Define SIGUSR1 to inform fio to dump run stats while continuing to run
For long running jobs, it may be interesting to see the stats without
having to terminate the job. Set up SIGUSR1 so that it does that,
gives you the stats at that point in time.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 30 Mar 2012 06:33:27 +0000 (08:33 +0200)]
Free disk util on exit, not on stats display
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 11 Apr 2012 12:49:06 +0000 (14:49 +0200)]
Fio 2.0.7
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Lucian Adrian Grijincu [Fri, 6 Apr 2012 00:18:35 +0000 (18:18 -0600)]
HOWTO: typo: write_log_log -> write_lat_log + use suffix
- I guess 'write_log_log' was a copy-pasta typo.
- You used 'suffix' everywhere except for two places where you said
'postfix'.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 5 Apr 2012 14:58:31 +0000 (08:58 -0600)]
Merge branch 'master' into gfio
Conflicts:
fio.c
fio.h
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 5 Apr 2012 14:42:11 +0000 (08:42 -0600)]
group reporting: fix bad values of min/max
If you look at the fio output, the group reporting min and max
bandwidth don't match what the actual job reports. This is due
to an error in calculating the min and max values. The aggregate
value is correct, and matches what the job reports.
This did not affect the values that are usually used for reporting,
it's only affecting the group run status output.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 4 Apr 2012 20:11:58 +0000 (14:11 -0600)]
iolog: remove assert in io_u overlap
This can happen very rarely for time based jobs. Before we
had this as an assert since it was an impossible to hit
condition, but now it can be expected very rarely with
verify and time based jobs.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Bruce Cran [Wed, 4 Apr 2012 14:35:13 +0000 (08:35 -0600)]
Windows fixes
Only return from fio_windowsaio_getevents if the minimum number of IOs has
completed.
Add posix_fallocate implementation to avoid extending the file during the test.
Move call to ResetEvent into windowsaio_getevents where other reset code is
located.
Fix tabs vs. spaces in windowsaio.c and the installer sources.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Bruce Cran [Wed, 4 Apr 2012 00:00:00 +0000 (18:00 -0600)]
Fix address truncation on Windows
Avoid having PAGE_ALIGN truncate addresses by using a pointer-sized
variable for the page size and mask.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Lucian Adrian Grijincu [Tue, 3 Apr 2012 20:42:48 +0000 (14:42 -0600)]
HOWTO: emphasize units in --minimal mode: latency in usec, bw in KB/s
It wasn't clear what unit were used in --minimal mode.
Signed-off-by: Lucian Adrian Grijincu <lucian@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 2 Apr 2012 16:47:34 +0000 (09:47 -0700)]
Merge branch 'master' into gfio
Jens Axboe [Mon, 2 Apr 2012 16:47:09 +0000 (09:47 -0700)]
Add indication of whether a job got killed
We have 'X' for exited with error, add 'K' for killed by
signal as well.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 2 Apr 2012 14:03:26 +0000 (07:03 -0700)]
HOWTO: update to note base of latencies in minimal/terse output
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 31 Mar 2012 23:02:08 +0000 (16:02 -0700)]
Fixup link of t/ieee754 test
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 31 Mar 2012 11:55:54 +0000 (13:55 +0200)]
options: group tiobench options together
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 30 Mar 2012 19:21:20 +0000 (21:21 +0200)]
Enhance the reaped status display
Instead of just printing a '_' for a job that has exited,
allow the user to tell if the job exited with an error or
not. A normally reaped job that ran to completion without
errors will have the '_' displayed. If the job exited with
an error, then an 'X' will be displayed instead.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 30 Mar 2012 08:30:35 +0000 (10:30 +0200)]
Define SIGUSR1 to inform fio to dump run stats while continuing to run
For long running jobs, it may be interesting to see the stats without
having to terminate the job. Set up SIGUSR1 so that it does that,
gives you the stats at that point in time.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 30 Mar 2012 06:33:27 +0000 (08:33 +0200)]
Free disk util on exit, not on stats display
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 29 Mar 2012 19:17:12 +0000 (21:17 +0200)]
options: get rid of more .cb option usage we don't need
- The lat/bw/iops log does not need two ways of storing whether
they are enabled or not. Just change the option to a string
storing variant, and use the existance of a filename to see
if it's set or not.
- The trim_percentage option need not have a callback, the
parser knows the limits and can store it appropriately.
- The verify_offset option can express it's minimum value
directly, it doesn't need a callback to set it on its own.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Thu, 29 Mar 2012 06:33:15 +0000 (08:33 +0200)]
options: move ioprio/ioprio_class into thread_options space
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 19:38:24 +0000 (21:38 +0200)]
server: include number of CPUs in probe reply
We'll need this for affinity mask setting. Also add room
for flags, we'll want to pass back a flag mask of supported
features on the remote end.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 18:52:55 +0000 (20:52 +0200)]
Add o->lockmem to conversion functions
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 18:50:15 +0000 (20:50 +0200)]
Make lockmem a per job option
We need to get rid of per job options that fiddle with global
state. It's confusing, and it breaks remote option handling.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 12:01:46 +0000 (14:01 +0200)]
Start the process of making options more gfio friendly
We either need to eliminate the option callbacks, or ensure that
they don't have side effects outside of touching td->o. We will
need to use &td->o as the data passed in for the callbacks, not
the full td.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 10:22:40 +0000 (12:22 +0200)]
backend: ensure that server side releases/frees shm segment on exit
We were leaking one for every job run.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Stephen M. Cameron [Wed, 28 Mar 2012 09:02:52 +0000 (11:02 +0200)]
cairo_text_helpers: fix left justified text
Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 08:27:42 +0000 (10:27 +0200)]
gfio: change job option view
Instead of having a top notebook containing jobs, and subnotebooks
containing options, have just the one subnotebook and change the
viewed options by selecting the job in a combo box at the top.
This greatly reduces the number of widgets displayed for a big
number of jobs, speeding it up.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 07:15:32 +0000 (09:15 +0200)]
client: remove command reply after calling into client update_job
Ensures that it's definitely processed by the time the client
has waited for it.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Wed, 28 Mar 2012 07:15:05 +0000 (09:15 +0200)]
server: fix bug in going from thread_number to thread
thread_numbers start at 1, not 0.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 27 Mar 2012 14:03:04 +0000 (16:03 +0200)]
gfio: start of being able to update options
Not quite done yet, but it's a start.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 27 Mar 2012 08:06:42 +0000 (10:06 +0200)]
server: add support for updating job options
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 27 Mar 2012 07:12:39 +0000 (09:12 +0200)]
White space spring cleaning
Lets squash them all, with a bit of tooling help.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Tue, 27 Mar 2012 06:16:29 +0000 (08:16 +0200)]
printing: whitespace damage
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Stephen M. Cameron [Tue, 27 Mar 2012 06:14:48 +0000 (08:14 +0200)]
gfio: Add "print" option for results page.
It doesn't really print the results page yet, just a kind of test page.
Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Stephen M. Cameron [Tue, 27 Mar 2012 06:14:09 +0000 (08:14 +0200)]
graph: factor out cairo text drawing helpers
Signed-off-by: Stephen M. Cameron <stephenmcameron@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 19:08:46 +0000 (21:08 +0200)]
Add named log level
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 18:31:32 +0000 (20:31 +0200)]
gcompat: gtk_widget_set_can_focus() for below 2.18
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 18:27:52 +0000 (20:27 +0200)]
gcompat: gtk_widget_get_window() for below 2.14
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 17:34:15 +0000 (19:34 +0200)]
gfio: use appropriate gtk signal for draw/expose of graphs
draw on gtk3, expose_event on gtk2.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 17:30:24 +0000 (19:30 +0200)]
gcompat: get closer to working with gtk3
Just need the draw event now, instead of the expose_event.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 12:28:36 +0000 (14:28 +0200)]
goptions: ensure that gopt_str_multi options get freed
Was missing the destroy handler.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 12:25:26 +0000 (14:25 +0200)]
goptions: let destroy handler free changed options too
We can't touch the memory in the destroy handler, since it could
already have been freed. Just always leave the freeing of option
memory to the destructors.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 11:51:11 +0000 (13:51 +0200)]
gcompat: provide backwards compatible functions for older gtk versions
Attempt to do something that'll work equally well across gtk versions,
to improve the supported range.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 10:55:33 +0000 (12:55 +0200)]
gfio: use G_OBJECT(), not GTK_OBJECT()
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 10:38:33 +0000 (12:38 +0200)]
goptions: fix check button storaage for FIO_OPT_STR_MULTI
i was not incremented...
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Mon, 26 Mar 2012 10:18:23 +0000 (12:18 +0200)]
goptions: handle changing of options in job edit
Track what options have changed, and store them into the
options structure that we have for the given job.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 24 Mar 2012 19:35:16 +0000 (20:35 +0100)]
goptions: use gopt->gjv for option hiding
We can't rely on gui_data for the gjv lookup, since it'll be
different for each job tab. Instead use the cached value
in the gopt structure, since that is allocate for each client.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 24 Mar 2012 19:25:33 +0000 (20:25 +0100)]
goptions: don't override gopt dep tree by mistake
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 24 Mar 2012 19:22:29 +0000 (20:22 +0100)]
gfio: add per-job option view
The option view is now a master notebook of jobs that got added
from a given job file, with each tab holding a new notebook
with tabs for the options.
This is pretty slow for big jobs. Adding eg the 1mbs-clients.fio
example job file shows this nicely, since it contains 32 jobs.
Will need to look into how to speed this up.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Sat, 24 Mar 2012 07:56:50 +0000 (08:56 +0100)]
gfio: start of per-job option edit
Currently we don't properly handle job files with multiple
job entries in them, each one just overwrites the last.
Start tracking all of them.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 23 Mar 2012 18:22:21 +0000 (19:22 +0100)]
stat: move final \n of terse output to the end
Don't print a new line, description, then another new line.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 23 Mar 2012 12:43:19 +0000 (13:43 +0100)]
Add regression test for
ae2fafc8
Signed-off-by: Jens Axboe <axboe@kernel.dk>
webee [Fri, 23 Mar 2012 12:41:41 +0000 (13:41 +0100)]
verify: verify bytes should not add to this_io_bytes
When rw=readwrite,verify+backlog, the verify are treated as normal
read, and bytes are added to this_io_bytes, cause fio terminate early.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 23 Mar 2012 12:40:06 +0000 (13:40 +0100)]
Allow readwrite as an alias for rw in setting sequential read/write
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 23 Mar 2012 12:19:31 +0000 (13:19 +0100)]
client: use eta msec as the poll interval
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Jens Axboe [Fri, 23 Mar 2012 11:25:18 +0000 (12:25 +0100)]
server: idle a bit more of we are not expecting work
Don't wakeup every 100msec if we are not expecting an event
that wont already wakes up poll() automatically.
Signed-off-by: Jens Axboe <axboe@kernel.dk>