USB: dummy-hcd: Adapt dummy_udc_set_speed()
authorRoger Quadros <rogerq@ti.com>
Thu, 2 Nov 2017 09:09:17 +0000 (11:09 +0200)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 11 Dec 2017 10:36:52 +0000 (12:36 +0200)
The UDC core ensures that .udc_set_speed() is called with
a speed that is a minimum of the max speeds supported
by the gadget function driver and the UDC driver.

We can now use the speed argument as is.

Get rid of the debug print as that condition will never happen.

Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/gadget/udc/dummy_hcd.c

index cf6985b5767c74552e6bb2d9281c366efe837b4c..e744d4b7bfed4deb4d2110f328f8eb939dd2bfe9 100644 (file)
@@ -925,20 +925,8 @@ static void dummy_udc_set_speed(struct usb_gadget *_gadget,
        struct dummy    *dum;
 
        dum = gadget_dev_to_dummy(&_gadget->dev);
-
-        if (mod_data.is_super_speed)
-                dum->gadget.speed = min_t(u8, USB_SPEED_SUPER, speed);
-        else if (mod_data.is_high_speed)
-                dum->gadget.speed = min_t(u8, USB_SPEED_HIGH, speed);
-        else
-                dum->gadget.speed = USB_SPEED_FULL;
-
+       dum->gadget.speed = speed;
        dummy_udc_update_ep0(dum);
-
-       if (dum->gadget.speed < speed)
-               dev_dbg(udc_dev(dum), "This device can perform faster"
-                       " if you connect it to a %s port...\n",
-                       usb_speed_string(speed));
 }
 
 static int dummy_udc_start(struct usb_gadget *g,