btrfs: change btrfs_fs_devices::rotating to bool
authorJohannes Thumshirn <jthumshirn@suse.de>
Wed, 13 Nov 2019 10:27:28 +0000 (11:27 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 18 Nov 2019 16:51:51 +0000 (17:51 +0100)
struct btrfs_fs_devices::rotating currently is declared as an integer
variable but only used as a boolean.

Change the variable definition to bool and update to code touching it to
set 'true' and 'false'.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c
fs/btrfs/volumes.h

index ade40df9b5596822f7c27725a0c4e47ac59eb5b0..d8e5560db285a0bbee1e7ce5e52d224ce35b08ab 100644 (file)
@@ -644,7 +644,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
 
        q = bdev_get_queue(bdev);
        if (!blk_queue_nonrot(q))
-               fs_devices->rotating = 1;
+               fs_devices->rotating = true;
 
        device->bdev = bdev;
        clear_bit(BTRFS_DEV_STATE_IN_FS_METADATA, &device->dev_state);
@@ -2274,7 +2274,7 @@ static int btrfs_prepare_sprout(struct btrfs_fs_info *fs_info)
        fs_devices->num_devices = 0;
        fs_devices->open_devices = 0;
        fs_devices->missing_devices = 0;
-       fs_devices->rotating = 0;
+       fs_devices->rotating = false;
        fs_devices->seed = seed_devices;
 
        generate_random_uuid(fs_devices->fsid);
@@ -2469,7 +2469,7 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
        atomic64_add(device->total_bytes, &fs_info->free_chunk_space);
 
        if (!blk_queue_nonrot(q))
-               fs_devices->rotating = 1;
+               fs_devices->rotating = true;
 
        orig_super_total_bytes = btrfs_super_total_bytes(fs_info->super_copy);
        btrfs_set_super_total_bytes(fs_info->super_copy,
index 8e9513b3fe9d4f7163a5cb69be3a93edc0208400..fc1b564b9cfe57c2d2e5fea01ffab722169854e4 100644 (file)
@@ -250,7 +250,7 @@ struct btrfs_fs_devices {
        /* set when we find or add a device that doesn't have the
         * nonrot flag set
         */
-       int rotating;
+       bool rotating;
 
        struct btrfs_fs_info *fs_info;
        /* sysfs kobjects */