btrfs: change btrfs_fs_devices::seeding to bool
authorJohannes Thumshirn <jthumshirn@suse.de>
Wed, 13 Nov 2019 10:27:27 +0000 (11:27 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 18 Nov 2019 16:51:51 +0000 (17:51 +0100)
struct btrfs_fs_devices::seeding currently is declared as an integer
variable but only used as a boolean.

Change the variable definition to bool and update to code touching it to
set 'true' and 'false'.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c
fs/btrfs/volumes.h

index 22a5bd991e47a12742e35217fb3d966d2ef671d7..ade40df9b5596822f7c27725a0c4e47ac59eb5b0 100644 (file)
@@ -634,7 +634,7 @@ static int btrfs_open_one_device(struct btrfs_fs_devices *fs_devices,
                }
 
                clear_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
-               fs_devices->seeding = 1;
+               fs_devices->seeding = true;
        } else {
                if (bdev_read_only(bdev))
                        clear_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state);
@@ -1115,7 +1115,7 @@ static int close_fs_devices(struct btrfs_fs_devices *fs_devices)
        WARN_ON(fs_devices->open_devices);
        WARN_ON(fs_devices->rw_devices);
        fs_devices->opened = 0;
-       fs_devices->seeding = 0;
+       fs_devices->seeding = false;
 
        return 0;
 }
@@ -2270,7 +2270,7 @@ static int btrfs_prepare_sprout(struct btrfs_fs_info *fs_info)
        list_splice_init(&fs_devices->alloc_list, &seed_devices->alloc_list);
        mutex_unlock(&fs_info->chunk_mutex);
 
-       fs_devices->seeding = 0;
+       fs_devices->seeding = false;
        fs_devices->num_devices = 0;
        fs_devices->open_devices = 0;
        fs_devices->missing_devices = 0;
@@ -6654,7 +6654,7 @@ static struct btrfs_fs_devices *open_seed_devices(struct btrfs_fs_info *fs_info,
                if (IS_ERR(fs_devices))
                        return fs_devices;
 
-               fs_devices->seeding = 1;
+               fs_devices->seeding = true;
                fs_devices->opened = 1;
                return fs_devices;
        }
index 46987a2da786cb780b1f0c33916dcb714a78b936..8e9513b3fe9d4f7163a5cb69be3a93edc0208400 100644 (file)
@@ -243,7 +243,7 @@ struct btrfs_fs_devices {
        struct list_head alloc_list;
 
        struct btrfs_fs_devices *seed;
-       int seeding;
+       bool seeding;
 
        int opened;