cpufreq: Use has_target() instead of !setpolicy
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 20 Jun 2019 03:05:48 +0000 (08:35 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 26 Jun 2019 09:41:04 +0000 (11:41 +0200)
For code consistency, use has_target() instead of !setpolicy everywhere,
as it is already done at several places. Maybe we should also use
"!has_target()" instead of "cpufreq_driver->setpolicy" where we need to
check if the driver supports setpolicy, so to use only one expression
for this kind of differentiation.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index 8caec52117266b35dfd0d7373b91fb2cf4b062c0..555a626464910b7256eeed188ab816a453da43ab 100644 (file)
@@ -634,7 +634,7 @@ static int cpufreq_parse_policy(char *str_governor,
 }
 
 /**
- * cpufreq_parse_governor - parse a governor string only for !setpolicy
+ * cpufreq_parse_governor - parse a governor string only for has_target()
  */
 static int cpufreq_parse_governor(char *str_governor,
                                  struct cpufreq_policy *policy)
@@ -1303,7 +1303,7 @@ static int cpufreq_online(unsigned int cpu)
                policy->max = policy->user_policy.max;
        }
 
-       if (cpufreq_driver->get && !cpufreq_driver->setpolicy) {
+       if (cpufreq_driver->get && has_target()) {
                policy->cur = cpufreq_driver->get(policy->cpu);
                if (!policy->cur) {
                        pr_err("%s: ->get() failed\n", __func__);
@@ -2402,7 +2402,7 @@ void cpufreq_update_policy(unsigned int cpu)
         * BIOS might change freq behind our back
         * -> ask driver for current freq and notify governors about a change
         */
-       if (cpufreq_driver->get && !cpufreq_driver->setpolicy &&
+       if (cpufreq_driver->get && has_target() &&
            (cpufreq_suspended || WARN_ON(!cpufreq_update_current_freq(policy))))
                goto unlock;