Kill "No I/O performed by ..." message
authorJens Axboe <axboe@kernel.dk>
Tue, 20 Nov 2018 18:59:36 +0000 (11:59 -0700)
committerJens Axboe <axboe@kernel.dk>
Tue, 20 Nov 2018 18:59:36 +0000 (11:59 -0700)
We keep finding false triggers for this, and it's driving me
nuts. Kill it with fire.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
backend.c

index a92ec456609e1c6541e4896215cff78b8809d85f..d64cc9922114b48cc241f9e3b6d67e52767dabc7 100644 (file)
--- a/backend.c
+++ b/backend.c
@@ -1542,7 +1542,7 @@ static void *thread_main(void *data)
        struct sk_out *sk_out = fd->sk_out;
        uint64_t bytes_done[DDIR_RWDIR_CNT];
        int deadlock_loop_cnt;
-       bool clear_state, did_some_io;
+       bool clear_state;
        int ret;
 
        sk_out_assign(sk_out);
@@ -1763,7 +1763,6 @@ static void *thread_main(void *data)
 
        memset(bytes_done, 0, sizeof(bytes_done));
        clear_state = false;
-       did_some_io = false;
 
        while (keep_running(td)) {
                uint64_t verify_bytes;
@@ -1841,9 +1840,6 @@ static void *thread_main(void *data)
                    td_ioengine_flagged(td, FIO_UNIDIR))
                        continue;
 
-               if (ddir_rw_sum(bytes_done))
-                       did_some_io = true;
-
                clear_io_state(td, 0);
 
                fio_gettime(&td->start, NULL);
@@ -1864,19 +1860,6 @@ static void *thread_main(void *data)
                        break;
        }
 
-       /*
-        * If td ended up with no I/O when it should have had,
-        * then something went wrong unless FIO_NOIO or FIO_DISKLESSIO.
-        * (Are we not missing other flags that can be ignored ?)
-        */
-       if (!td->error && (td->o.size || td->o.io_size) &&
-           !ddir_rw_sum(bytes_done) && !did_some_io && !td->o.create_only &&
-           !(td_ioengine_flagged(td, FIO_NOIO) ||
-             td_ioengine_flagged(td, FIO_DISKLESSIO)))
-               log_err("%s: No I/O performed by %s, "
-                        "perhaps try --debug=io option for details?\n",
-                        td->o.name, td->io_ops->name);
-
        /*
         * Acquire this lock if we were doing overlap checking in
         * offload mode so that we don't clean up this job while