Use length guarded sprintf functions

Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/infolog.c b/infolog.c
index 8396522e206f3dc3d4b501b77554ea93e3ebe8f5..b7b4a5e941db903fb4b83a66c49d8a64c7d375a1 100644 (file)
--- a/infolog.c
+++ b/infolog.c
@@ -12,7 +12,7 @@ int log_info(const char *format, ...)
        size_t len;
 
        va_start(args, format);
        size_t len;
 
        va_start(args, format);

-       len = vsprintf(buffer, format, args);
+       len = vsnprintf(buffer, sizeof(buffer), format, args);

        va_end(args);
 
        if (is_backend)
        va_end(args);
 
        if (is_backend)


@@ -28,7 +28,7 @@ int log_err(const char *format, ...)
        size_t len;
 
        va_start(args, format);
        size_t len;
 
        va_start(args, format);

-       len = vsprintf(buffer, format, args);
+       len = vsnprintf(buffer, sizeof(buffer), format, args);

        va_end(args);
 
        if (is_backend)
        va_end(args);
 
        if (is_backend)

diff --git a/server.c b/server.c
index 4a78f38396c2a2eb0fc99808d565288c7e695705..a70dc14f414aefad94812840b20b2c326e6b76cf 100644 (file)
--- a/server.c
+++ b/server.c
@@ -143,7 +143,6 @@ struct fio_net_cmd *fio_net_cmd_read(int sk)
                return NULL;
        }
 
                return NULL;
        }
 

-

        return ret;
 }
 
        return ret;
 }
 


@@ -392,7 +391,7 @@ int fio_server_log(const char *format, ...)
        va_list args;
 
        va_start(args, format);
        va_list args;
 
        va_start(args, format);

-       sprintf(buffer, format, args);
+       snprintf(buffer, sizeof(buffer), format, args);

        va_end(args);
 
        return fio_server_text_output(buffer, strlen(buffer));
        va_end(args);
 
        return fio_server_text_output(buffer, strlen(buffer));