/*
* Check for option conflicts
*/
- if (has_cmdprio_percentage &&
- (fio_option_is_set(to, ioprio) ||
- fio_option_is_set(to, ioprio_class))) {
- log_err("%s: cmdprio_percentage option and mutually exclusive "
- "prio or prioclass option is set, exiting\n",
- to->name);
- return 1;
- }
- if (has_cmdprio_bssplit &&
- (fio_option_is_set(to, ioprio) ||
- fio_option_is_set(to, ioprio_class))) {
- log_err("%s: cmdprio_bssplit option and mutually exclusive "
- "prio or prioclass option is set, exiting\n",
- to->name);
- return 1;
- }
if (has_cmdprio_percentage && has_cmdprio_bssplit) {
log_err("%s: cmdprio_percentage and cmdprio_bssplit options "
"are mutually exclusive\n",
int queued;
int cq_ring_off;
unsigned iodepth;
- bool ioprio_class_set;
- bool ioprio_set;
int prepped;
struct ioring_mmap mmap[3];
sqe->rw_flags |= RWF_UNCACHED;
if (o->nowait)
sqe->rw_flags |= RWF_NOWAIT;
- if (ld->ioprio_class_set)
- sqe->ioprio = td->o.ioprio_class << 13;
- if (ld->ioprio_set)
- sqe->ioprio |= td->o.ioprio;
sqe->off = io_u->offset;
} else if (ddir_sync(io_u->ddir)) {
sqe->ioprio = 0;
struct cmdprio *cmdprio = &o->cmdprio;
enum fio_ddir ddir = io_u->ddir;
unsigned int p = fio_cmdprio_percentage(cmdprio, io_u);
+ unsigned int cmdprio_value =
+ ioprio_value(cmdprio->class[ddir], cmdprio->level[ddir]);
if (p && rand_between(&td->prio_state, 0, 99) < p) {
- sqe->ioprio =
- ioprio_value(cmdprio->class[ddir], cmdprio->level[ddir]);
- io_u->flags |= IO_U_F_PRIORITY;
+ sqe->ioprio = cmdprio_value;
+ if (!td->ioprio || cmdprio_value < td->ioprio) {
+ /*
+ * The async IO priority is higher (has a lower value)
+ * than the priority set by "prio" and "prioclass"
+ * options.
+ */
+ io_u->flags |= IO_U_F_PRIORITY;
+ }
} else {
- sqe->ioprio = 0;
+ sqe->ioprio = td->ioprio;
+ if (cmdprio_value && td->ioprio && td->ioprio < cmdprio_value) {
+ /*
+ * The IO will be executed with the priority set by
+ * "prio" and "prioclass" options, and this priority
+ * is higher (has a lower value) than the async IO
+ * priority.
+ */
+ io_u->flags |= IO_U_F_PRIORITY;
+ }
}
}
struct ioring_options *o = td->eo;
struct ioring_data *ld;
struct cmdprio *cmdprio = &o->cmdprio;
+ bool has_cmdprio = false;
int ret;
/* sqthread submission requires registered files */
td->io_ops_data = ld;
- ret = fio_cmdprio_init(td, cmdprio, &ld->use_cmdprio);
+ ret = fio_cmdprio_init(td, cmdprio, &has_cmdprio);
if (ret) {
td_verror(td, EINVAL, "fio_ioring_init");
return 1;
}
- if (fio_option_is_set(&td->o, ioprio_class))
- ld->ioprio_class_set = true;
- if (fio_option_is_set(&td->o, ioprio))
- ld->ioprio_set = true;
+ /*
+ * Since io_uring can have a submission context (sqthread_poll) that is
+ * different from the process context, we cannot rely on the the IO
+ * priority set by ioprio_set() (option prio/prioclass) to be inherited.
+ * Therefore, we set the sqe->ioprio field when prio/prioclass is used.
+ */
+ ld->use_cmdprio = has_cmdprio ||
+ fio_option_is_set(&td->o, ioprio_class) ||
+ fio_option_is_set(&td->o, ioprio);
return 0;
}
struct cmdprio *cmdprio = &o->cmdprio;
enum fio_ddir ddir = io_u->ddir;
unsigned int p = fio_cmdprio_percentage(cmdprio, io_u);
+ unsigned int cmdprio_value =
+ ioprio_value(cmdprio->class[ddir], cmdprio->level[ddir]);
if (p && rand_between(&td->prio_state, 0, 99) < p) {
- io_u->iocb.aio_reqprio =
- ioprio_value(cmdprio->class[ddir], cmdprio->level[ddir]);
+ io_u->iocb.aio_reqprio = cmdprio_value;
io_u->iocb.u.c.flags |= IOCB_FLAG_IOPRIO;
+ if (!td->ioprio || cmdprio_value < td->ioprio) {
+ /*
+ * The async IO priority is higher (has a lower value)
+ * than the default context priority.
+ */
+ io_u->flags |= IO_U_F_PRIORITY;
+ }
+ } else if (td->ioprio && td->ioprio < cmdprio_value) {
+ /*
+ * The IO will be executed with the default context priority,
+ * and this priority is higher (has a lower value) than the
+ * async IO priority.
+ */
io_u->flags |= IO_U_F_PRIORITY;
}
}