ublk: remove check IO_URING_F_SQE128 in ublk_ch_uring_cmd
authorMing Lei <ming.lei@redhat.com>
Mon, 20 Feb 2023 04:14:13 +0000 (12:14 +0800)
committerJens Axboe <axboe@kernel.dk>
Tue, 21 Feb 2023 16:27:23 +0000 (09:27 -0700)
sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE,
so not necessary to check IO_URING_F_SQE128.

With this change, we get chance to save half SQ ring memory.

Fixed: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230220041413.1524335-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index f48d213fb65e897a538c8d034bf22c6f6e9172c7..09d29fa53939c5798aad1d45756aa53880dd5689 100644 (file)
@@ -1271,9 +1271,6 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags)
                        __func__, cmd->cmd_op, ub_cmd->q_id, tag,
                        ub_cmd->result);
 
-       if (!(issue_flags & IO_URING_F_SQE128))
-               goto out;
-
        if (ub_cmd->q_id >= ub->dev_info.nr_hw_queues)
                goto out;