block: ublk_drv: clean up several helpers
authorMing Lei <ming.lei@redhat.com>
Thu, 30 Mar 2023 11:36:23 +0000 (19:36 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 3 Apr 2023 01:22:55 +0000 (19:22 -0600)
Convert the following pattern in several helpers
if (Z)
return true
return false
into:
return Z;

Reviewed-by: Ziyang Zhang <ZiyangZhang@linux.alibaba.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c

index 439bd5773715c4f8338701fd2ceb349a3ea40072..a40edc437c9f9982421492c04b66de085c0f4d67 100644 (file)
@@ -298,9 +298,7 @@ static inline bool ublk_can_use_task_work(const struct ublk_queue *ubq)
 
 static inline bool ublk_need_get_data(const struct ublk_queue *ubq)
 {
-       if (ubq->flags & UBLK_F_NEED_GET_DATA)
-               return true;
-       return false;
+       return ubq->flags & UBLK_F_NEED_GET_DATA;
 }
 
 static struct ublk_device *ublk_get_device(struct ublk_device *ub)
@@ -349,25 +347,19 @@ static inline int ublk_queue_cmd_buf_size(struct ublk_device *ub, int q_id)
 static inline bool ublk_queue_can_use_recovery_reissue(
                struct ublk_queue *ubq)
 {
-       if ((ubq->flags & UBLK_F_USER_RECOVERY) &&
-                       (ubq->flags & UBLK_F_USER_RECOVERY_REISSUE))
-               return true;
-       return false;
+       return (ubq->flags & UBLK_F_USER_RECOVERY) &&
+                       (ubq->flags & UBLK_F_USER_RECOVERY_REISSUE);
 }
 
 static inline bool ublk_queue_can_use_recovery(
                struct ublk_queue *ubq)
 {
-       if (ubq->flags & UBLK_F_USER_RECOVERY)
-               return true;
-       return false;
+       return ubq->flags & UBLK_F_USER_RECOVERY;
 }
 
 static inline bool ublk_can_use_recovery(struct ublk_device *ub)
 {
-       if (ub->dev_info.flags & UBLK_F_USER_RECOVERY)
-               return true;
-       return false;
+       return ub->dev_info.flags & UBLK_F_USER_RECOVERY;
 }
 
 static void ublk_free_disk(struct gendisk *disk)