blk-cgroup: avoid to warn !rcu_read_lock_held() in blkg_lookup()
authorMing Lei <ming.lei@redhat.com>
Fri, 17 Nov 2023 02:35:23 +0000 (10:35 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 17 Nov 2023 17:48:58 +0000 (10:48 -0700)
So far, all callers either holds spin lock or rcu read explicitly, and
most of the caller has added WARN_ON_ONCE(!rcu_read_lock_held()) or
lockdep_assert_held(&disk->queue->queue_lock).

Remove WARN_ON_ONCE(!rcu_read_lock_held()) from blkg_lookup() for
killing the false positive warning from blkg_conf_prep().

Reported-by: Changhui Zhong <czhong@redhat.com>
Fixes: 83462a6c971c ("blkcg: Drop unnecessary RCU read [un]locks from blkg_conf_prep/finish()")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20231117023527.3188627-3-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-cgroup.h

index 624c03c8fe64e37f4ff742b27a1d1fa2d2588c39..fd482439afbc9aa810471db434217dcb5e06c296 100644 (file)
@@ -249,8 +249,6 @@ static inline struct blkcg_gq *blkg_lookup(struct blkcg *blkcg,
 {
        struct blkcg_gq *blkg;
 
-       WARN_ON_ONCE(!rcu_read_lock_held());
-
        if (blkcg == &blkcg_root)
                return q->root_blkg;