fio.git
5 days agoMerge branch 'msys2' of https://github.com/sitsofe/fio into master master
Jens Axboe [Tue, 15 Sep 2020 01:43:39 +0000 (19:43 -0600)]
Merge branch 'msys2' of https://github.com/sitsofe/fio into master

* 'msys2' of https://github.com/sitsofe/fio:
  travis: cleanup build script
  configure: cleanup lex/yacc tests
  memlock: avoid type confusion in format string
  Makefile: introduce FIO_CFLAGS
  appveyor: cleanup and add separate install script
  Makefile/ci: Don't pass CFLAGS when linking
  configure/Makefile: add option to generate pdb symbols
  configure: be explicit about "XP" Windows API version
  windows: fix DWORD format string complaints
  windows: fix wrong format strings
  net: coerce the result of htonl before printing
  configure: pass non-null pointer to (v)asprintf

5 days agoMerge branch 'backend' of https://github.com/bvanassche/fio into master
Jens Axboe [Tue, 15 Sep 2020 01:42:23 +0000 (19:42 -0600)]
Merge branch 'backend' of https://github.com/bvanassche/fio into master

* 'backend' of https://github.com/bvanassche/fio:
  backend: Use asprintf() instead of strlen() + sprintf()
  backend: Remove two superfluous casts

7 days agotravis: cleanup build script
Sitsofe Wheeler [Thu, 3 Sep 2020 22:02:31 +0000 (23:02 +0100)]
travis: cleanup build script

- Standardise on spaces for indentation
- Exit on error or using variables before they are defined
- Fix up shellcheck complaints by exporting some variables
- Drop printing of python 2 information as we don't use it
- Use type -p rather than which

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoconfigure: cleanup lex/yacc tests
Sitsofe Wheeler [Mon, 31 Aug 2020 13:59:59 +0000 (14:59 +0100)]
configure: cleanup lex/yacc tests

- Switch to prebuilt function for finding executable
- Search for the fl library from flex too
- Test lex command output directly

This allows lexing to be more likely to be found (e.g. MSYS2 but sadly
not MSYS2 Mingw-w64).

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agomemlock: avoid type confusion in format string
Sitsofe Wheeler [Mon, 31 Aug 2020 10:44:11 +0000 (11:44 +0100)]
memlock: avoid type confusion in format string

Windows GCC has the followng grumble:

t/memlock.c: In function 'worker':
t/memlock.c:25:26: error: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'long long unsigned int'} [-Werror=format=]
   25 |    printf("loop%d: did %lu MiB\n", i+1, size/(1024UL*1024UL));
      |                        ~~^              ~~~~~~~~~~~~~~~~~~~~
      |                          |                  |
      |                          long unsigned int  size_t {aka long long unsigned int}
      |                        %llu

Fix it up by just using the original variable that was already in
megabytes.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoMakefile: introduce FIO_CFLAGS
Sitsofe Wheeler [Sat, 22 Aug 2020 17:01:31 +0000 (18:01 +0100)]
Makefile: introduce FIO_CFLAGS

Build on the work  done in 4c0b3d98f2d05ddd3f16262c466dcedb22158065
("configure/Makefile: don't override user CFLAGS") by builing up all the
internal flags in a temporary variable.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoappveyor: cleanup and add separate install script
Sitsofe Wheeler [Wed, 19 Aug 2020 19:21:22 +0000 (20:21 +0100)]
appveyor: cleanup and add separate install script

- Rename PLATFORM environment variable to ARCHITECTURE to avoid clash
  with Appveyor variable
  (https://www.appveyor.com/docs/environment-variables/ )
- Introduce support for using MSYS2
- Perform clang builds that also package PDB symbols
- Drop PACKAGE_ARCH variable since it can be derived
- Switch some lines to just call native binaries directly

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoMakefile/ci: Don't pass CFLAGS when linking
Sitsofe Wheeler [Thu, 20 Aug 2020 08:05:03 +0000 (09:05 +0100)]
Makefile/ci: Don't pass CFLAGS when linking

There was an issue where a lld (the linker from LLVM) could fail because
a C compiler flag it didn't understand was passed to it. Fix this by no
longer passing CFLAGS to the linker.

As a result of the above, the travis "cross compiled" 32 bit Linux build
was changed to set LDFLAGS (so the linker can know about the cross
compiling).

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoconfigure/Makefile: add option to generate pdb symbols
Sitsofe Wheeler [Fri, 21 Aug 2020 19:35:03 +0000 (20:35 +0100)]
configure/Makefile: add option to generate pdb symbols

Recent versions of Windows clang and LLVM's lld have the ability to
build Windows PDB symbols for debugging so add an explicit option to
test for support and use it so.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agoconfigure: be explicit about "XP" Windows API version
Sitsofe Wheeler [Sat, 22 Aug 2020 19:40:58 +0000 (20:40 +0100)]
configure: be explicit about "XP" Windows API version

With a Cygwin Mingw-w64 environment, when an explicit Windows API
version define isn't set the Windows Server 2003 API is targeted
(https://github.com/mirror/mingw-w64/blob/a25dc933f3d3ed6c8529fb24b7ae393f8792ca69/mingw-w64-headers/include/sdkddkver.h#L166
). This means the XP build was actually misnamed and have never been
fully compatible with plain XP for many years (I suspect such binaries
will likely still work on XP bar trying to use the net ioengine)...

With an MSYS2 Mingw-w64 environment, the default Windows API version is
Windows 7
(https://github.com/msys2/MINGW-packages/blob/e9f271c61a39076ab5de56299f7fd86020c280ae/mingw-w64-headers-git/PKGBUILD#L55
) which breaks an "XP" build because we were were relying on the default
being 2003. Fix this by making the "XP" build explicitly target the
Windows Server 2003 API.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agowindows: fix DWORD format string complaints
Sitsofe Wheeler [Wed, 19 Aug 2020 22:58:35 +0000 (23:58 +0100)]
windows: fix DWORD format string complaints

Printing DWORD variables causes Windows clang to grumble about types:

os/windows/cpu-affinity.c:263:5: error: format specifies type 'int' but the argument has type 'DWORD' (aka 'unsigned long') [-Werror,-Wformat]
                         GetLastError());
                         ^~~~~~~~~~~~~~

Since a DWORD is defined to be an unsigned 32 bit integer and is
declared to be an unsigned long
(https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/262627d8-3418-4627-9218-4ffe110850b2
) just use long as the format specifier. When printing the cpu mask in
hex on legacy Windows builds, cast to unsigned long long which should be
safe because there won't be more than 64 CPUs with old versions of
Windows.

(As some format strings are longer than the wrapping width, make an
exception and avoid splitting/preserve them to make greping easier)

Suggested-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 days agowindows: fix wrong format strings
Sitsofe Wheeler [Thu, 20 Aug 2020 06:08:46 +0000 (07:08 +0100)]
windows: fix wrong format strings

Found by Windows clang which mysteriously seemed able to ignore
-Wno-format...

(As some format strings are longer than the wrapping width, make an
exception and avoid splitting/preserve them to make greping easier)

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
8 days agonet: coerce the result of htonl before printing
Sitsofe Wheeler [Wed, 19 Aug 2020 20:57:05 +0000 (21:57 +0100)]
net: coerce the result of htonl before printing

Technically htonl() returns a long on Windows
(https://docs.microsoft.com/en-us/windows/win32/api/winsock/nf-winsock-htonl
) which upsets clang.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
8 days agoconfigure: pass non-null pointer to (v)asprintf
Sitsofe Wheeler [Wed, 19 Aug 2020 22:02:48 +0000 (23:02 +0100)]
configure: pass non-null pointer to (v)asprintf

Windows clang warns about redefinition of (v)asprintf when targeting
Windows 7 because the configure test failed due to passing NULL when to
those functions when they tag key parameters with the nonnull attribute.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
8 days agobackend: Use asprintf() instead of strlen() + sprintf()
Bart Van Assche [Fri, 4 Sep 2020 23:05:37 +0000 (16:05 -0700)]
backend: Use asprintf() instead of strlen() + sprintf()

This patch does not change any functionality but makes exec_string() easier
to read.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
8 days agobackend: Remove two superfluous casts
Bart Van Assche [Fri, 4 Sep 2020 23:06:07 +0000 (16:06 -0700)]
backend: Remove two superfluous casts

Casting the type of a string constant to (const char *) is not necessary.
These casts were introduced by commit ce4864950d2c ("backend: Logging
exec_{pre|post}run").

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
8 days agoAllow offload with FAKEIO engines
Jens Axboe [Fri, 11 Sep 2020 15:58:15 +0000 (09:58 -0600)]
Allow offload with FAKEIO engines

The last check was too restrictive, we can allow it with the fake IO
engines.

Fixes: abfd235a0533 ("Disable io_submit_mode=offload with async engines")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
8 days agoDisable io_submit_mode=offload with async engines
Jens Axboe [Fri, 11 Sep 2020 15:18:09 +0000 (09:18 -0600)]
Disable io_submit_mode=offload with async engines

We have various cases that aren't handled correctly with async engines,
or cannot work with async engines. Disable it.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
8 days agoengines/io_uring: mark as not compatible with io_submit_mode=offload
Jens Axboe [Fri, 11 Sep 2020 14:52:51 +0000 (08:52 -0600)]
engines/io_uring: mark as not compatible with io_submit_mode=offload

Signed-off-by: Jens Axboe <axboe@kernel.dk>
10 days agoMerge branch 'evelu-enghelp' of https://github.com/ErwanAliasr1/fio into master
Jens Axboe [Wed, 9 Sep 2020 16:48:27 +0000 (10:48 -0600)]
Merge branch 'evelu-enghelp' of https://github.com/ErwanAliasr1/fio into master

* 'evelu-enghelp' of https://github.com/ErwanAliasr1/fio:
  init: exiting with fio_show_ioengine_help return code

10 days agoinit: exiting with fio_show_ioengine_help return code
Erwan Velu [Wed, 9 Sep 2020 16:31:25 +0000 (18:31 +0200)]
init: exiting with fio_show_ioengine_help return code

In the current code, calling --enghelp=<engine> always return 0.
But fio_show_ioengine_help() implemented a return code to inform when an engine is present or not.

This commit makes fio returning fio_show_ioengine_help() value when calling --enghelp=<engine>

A typical use case is detecting which engine is available on a given fio build.
It is possible to use the return code to determine if a given engine is available or not :

[user@host]# fio --enghelp=libaio
userspace_reap          : Use alternative user-space reap implementation
[user@host]# echo $?
0

[user@host]#fio --enghelp=io_uring
fio: engine io_uring not loadable
IO engine io_uring not found
[user@host]# echo $?
1

Signed-off-by: Erwan Velu <e.velu@criteo.com>
11 days agoMerge branch 'zbd' of https://github.com/bvanassche/fio into master
Jens Axboe [Tue, 8 Sep 2020 16:25:48 +0000 (10:25 -0600)]
Merge branch 'zbd' of https://github.com/bvanassche/fio into master

* 'zbd' of https://github.com/bvanassche/fio:
  zbd: Add a missing pthread_mutex_unlock() call

11 days agoengines/io_uring: allow setting of IOSQE_ASYNC
Jens Axboe [Tue, 8 Sep 2020 15:57:03 +0000 (09:57 -0600)]
engines/io_uring: allow setting of IOSQE_ASYNC

Add engine option 'force_async'. If that is set to N, then every N
requests will have IOSQE_ASYNC set to force async offload.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
12 days agozbd: Add a missing pthread_mutex_unlock() call
Bart Van Assche [Sat, 30 May 2020 22:34:00 +0000 (15:34 -0700)]
zbd: Add a missing pthread_mutex_unlock() call

This patch fixes the following Coverity complaint:

CID 292491 (#1 of 1): Missing unlock (LOCK)
missing_unlock: Returning without unlocking zb->mutex.

Fixes: bfbdd35b3e8f ("Add support for zoned block devices")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
12 days agoKill off old GUASI IO engine
Jens Axboe [Mon, 7 Sep 2020 19:38:03 +0000 (13:38 -0600)]
Kill off old GUASI IO engine

This library never saw widespread use, and it hasn't been updated in
more than a decade. On top of that, the fio engine was broken for a
long time and nobody noticed.

Time to take it out behind the barn.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
12 days agofio: cap io_size=N% at 100%, update man page
Alexey Dobriyan [Mon, 7 Sep 2020 17:59:23 +0000 (20:59 +0300)]
fio: cap io_size=N% at 100%, update man page

Passing io_size > 100% results in semi-infinite loop, anyway.

Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
13 days agoMerge branch 'guasi_fixes' of https://github.com/sitsofe/fio into master
Jens Axboe [Sun, 6 Sep 2020 22:14:58 +0000 (16:14 -0600)]
Merge branch 'guasi_fixes' of https://github.com/sitsofe/fio into master

* 'guasi_fixes' of https://github.com/sitsofe/fio:
  Makefile/configure: fix guasi build

13 days agoMakefile/configure: fix guasi build
Sitsofe Wheeler [Sun, 26 Jul 2020 16:22:09 +0000 (17:22 +0100)]
Makefile/configure: fix guasi build

13 days agoFio 3.23 fio-3.23
Jens Axboe [Sun, 6 Sep 2020 16:45:11 +0000 (10:45 -0600)]
Fio 3.23

Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agofio: support io_size=N% (N <= 100)
Alexey Dobriyan [Thu, 3 Sep 2020 16:54:02 +0000 (19:54 +0300)]
fio: support io_size=N% (N <= 100)

Parse "io_size=N%".

Semantics is "multiply whatever size= calculations result in".

Example #1:

size=50%
io_size=50%

will do 25% of a file.

Example #2:

size=1G
io_size=50%

will do 512M I/O.

As side effect, fix a bug with essentially infinite loop if both size=N%
and io_size=M% are given: io_size is set to 2^64-... in this case (a lot!).

Note: only values under 100% work currently.
Going for io_size=150% requires resetting workload generator state
which is whole separate endeavour.

Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agoengines/io_uring: use the atomic load acquire instead of a barrier
Jens Axboe [Thu, 3 Sep 2020 14:49:51 +0000 (08:49 -0600)]
engines/io_uring: use the atomic load acquire instead of a barrier

Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agot/io_uring: allow setting fixed files/buffers as arguments
Jens Axboe [Thu, 3 Sep 2020 14:49:19 +0000 (08:49 -0600)]
t/io_uring: allow setting fixed files/buffers as arguments

Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agoengines/io_uring: move sqe clear out of hot path
Jens Axboe [Thu, 3 Sep 2020 14:23:21 +0000 (08:23 -0600)]
engines/io_uring: move sqe clear out of hot path

We just need to ensure we set the stuff we need, then we can avoid a
full memset of the sqe in the hot path.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agot/zbd: Remove unnecessary option for zbc_reset_zone
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:06 +0000 (17:20 +0900)]
t/zbd: Remove unnecessary option for zbc_reset_zone

When -all option is specified, zbc_reset_zone command does not take
offset option. Remove it.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agot/zbd: Reset all zones before test when max open zones is specified
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:05 +0000 (17:20 +0900)]
t/zbd: Reset all zones before test when max open zones is specified

When the test target device has maximum open zones limit, the zones in
test target region may not be opened up to the limit, because the zones
out of the test target region may have open zones. To ensure that the
test target zones can be opened up to the limit, reset all zones of the
test target device before the test cases with write work load starts.
Introduce the helper function prep_write() to check if all zone reset is
required and do the reset.

Also remove unnecessary reset_zone calls for test case #29 and #48. These
are no longer required by virtue of the improvement in zbd_setup_files()
to set up zones to meet max_open_zones limit.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agot/zbd: Add -o option to t/zbd/test-zoned-support
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:04 +0000 (17:20 +0900)]
t/zbd: Add -o option to t/zbd/test-zoned-support

To specify maximum open zones of the test target device, add -o option
to t/zbd/test-zoned-support. When this option is specified, add
max_open_zones option to all fio commands in the test script. The option
ensures the number of zones opened by fio is within the limit. This is
useful when the test target device has maximum open zones limit.

When the fio command does not have multiple jobs and the test case does
not specify max_open_zones, add single max_open_zones option to the fio
command line.

When the fio command takes multiple jobs, add max_open_zones option to
each job. Introduce job_var_opts variable to keep options to be added to
each job. To distinguish it from global options for all jobs, rename
var_opts variable to global_var_opts. When a test case with multiple jobs
always specifies max_open_zones option, exclude the max_open_zones option
from job_var_opts, using job_var_opts_exclude() helper function.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agot/zbd: Improve usage message of test-zbd-support script
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:03 +0000 (17:20 +0900)]
t/zbd: Improve usage message of test-zbd-support script

The usage message of t/zbd/test-zbd-support does not explain meaning of
each option. Elaborate meaning of the options.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agozbd: Initialize open zones list referring zone status at fio start
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:02 +0000 (17:20 +0900)]
zbd: Initialize open zones list referring zone status at fio start

When fio starts write workloads to zones with open status, fio does not
reflect the zone status to open zone list. This results in inconsistent
open zone accounting.

To avoid this inconsistency, initialize the open zone list referring the
zone status before workload start. If a zone in target range have open
status, call zbd_open_zone() function to build up the open zone list.
Since io_u is not available at that timing, make the function independent
from io_u. If the number of open zones exceeds maximum open zones limits,
reset the exceeding open zone by calling zbd_reset_zone().

Of note is that fio counts open zones within the write target range.
Open zones out of the range are not counted or checked.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agooslib/linux-blkzoned: Allow reset zone before file set up
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:01 +0000 (17:20 +0900)]
oslib/linux-blkzoned: Allow reset zone before file set up

To reset zones before file set up completion, modify the helper function
blkzoned_reset_wp() to work even when fio_file struct does not have valid
file descriptor yet. If the file descriptor is not available, open and
close the reset target file within the function. Otherwise use the
available descriptor to avoid file open/close overhead.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agozbd: Decrement open zones count at write command completion
Shin'ichiro Kawasaki [Tue, 1 Sep 2020 08:20:00 +0000 (17:20 +0900)]
zbd: Decrement open zones count at write command completion

When max_open_zones or job_max_open_zones option is provided, fio counts
number of open zones. This open zone accounting is done during submission
of write commands. When write command is submitted to a zone for the
first time, the zone is counted as open. When a write command which will
fill the zone gets submitted, the zone is counted as closed. However,
this count at write command submission may open zones more than the
limit. When writes to zones more than the limit are submitted with high
queue depth, those writes in-flight open zones more than the limit.

To avoid such writes beyond max open zones limit, decrement number of
open zones count not at write command submission but at write command
completion. By doing this, the number of zones with in-flight write
commands are kept within the limit with accuracy. Introduce the helper
function zbd_end_zone_io() for this decrement and zbd_close_zone() call.

The zbd_close_zone() function requires thread_data argument. To refer
thread_data at write command completion, add the argument to zbd_put_io()
and zbd_queue_io() callbacks. Also add a loop to the zbd_close_zone()
function which converts zone_info array index to open_zones array index
to avoid loop code duplication.

Even when io_u points to an open zone, the zone may not be valid for
write since in-flight write commands may make the zone full. Check this
in zbd_open_zone() to handle such zones as in full status.

Because of the zone close timing change, there might be no open zone when
zbd_convert_to_open_zone() is called. Do not handle such case as an
error and open other zones.

When zbd_convert_to_open_zone() finds all open zones can not be used for
next write, it opens other zones. This zone open fails when the number of
open zones hits one of the limits: 1) number of zones in the fio write
target region, 2) max_open_zones option or 3) job_max_open_zones option.
To avoid the zone open failure, wait for writes in-flight completes and
open zones get closed before opening other zones.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agooptions: flow should parse as FIO_OPT_INT
Jens Axboe [Mon, 31 Aug 2020 15:07:12 +0000 (09:07 -0600)]
options: flow should parse as FIO_OPT_INT

It's an unsigned int, if we parse it as FIO_OPT_ULL then we clobber
the variable around it in the options struct. This is apparent when
running the examples/flow.fio job file, as flow_sleep=1000 is set
before flow, but gets clobbered when flow is set. This results in a
flow_sleep value of 0 instead of 1000.

Fixes: d4e74fda98b6 ("flow: add ability for weight-based flow control on multiple jobs")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2 weeks agoMerge branch 'multi_job_flow' of https://github.com/bardavid/fio into master
Jens Axboe [Mon, 31 Aug 2020 14:52:25 +0000 (08:52 -0600)]
Merge branch 'multi_job_flow' of https://github.com/bardavid/fio into master

* 'multi_job_flow' of https://github.com/bardavid/fio:
  flow: add ability for weight-based flow control on multiple jobs
  flow: reclaim flow when job is reaped

2 weeks agoflow: add ability for weight-based flow control on multiple jobs
David, Bar [Sun, 30 Aug 2020 14:29:24 +0000 (17:29 +0300)]
flow: add ability for weight-based flow control on multiple jobs

Fixes: #741 - fio how to run mix workload all 4 patterns in one job file

Previously, 'flow' was used to regulate activity between 2 or more jobs with
certain weight.  However, the implementation was ineffective when regulating
more than 2 jobs with different weights, since it relied on a single,
shared counter, and was missing logic to track individual job's activity
and regulate it according to it's requested weight in proportion to other jobs'
requested weight and activity.

This commit modifies the 'flow' functionality to track each job's
activity and the total activity belonging to a 'flow_id' group.
Using this new information, the 'flow' logic is then modified to
regulate a job's activity in proportion to other jobs in the
same group.  Similar to previous behavior, the regulation is done by
stalling a job's activity.

New jobs joining an existing 'flow_id' group or jobs repead from said
group will cause re-calibration of the weights and alter the activity as a
result.  For example, 3 jobs (j1,j2,j3) with weights (1:2:3)
respectively will maintain activity ratio of 1:2:3.  Thus, j1 will have
activity of 1/6, j2 - 2/6 and j3 - 1/2.

If j3 exits prematurely, the proportion is re-calibrated
such that j1 will strive to have activity of 1/3 and j2 - 2/3.

Re-calibration phase may cause a hiccup in the activity of one or more
jobs since the new desired proportion might not be achieved quickly
enough.

Signed-off-by: David, Bar <bardavvid@gmail.com>
2 weeks agoflow: reclaim flow when job is reaped
David, Bar [Thu, 13 Aug 2020 09:40:55 +0000 (12:40 +0300)]
flow: reclaim flow when job is reaped

Signed-off-by: David, Bar <bardavvid@gmail.com>
3 weeks agoUpdate the year to 2020 in os/windows/eula.rtf
Rebecca Cran [Sat, 29 Aug 2020 23:31:23 +0000 (23:31 +0000)]
Update the year to 2020 in os/windows/eula.rtf

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
3 weeks agoUpdate os/windows/dobuild.cmd to support signing binaries/installer
Rebecca Cran [Sat, 29 Aug 2020 23:25:50 +0000 (23:25 +0000)]
Update os/windows/dobuild.cmd to support signing binaries/installer

Since organizations are increasingly requiring software to be digitally
signed, or have heuristics that penalize unsigned software, add support
to do build.cmd to sign both the .exe binaries and the .msi installer.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
3 weeks agoUse fallthrough attribute
Jens Axboe [Fri, 28 Aug 2020 15:14:38 +0000 (09:14 -0600)]
Use fallthrough attribute

Fio currently triggers a bunch of fall through errors on clang 10,
since it doesn't work with the /* fall through */ method of
indicating fallthrough.

Normalize this a bit and use the correct compiler attribute for this.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
3 weeks agoMerge branch 'master' of https://github.com/donny372/fio into master
Jens Axboe [Fri, 28 Aug 2020 14:04:15 +0000 (08:04 -0600)]
Merge branch 'master' of https://github.com/donny372/fio into master

* 'master' of https://github.com/donny372/fio:
  Avoid multiple instance read iolog from stdin.

3 weeks agozbd: don't read past the WP on a read only workload with verify
Aravind Ramesh [Thu, 13 Aug 2020 15:01:48 +0000 (17:01 +0200)]
zbd: don't read past the WP on a read only workload with verify

When running a read only workload with verify option enabled,
fio continues to read beyond the write pointer, and thus
reads a deallocated block, which contains data of a predefined
pattern, thus causing the verify to fail.

Thus, we cannot simply jump to accept for a read only workload
with verify option enabled, we must let the regular flow of
execution to continue, so that the check if offset > wp is
performed, so that we will return the address to a new zone,
rather than an address that is past the wp.

Reading past the wp is not a recent bug, it is possible to
reproduce this bug even before zone capacity was introduced.

However, with the introduction of zone capacity, filling a
zone now only writes up to zone capacity of a zone, making
it much easier to reproduce this bug.

Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Signed-off-by: Aravind Ramesh <aravind.ramesh@wdc.com>
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agot/io_uring: cleanup vectored vs non-vectored
Jens Axboe [Sat, 22 Aug 2020 17:26:39 +0000 (11:26 -0600)]
t/io_uring: cleanup vectored vs non-vectored

No functional changes, just makes it a bit more logical.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agot/io_uring: use non-vectored reads if available
Jens Axboe [Sat, 22 Aug 2020 16:58:14 +0000 (10:58 -0600)]
t/io_uring: use non-vectored reads if available

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoengines/io_uring: use non-vectored read/write if available
Jens Axboe [Sat, 22 Aug 2020 16:48:15 +0000 (10:48 -0600)]
engines/io_uring: use non-vectored read/write if available

There's the nonvectored option to set this, by default to it if it
wasn't set explicitly *and* we have it available. We issue a probe
to detect this.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoAvoid multiple instance read iolog from stdin.
donny372 [Tue, 18 Aug 2020 17:36:05 +0000 (10:36 -0700)]
Avoid multiple instance read iolog from stdin.

https://github.com/axboe/fio/pull/1019 added support for reading iolog from stdin, but we could have multiple instance of read iolog, only one can read from stdin.

4 weeks agoengines/io_uring: don't attempt to set RLIMITs
Jens Axboe [Fri, 21 Aug 2020 22:22:43 +0000 (16:22 -0600)]
engines/io_uring: don't attempt to set RLIMITs

This was meant to be helpful, but it's actively harmful if we're not
running as root. Just get rid of it, it's really no different than
needing appropriate memlock limits for just the ring itself.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoMerge branch 'adjusting-libpmem' of https://github.com/lukaszstolarczuk/fio into...
Jens Axboe [Fri, 21 Aug 2020 14:52:21 +0000 (08:52 -0600)]
Merge branch 'adjusting-libpmem' of https://github.com/lukaszstolarczuk/fio into master

* 'adjusting-libpmem' of https://github.com/lukaszstolarczuk/fio:
  engines/libpmem: adjust for PMDK >=1.5 usage

4 weeks agoengines/libpmem: adjust for PMDK >=1.5 usage
Łukasz Stolarczuk [Fri, 17 Jul 2020 13:14:55 +0000 (15:14 +0200)]
engines/libpmem: adjust for PMDK >=1.5 usage

- libpmem engine adjusted to take full advantage of new PMDK versions,
- code redundancy cleaned (some code was copy-pasted from PMDK),
- libpmem example adjusted.

Behavior of direct and sync parameters changed:
- sync=1 means that pmem_drain() is executed for each write operation,
- depends on direct option, flags are set for pmem_memcpy() call:
  - direct=1 - PMEM_F_MEM_NONTEMPORAL,
  - direct=0 - PMEM_F_MEM_TEMPORAL.

4 weeks agofile: provider fio_file_free() helper
Jens Axboe [Wed, 19 Aug 2020 19:02:42 +0000 (13:02 -0600)]
file: provider fio_file_free() helper

Since we have two spots, provide a helper to do the freeing.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoinit: add_job() needs to use right file freeing functions
Jens Axboe [Wed, 19 Aug 2020 18:10:26 +0000 (12:10 -0600)]
init: add_job() needs to use right file freeing functions

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agofile: track allocation origin
Jens Axboe [Wed, 19 Aug 2020 18:04:38 +0000 (12:04 -0600)]
file: track allocation origin

We can't always rely on the engine options for the file, as files
can come from various places. So mark the file as having come from
smalloc/calloc and use that when freeing it.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoMerge branch 'force-windows-artifact' of https://github.com/sitsofe/fio into master
Jens Axboe [Wed, 19 Aug 2020 17:23:42 +0000 (11:23 -0600)]
Merge branch 'force-windows-artifact' of https://github.com/sitsofe/fio into master

* 'force-windows-artifact' of https://github.com/sitsofe/fio:
  ci: always upload Windows MSI if smoke test passes

4 weeks agoci: always upload Windows MSI if smoke test passes
Sitsofe Wheeler [Wed, 19 Aug 2020 15:54:15 +0000 (16:54 +0100)]
ci: always upload Windows MSI if smoke test passes

When the test_script stage fails the artifacts stage isn't run. This is
problematic because the long running tests (on all platforms) can be
flaky and Windows folk are accustomed to not having to do builds
themselves when testing the tip of a project. This could lead to a
situation where no there's no pre-built Windows binaries due to a
spurious failures...

Solve the above by moving the smoke test and artifact upload to be
earlier, remove a useless use of bash during smoke Appveyor smoke
testing and change the "Deployment name" from msi to fio.msi.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
4 weeks agoengines/windowsaio: fix silly thinky on IO thread creation
Jens Axboe [Wed, 19 Aug 2020 13:12:11 +0000 (07:12 -0600)]
engines/windowsaio: fix silly thinky on IO thread creation

I inadvertently made the setup fail unless the affinity option was
set, the intent was obviously to only run the affinitization if we
asked for it.

Fixes: 09c1aa8b3227 ("engines/windowsaio: only set IOCP thread affinity if specified")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoconfigure: fix syntax error with NetBSD
Dmitry Fomichev [Mon, 17 Aug 2020 23:47:08 +0000 (08:47 +0900)]
configure: fix syntax error with NetBSD

The recent patch to detect for pkg-config presence has introduced some
bash-specific code to configure script. This lead to syntax errors
while running configure under some other shells, such as (d)ash.

Avoid ${!var} indirect substitution syntax and stop using "local"
keyword which is non-POSIX-standard. Address a few minor shellcheck
complaints about the code in same function.

Fixes: 162f8c2a96ae ("configure: check if pkg-config is installed")
Reviewed-by: Sitsofe Wheeler <sitsofe@yahoo.com>
Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoMerge branch 'filelock_assert_fix' of https://github.com/bardavid/fio into master
Jens Axboe [Tue, 18 Aug 2020 15:33:49 +0000 (08:33 -0700)]
Merge branch 'filelock_assert_fix' of https://github.com/bardavid/fio into master

* 'filelock_assert_fix' of https://github.com/bardavid/fio:
  filelock: fix wrong file trylock assertion.

4 weeks agoMerge branch 'asprintf1' of https://github.com/kusumi/fio into master
Jens Axboe [Tue, 18 Aug 2020 14:45:06 +0000 (07:45 -0700)]
Merge branch 'asprintf1' of https://github.com/kusumi/fio into master

* 'asprintf1' of https://github.com/kusumi/fio:
  oslib: fix asprintf build failure

4 weeks agooslib: fix asprintf build failure
Tomohiro Kusumi [Tue, 18 Aug 2020 13:34:07 +0000 (22:34 +0900)]
oslib: fix asprintf build failure

oslib/asprintf.h needs to include <stdarg.h> for va_list.
This started to appear on NetBSD since
38b00241e3("num2str(): Use asprintf() instead of malloc()").

--
In file included from lib/num2str.c:7:0:
lib/../oslib/asprintf.h:5:45: error: unknown type name 'va_list'; did you mean '__va_list'?
 int vasprintf(char **strp, const char *fmt, va_list ap);
                                             ^~~~~~~
                                             __va_list
    CC lib/pattern.o
gmake: *** [Makefile:447: lib/num2str.o] Error 1

Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
4 weeks agoengines/windowsaio: only set IOCP thread affinity if specified
Jens Axboe [Mon, 17 Aug 2020 22:42:16 +0000 (15:42 -0700)]
engines/windowsaio: only set IOCP thread affinity if specified

We set it by default, which seems like a bad idea. If the issuing
thread is running on some other CPU, we don't want to bind this
to what is probably CPU0.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agofio: add for_each_rw_ddir() macro
Alexey Dobriyan [Thu, 13 Aug 2020 16:33:07 +0000 (19:33 +0300)]
fio: add for_each_rw_ddir() macro

Make it slightly easier to add Zone Append as fully fledged I/O type.

Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
4 weeks agoFio 3.22 fio-3.22
Jens Axboe [Mon, 17 Aug 2020 03:59:34 +0000 (20:59 -0700)]
Fio 3.22

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoMerge branch 'issue-1065' of https://github.com/XeS0r/fio into master
Jens Axboe [Fri, 14 Aug 2020 23:02:37 +0000 (16:02 -0700)]
Merge branch 'issue-1065' of https://github.com/XeS0r/fio into master

* 'issue-1065' of https://github.com/XeS0r/fio:
  thread_options: Use unsigned int type for exit_what and stonewall

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agothread_options: Use unsigned int type for exit_what and stonewall
André Wild [Fri, 14 Aug 2020 13:52:09 +0000 (15:52 +0200)]
thread_options: Use unsigned int type for exit_what and stonewall

Fixes: 64402a8 ("Expand choices for exitall")
Fixes: https://github.com/axboe/fio/issues/1065
Signed-off-by: André Wild <wild.andre.ae@gmail.com>
5 weeks agoFixup examples/exitwhat.fio
Jens Axboe [Fri, 14 Aug 2020 20:16:18 +0000 (13:16 -0700)]
Fixup examples/exitwhat.fio

Use proper read/write names.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agozbd: use ->min_zone, ->max_zone in more places
Alexey Dobriyan [Thu, 13 Aug 2020 16:36:32 +0000 (19:36 +0300)]
zbd: use ->min_zone, ->max_zone in more places

Check that ->min_zone is less than ->max_zone.
This assert found one bug here.

Use it in more places, now that it was added.

Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoio_u: calculate incremental residuals correctly
Jens Axboe [Wed, 12 Aug 2020 17:48:15 +0000 (11:48 -0600)]
io_u: calculate incremental residuals correctly

We need to use the transfer buffer length for the residual calculation,
otherwise multiple shorts on the same IO will not calculate the right
value.

Fixes: 5fff95436922 ("Add support for >= 4G block sizes")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agot/zbd: check log file for failed assertions
Dmitry Fomichev [Tue, 4 Aug 2020 01:38:28 +0000 (10:38 +0900)]
t/zbd: check log file for failed assertions

Currently, a ZBD test can succeed even if an fio assertion is raised
during its run. Search every ZBD test log file for failed assertions
and fail the test if any were found.

Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agozbd: simplify zone reset code
Dmitry Fomichev [Tue, 4 Aug 2020 01:38:27 +0000 (10:38 +0900)]
zbd: simplify zone reset code

zbd_reset_range() function is only called once from zbd_reset_zone()
and it is always called for an individual zone, not a range.

Make zone reset flow simpler by moving all the code needed
to reset a single zone from zbd_reset_range() to zbd_reset_zone().
Therefore, zbd_reset_range() is now dropped.

zbc_reset_zone() is always called with the zone already locked. Remove
recursive zone locking inside this function and add a note in the
description of this function saying that the caller is expected to have
the zone locked when calling it.

Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoconfigure: check if pkg-config is installed
Dmitry Fomichev [Tue, 4 Aug 2020 01:38:26 +0000 (10:38 +0900)]
configure: check if pkg-config is installed

A few libraries need to be newer than a specific version in order to be
supported by fio and pkg-config utility is used to verify the versions
of the installed libraries. Since this step may fail because pkg-config
is not installed, verify pkg-config presence and warn the user if it
could not be found.

To avoid code duplication, add a common helper function to perform
these checks.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoconfigure: improve libzbc version check
Dmitry Fomichev [Tue, 4 Aug 2020 01:38:25 +0000 (10:38 +0900)]
configure: improve libzbc version check

Avoid parsing pkg-config output and just use --atleast-version to
check if libzbc is present and has an up to date version.

Currently, support for libzbc ioengine is always included if libzbc is
found at the build system. Add the option to disable libzbc ioengine
support even if libzbc is found. This can be useful for
cross-compilation.

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoio_u: set io_u->verify_offset in fill_io_u()
Jens Axboe [Tue, 11 Aug 2020 03:40:59 +0000 (21:40 -0600)]
io_u: set io_u->verify_offset in fill_io_u()

This is arguably saner than the previous fix, since it also catches
cases where io_u->offset is adjusted later on.

Hopefully that's it...

Fixes: 4fff54ccba73 ("verify: use origina offset for verification")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoio_u: get_next_offset() should always set io_u->verify_offset
Jens Axboe [Tue, 11 Aug 2020 03:31:01 +0000 (21:31 -0600)]
io_u: get_next_offset() should always set io_u->verify_offset

Don't assume that the original get_next_block() is the only place
that sets it. Set it unconditionally at the success exit path
of get_next_offset().

Fixes: 4fff54ccba73 ("verify: use origina offset for verification")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoverify: use origina offset for verification
Jens Axboe [Tue, 11 Aug 2020 02:55:27 +0000 (20:55 -0600)]
verify: use origina offset for verification

Requeued IO might have a different offset, since we increment it for
retry conditions. Store the original offset for verification purposes.

Just like we have io_u->xfer_buf/io_u->buf and
io_u->xfer_buflen/io_u->buflen, we really should be treating
io_u->offset the same. But that's a major change, so just add this
special original offset so we know that verify has it. Currently we
treat io_u->offset like we would have io_u->xfer_offset, so this just
makes io_u->verify_offset what io_u->offset should be.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoio_uring: notice short IO on completion path
Jens Axboe [Tue, 11 Aug 2020 02:54:46 +0000 (20:54 -0600)]
io_uring: notice short IO on completion path

Async IO engines need to signal residual from the completion path,
but we completely ignore those. Ensure we properly requeue IO that
was short, after adjusting the state.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoio_u: reset ->resid on starting a requeue IO
Jens Axboe [Tue, 11 Aug 2020 02:53:55 +0000 (20:53 -0600)]
io_u: reset ->resid on starting a requeue IO

We only clear this state for a new IO, we should also do it for starting
a requeued IO.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
5 weeks agoengines/io_uring: make sure state is updated for requeues
Jens Axboe [Tue, 11 Aug 2020 02:52:09 +0000 (20:52 -0600)]
engines/io_uring: make sure state is updated for requeues

Currently we always use the start of the buffer and buffer length,
but this isn't valid for a requeue. Make sure we updated both
based on the actual io_u.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
6 weeks agoMerge branch 'master' of https://github.com/donny372/fio into master
Jens Axboe [Sat, 8 Aug 2020 00:21:52 +0000 (18:21 -0600)]
Merge branch 'master' of https://github.com/donny372/fio into master

* 'master' of https://github.com/donny372/fio:
  Add support for reading iolog from stdin.

6 weeks agoAdd support for reading iolog from stdin.
donny372 [Wed, 17 Jun 2020 19:58:22 +0000 (12:58 -0700)]
Add support for reading iolog from stdin.

Add support for reading iolog from stdin and update HOWTO and man page.

Fixes: https://github.com/axboe/fio/issues/997

Signed-off-by: Shundong Zhou <donny372@gmail.com>
6 weeks agofilelock: fix wrong file trylock assertion.
David, Bar [Thu, 6 Aug 2020 23:08:43 +0000 (02:08 +0300)]
filelock: fix wrong file trylock assertion.

Signed-off-by: David, Bar <bardavvid@gmail.com>
7 weeks agoMerge branch 'master' of https://github.com/bvanassche/fio into master
Jens Axboe [Sat, 1 Aug 2020 21:07:38 +0000 (15:07 -0600)]
Merge branch 'master' of https://github.com/bvanassche/fio into master

* 'master' of https://github.com/bvanassche/fio:
  Prevent that fio hangs when using io_submit_mode=offload

7 weeks agoPrevent that fio hangs when using io_submit_mode=offload
Bart Van Assche [Sat, 1 Aug 2020 18:01:06 +0000 (11:01 -0700)]
Prevent that fio hangs when using io_submit_mode=offload

This patch has been tested by running the following shell command:

for ((i=0;i<1000;i++)); do echo $i; python3 t/run-fio-tests.py -o 10; done

Fixes: d28174f0189c ("workqueue: ensure we see deferred error for IOs")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
7 weeks agoiolog: ensure that dynamic log entries are at least queue depth sized
Jens Axboe [Mon, 27 Jul 2020 22:00:20 +0000 (16:00 -0600)]
iolog: ensure that dynamic log entries are at least queue depth sized

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 weeks agoAdd roundup_pow2() as a generic helper
Jens Axboe [Mon, 27 Jul 2020 22:00:03 +0000 (16:00 -0600)]
Add roundup_pow2() as a generic helper

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 weeks agot/jobs/t001[1-2].fio: run for 10 seconds instead of 3
Jens Axboe [Mon, 27 Jul 2020 04:18:53 +0000 (22:18 -0600)]
t/jobs/t001[1-2].fio: run for 10 seconds instead of 3

These jobs often fails in CI testing, and it might be because the
runtime is simply too short to make it reliable.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
7 weeks agoMerge branch 'fix_travis_libiscsi' of https://github.com/sitsofe/fio
Jens Axboe [Mon, 27 Jul 2020 00:13:43 +0000 (18:13 -0600)]
Merge branch 'fix_travis_libiscsi' of https://github.com/sitsofe/fio

* 'fix_travis_libiscsi' of https://github.com/sitsofe/fio:
  travis: fix x86 libiscsi detection
  travis: remove unneeded dependency

7 weeks agotravis: fix x86 libiscsi detection
Sitsofe Wheeler [Sun, 26 Jul 2020 19:48:59 +0000 (20:48 +0100)]
travis: fix x86 libiscsi detection

When cross compiling to 32 bit systems, pkg-config has to find 32 bit
libraries. This can be done by one of the following
- Setting PKG_CONFIG_PATH/PKG_CONFIG_LIBDIR to an appropriate directory
- Using a 32 bit pkg-config binary

Choose the later for now by installing a 32 bit pkg-config (which will
replace the 64 bit one). This should fix failing CI on the 32 bit x86
build.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 weeks agotravis: remove unneeded dependency
Sitsofe Wheeler [Sun, 26 Jul 2020 19:10:28 +0000 (20:10 +0100)]
travis: remove unneeded dependency

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 weeks agoMerge branch 'enable_or_exit' of https://github.com/sitsofe/fio
Jens Axboe [Sun, 26 Jul 2020 13:50:46 +0000 (07:50 -0600)]
Merge branch 'enable_or_exit' of https://github.com/sitsofe/fio

* 'enable_or_exit' of https://github.com/sitsofe/fio:
  configure: fail when explicit enabling doesn't succeed

7 weeks agoconfigure: fail when explicit enabling doesn't succeed
Sitsofe Wheeler [Sat, 25 Jul 2020 22:10:27 +0000 (23:10 +0100)]
configure: fail when explicit enabling doesn't succeed

- Bail out if the probe fails when the user is explicitly enabling the
  cuda, libiscsi or libnbd ioengines or the libaio io_uring option
- Normalize some of the code that deals with enabling/disabling the
  above options

Fixes: https://github.com/axboe/fio/issues/1052

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 weeks agoMerge branch 'travis_cleanup' of https://github.com/sitsofe/fio
Jens Axboe [Sun, 26 Jul 2020 13:43:46 +0000 (07:43 -0600)]
Merge branch 'travis_cleanup' of https://github.com/sitsofe/fio

* 'travis_cleanup' of https://github.com/sitsofe/fio:
  Makefile: fix incorrectly set libiscsi cflags
  memory: fix incorrect pointer comparison when freeing cuda memory
  travis: make CI install script bail out on first error
  travis: enable libiscsi and cuda ioengines
  travis: add dependency for cuda ioengine
  travis: use install section instead of before_install section
  configure: check for Debian/Ubuntu tcmalloc_minimal
  travis: improve installation dependencies
  travis: simplify yml file

7 weeks agoMakefile: fix incorrectly set libiscsi cflags
Sitsofe Wheeler [Sun, 26 Jul 2020 10:27:22 +0000 (11:27 +0100)]
Makefile: fix incorrectly set libiscsi cflags

This fixes the warning
error: -liscsi: 'linker' input unused [-Werror,-Wunused-command-line-argument]
produced by clang.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
7 weeks agomemory: fix incorrect pointer comparison when freeing cuda memory
Sitsofe Wheeler [Sun, 26 Jul 2020 06:14:15 +0000 (07:14 +0100)]
memory: fix incorrect pointer comparison when freeing cuda memory

This fixes the following warning spotted by gcc 7:
memory.c: In function ‘free_mem_cudamalloc’:
memory.c:277:22: error: comparison between pointer and integer [-Werror]
  if (td->dev_mem_ptr != NULL)
                      ^~

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>