Always set ->real_file_size to -1 when failed to get file size
authorTomohiro Kusumi <tkusumi@tuxera.com>
Tue, 14 Feb 2017 15:19:45 +0000 (17:19 +0200)
committerJens Axboe <axboe@fb.com>
Tue, 14 Feb 2017 15:24:24 +0000 (08:24 -0700)
In some cases it's set to -1, but on others it's not,
while the existing code (e.g. get_fs_free_counts(), setup_files(), etc)
seem to expect ->real_file_size to be -1 in case of any error.

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
filesetup.c

index eb28826698811058a317fa6544b92bd8f388a368..3fa8b32e3b8d4b4d7e6227f211365d3f3ffd8cd6 100644 (file)
@@ -375,10 +375,12 @@ static int get_file_size(struct thread_data *td, struct fio_file *f)
        else if (f->filetype == FIO_TYPE_CHAR)
                ret = char_size(td, f);
        else
-               f->real_file_size = -1;
+               f->real_file_size = -1ULL;
 
-       if (ret)
+       if (ret) {
+               f->real_file_size = -1ULL;
                return ret;
+       }
 
        if (f->file_offset > f->real_file_size) {
                log_err("%s: offset extends end (%llu > %llu)\n", td->o.name,