Switch last_was_sync and terminate to bool and pack better
authorJens Axboe <axboe@kernel.dk>
Thu, 25 Jan 2018 03:22:50 +0000 (20:22 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 25 Jan 2018 03:22:50 +0000 (20:22 -0700)
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fio.h
io_u.c
libfio.c

diff --git a/fio.h b/fio.h
index 334f203..85546c5 100644 (file)
--- a/fio.h
+++ b/fio.h
@@ -228,9 +228,9 @@ struct thread_data {
        pid_t pid;
        char *orig_buffer;
        size_t orig_buffer_size;
-       volatile int terminate;
        volatile int runstate;
-       unsigned int last_was_sync;
+       volatile bool terminate;
+       bool last_was_sync;
        enum fio_ddir last_ddir;
 
        int mmapfd;
diff --git a/io_u.c b/io_u.c
index 6083eaa..404c75b 100644 (file)
--- a/io_u.c
+++ b/io_u.c
@@ -1994,7 +1994,7 @@ static void io_completed(struct thread_data *td, struct io_u **io_u_ptr,
        }
 
        if (ddir_sync(ddir)) {
-               td->last_was_sync = 1;
+               td->last_was_sync = true;
                if (f) {
                        f->first_write = -1ULL;
                        f->last_write = -1ULL;
@@ -2004,7 +2004,7 @@ static void io_completed(struct thread_data *td, struct io_u **io_u_ptr,
                return;
        }
 
-       td->last_was_sync = 0;
+       td->last_was_sync = false;
        td->last_ddir = ddir;
 
        if (!io_u->error && ddir_rw(ddir)) {
index 74de735..80159b4 100644 (file)
--- a/libfio.c
+++ b/libfio.c
@@ -98,7 +98,7 @@ static void reset_io_counters(struct thread_data *td, int all)
 
        td->zone_bytes = 0;
 
-       td->last_was_sync = 0;
+       td->last_was_sync = false;
        td->rwmix_issues = 0;
 
        /*
@@ -230,7 +230,7 @@ void fio_mark_td_terminate(struct thread_data *td)
 {
        fio_gettime(&td->terminate_time, NULL);
        write_barrier();
-       td->terminate = 1;
+       td->terminate = true;
 }
 
 void fio_terminate_threads(unsigned int group_id)