io_u: fix negative offset due to wrap

If we do wrap, the math is off and we end up wrapping a 64-bit
value. Instead reset to the initial offset.

Reported-by: Bart Van Assche <Bart.VanAssche@wdc.com>
Fixes: 4c8be5b1569f ("Fix bug with zone and zone skipping and io_limit")
Fixes: 224b3093cc21 ("Fix zoning issue with seq-io and randommap issue")
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/io_u.c b/io_u.c
index 580c414622db161fe78061413ac5bef6de7e0efb..9e9dad5a79f15c6f405b26ad16736388149d257c 100644 (file)
--- a/io_u.c
+++ b/io_u.c
@@ -832,15 +832,16 @@ static void __fill_io_u_zone(struct thread_data *td, struct io_u *io_u)
                 * Wrap from the beginning, if we exceed the file size
                 */
                if (f->file_offset >= f->real_file_size)
-                       f->file_offset = f->real_file_size - f->file_offset;
+                       f->file_offset = get_start_offset(td, f);
+
                f->last_pos[io_u->ddir] = f->file_offset;
                td->io_skip_bytes += td->o.zone_skip;
        }
 
        /*
-        * If zone_size > zone_range, then maintain the same zone until
-        * zone_bytes >= zone_size.
-        */
+        * If zone_size > zone_range, then maintain the same zone until
+        * zone_bytes >= zone_size.
+        */
        if (f->last_pos[io_u->ddir] >= (f->file_offset + td->o.zone_range)) {
                dprint(FD_IO, "io_u maintain zone offset=%" PRIu64 "/last_pos=%" PRIu64 "\n",
                                f->file_offset, f->last_pos[io_u->ddir]);
@@ -851,9 +852,8 @@ static void __fill_io_u_zone(struct thread_data *td, struct io_u *io_u)
         * For random: if 'norandommap' is not set and zone_size > zone_range,
         * map needs to be reset as it's done with zone_range everytime.
         */
-       if ((td->zone_bytes % td->o.zone_range) == 0) {
+       if ((td->zone_bytes % td->o.zone_range) == 0)
                fio_file_reset(td, f);
-       }
 }
 
 static int fill_io_u(struct thread_data *td, struct io_u *io_u)
@@ -874,9 +874,8 @@ static int fill_io_u(struct thread_data *td, struct io_u *io_u)
        /*
         * When file is zoned zone_range is always positive
         */
-       if (td->o.zone_range) {
+       if (td->o.zone_range)
                __fill_io_u_zone(td, io_u);
-       }
 
        /*
         * No log, let the seq/rand engine retrieve the next buflen and