Makefile: add -Wshadow

[fio.git] / parse.c

diff --git a/parse.c b/parse.c
index c2d1cc811f6740a58bf0692a5c9f740e1d085aae..42096471f021b804cbb8eccb9a781d25cada4334 100644 (file)
--- a/parse.c
+++ b/parse.c
@@ -269,12 +269,60 @@ static unsigned long long get_mult_bytes(const char *str, int len, void *data,
 }
 
 extern int evaluate_arithmetic_expression(const char *buffer, long long *ival,
-                                         double *dval);
+                                         double *dval, double implied_units,
+                                         int is_time);
+
+#ifdef CONFIG_ARITHMETIC
+/*
+ * These two verification functions are just to gain confidence that
+ * the arithmetic processing code is always getting the same answer as the
+ * original number parsing code.  Once sufficiently sure that the arithmetic
+ * code is always getting the right answers, these can be removed.
+ */
+static void verify_exp_parser_float(const char *str, double implied_units, int is_time)
+{
+       long long ival;
+       double dval, tmpval;
+
+       if (sscanf(str, "%lf", &tmpval) != 1)
+               return;
+
+       if (evaluate_arithmetic_expression(str, &ival, &dval, implied_units, is_time) != 0) {
+               log_info("Arithmetic failed on '%s'\n", str);
+               return;
+       }
+       if (dval != tmpval) {
+               log_info("Arithmetic failed on: '%s' got %lf, expected %lf\n",
+                               str, dval, tmpval);
+       }
+}
+
+static void verify_exp_parser_decimal(const char *str, long long val, int kilo, int is_seconds,
+                                     int is_time)
+{
+       int rc;
+       long long ival;
+       double dval;
+       double implied_units = 1.0;
+
+       if (is_seconds)
+               implied_units = 1000000.0;
+
+       rc = evaluate_arithmetic_expression(str, &ival, &dval, implied_units, is_time);
+       if (!rc) {
+               if (ival != val)
+                       log_info("Arithmetic failed on '%s', expected %lld, got %lld\n",
+                               str, val, ival);
+       } else {
+               log_info("Arithmetic failed on '%s'\n", str);
+       }
+}
+#endif
 
 /*
  * Convert string into a floating number. Return 1 for success and 0 otherwise.
  */
-int str_to_float(const char *str, double *val)
+int str_to_float(const char *str, double *val, int is_time)
 {
 #ifdef CONFIG_ARITHMETIC
        int rc;
@@ -282,11 +330,13 @@ int str_to_float(const char *str, double *val)
        double dval;
 
        if (str[0] == '(') {
-               rc = evaluate_arithmetic_expression(str, &ival, &dval);
+               rc = evaluate_arithmetic_expression(str, &ival, &dval, 1.0, is_time);
                if (!rc) {
                        *val = dval;
                        return 1;
                }
+       } else {
+               verify_exp_parser_float(str, 1.0, is_time);
        }
 #endif
        return 1 == sscanf(str, "%lf", val);
@@ -296,13 +346,14 @@ int str_to_float(const char *str, double *val)
  * convert string into decimal value, noting any size suffix
  */
 int str_to_decimal(const char *str, long long *val, int kilo, void *data,
-                  int is_seconds)
+                  int is_seconds, int is_time)
 {
        int len, base;
        int rc = 1;
 #ifdef CONFIG_ARITHMETIC
        long long ival;
        double dval;
+       double implied_units = 1.0;
 #endif
 
        len = strlen(str);
@@ -310,10 +361,16 @@ int str_to_decimal(const char *str, long long *val, int kilo, void *data,
                return 1;
 
 #ifdef CONFIG_ARITHMETIC
+       if (is_seconds)
+               implied_units = 1000000.0;
        if (str[0] == '(')
-               rc = evaluate_arithmetic_expression(str, &ival, &dval);
-       if (str[0] == '(' && !rc)
-               *val = ival;
+               rc = evaluate_arithmetic_expression(str, &ival, &dval, implied_units, is_time);
+       if (str[0] == '(' && !rc) {
+               if (!kilo && is_seconds)
+                       *val = ival / 1000000LL;
+               else
+                       *val = ival;
+       }
 #endif
 
        if (rc == 1) {
@@ -338,18 +395,20 @@ int str_to_decimal(const char *str, long long *val, int kilo, void *data,
                        *val *= mult;
        } else
                *val *= get_mult_time(str, len, is_seconds);
-
+#ifdef CONFIG_ARITHMETIC
+       verify_exp_parser_decimal(str, *val, kilo, is_seconds, is_time);
+#endif
        return 0;
 }
 
 int check_str_bytes(const char *p, long long *val, void *data)
 {
-       return str_to_decimal(p, val, 1, data, 0);
+       return str_to_decimal(p, val, 1, data, 0, 0);
 }
 
 int check_str_time(const char *p, long long *val, int is_seconds)
 {
-       return str_to_decimal(p, val, 0, NULL, is_seconds);
+       return str_to_decimal(p, val, 0, NULL, is_seconds, 1);
 }
 
 void strip_blank_front(char **p)
@@ -391,7 +450,7 @@ static int check_range_bytes(const char *str, long *val, void *data)
 {
        long long __val;
 
-       if (!str_to_decimal(str, &__val, 1, data, 0)) {
+       if (!str_to_decimal(str, &__val, 1, data, 0, 0)) {
                *val = __val;
                return 0;
        }
@@ -495,6 +554,9 @@ static int __handle_option(struct fio_option *o, const char *ptr, void *data,
                fio_opt_str_val_fn *fn = o->cb;
                char tmp[128], *p;
 
+               if (!is_time && o->is_time)
+                       is_time = o->is_time;
+
                strncpy(tmp, ptr, sizeof(tmp) - 1);
                p = strchr(tmp, ',');
                if (p)
@@ -598,7 +660,7 @@ static int __handle_option(struct fio_option *o, const char *ptr, void *data,
                                        o->maxlen);
                        return 1;
                }
-               if (!str_to_float(ptr, &uf)) {
+               if (!str_to_float(ptr, &uf, 0)) { /* this breaks if we ever have lists of times */
                        log_err("not a floating point value: %s\n", ptr);
                        return 1;
                }
@@ -1024,11 +1086,13 @@ static int string_distance(const char *s1, const char *s2)
                q[0] = p[0] + 1;
                for (j = 1; j <= s2_len; j++) {
                        unsigned int sub = p[j - 1];
+                       unsigned int pmin;
 
                        if (s1[i - 1] != s2[j - 1])
                                sub++;
 
-                       q[j] = min(p[j] + 1, min(q[j - 1] + 1, sub));
+                       pmin = min(q[j - 1] + 1, sub);
+                       q[j] = min(p[j] + 1, pmin);
                }
                r = p;
                p = q;