[PATCH] Check and error for graph generation if gnuplot isn't available
[fio.git] / init.c
diff --git a/init.c b/init.c
index 6bf338532d6b528714274f7b243932b5459276cb..bbc9aadff408e4049a3f7ef7cc592b725d1b3de5 100644 (file)
--- a/init.c
+++ b/init.c
 #define DEF_RWMIX_READ         (50)
 #define DEF_NICE               (0)
 
+static int def_timeout = DEF_TIMEOUT;
+
 static char fio_version_string[] = "fio 1.4";
 
-static int repeatable = DEF_RAND_REPEAT;
-static char *ini_file;
+static char **ini_file;
 static int max_jobs = MAX_JOBS;
 
 struct thread_data def_thread;
@@ -72,7 +73,6 @@ static struct thread_data *get_new_job(int global, struct thread_data *parent)
 
        td->fd = -1;
        td->thread_number = thread_number;
-
        return td;
 }
 
@@ -133,9 +133,9 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num)
                char tmp[PATH_MAX];
 
                if (td->directory && td->directory[0] != '\0')
-                       sprintf(tmp, "%s/%s.%d", td->directory, jobname, td->jobnum);
+                       sprintf(tmp, "%s/%s.%d", td->directory, jobname, td->thread_number);
                else
-                       sprintf(tmp, "%s.%d", jobname, td->jobnum);
+                       sprintf(tmp, "%s.%d", jobname, td->thread_number);
                td->file_name = strdup(tmp);
        } else
                td->file_name = strdup(jobname);
@@ -191,7 +191,6 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num)
 
                td_new->numjobs = 1;
                td_new->stonewall = 0;
-               td_new->jobnum = numjobs;
                job_add_num = numjobs - 1;
 
                if (add_job(td_new, jobname, job_add_num))
@@ -229,7 +228,7 @@ int init_random_state(struct thread_data *td)
        if (td->sequential)
                return 0;
 
-       if (repeatable)
+       if (td->rand_repeatable)
                seeds[3] = DEF_RANDSEED;
 
        blocks = (td->io_size + td->min_bs - 1) / td->min_bs;
@@ -579,7 +578,7 @@ int parse_jobs_ini(char *file)
        fpos_t off;
        FILE *f;
        char *p;
-       int ret = 0;
+       int ret = 0, stonewall = 1;
 
        f = fopen(file, "r");
        if (!f) {
@@ -609,6 +608,14 @@ int parse_jobs_ini(char *file)
                        break;
                }
 
+               /*
+                * Seperate multiple job files by a stonewall
+                */
+               if (!global && stonewall) {
+                       td->stonewall = stonewall;
+                       stonewall = 0;
+               }
+
                fgetpos(f, &off);
                while ((p = fgets(string, 4096, f)) != NULL) {
                        if (is_empty_or_comment(p))
@@ -644,6 +651,11 @@ int parse_jobs_ini(char *file)
                                fgetpos(f, &off);
                                continue;
                        }
+                       if (!check_int(p, "rand_repeatable", &il)) {
+                               td->rand_repeatable = il;
+                               fgetpos(f, &off);
+                               continue;
+                       }
                        if (!check_int(p, "rate", &td->rate)) {
                                fgetpos(f, &off);
                                continue;
@@ -921,7 +933,7 @@ static int fill_def_thread(void)
        def_thread.odirect = DEF_ODIRECT;
        def_thread.ratecycle = DEF_RATE_CYCLE;
        def_thread.sequential = DEF_SEQUENTIAL;
-       def_thread.timeout = DEF_TIMEOUT;
+       def_thread.timeout = def_timeout;
        def_thread.create_file = DEF_CREATE;
        def_thread.overwrite = DEF_OVERWRITE;
        def_thread.invalidate_cache = DEF_INVALIDATE;
@@ -938,6 +950,7 @@ static int fill_def_thread(void)
        def_thread.rwmixcycle = DEF_RWMIX_CYCLE;
        def_thread.rwmixread = DEF_RWMIX_READ;
        def_thread.nice = DEF_NICE;
+       def_thread.rand_repeatable = DEF_RAND_REPEAT;
 #ifdef FIO_HAVE_DISK_UTIL
        def_thread.do_disk_util = 1;
 #endif
@@ -948,62 +961,46 @@ static int fill_def_thread(void)
 static void usage(char *name)
 {
        printf("%s\n", fio_version_string);
-       printf("\t-s IO is sequential\n");
-       printf("\t-b Block size in KiB for each IO\n");
+       printf("\t-o Write output to file\n");
        printf("\t-t Runtime in seconds\n");
-       printf("\t-R Exit all threads on failure to meet rate goal\n");
-       printf("\t-o Use O_DIRECT\n");
        printf("\t-l Generate per-job latency logs\n");
        printf("\t-w Generate per-job bandwidth logs\n");
        printf("\t-f Job file (Required)\n");
        printf("\t-v Print version info and exit\n");
 }
 
-static void parse_cmd_line(int argc, char *argv[])
+static int parse_cmd_line(int argc, char *argv[])
 {
-       int c;
+       int c, idx = 1, ini_idx = 0;
 
-       while ((c = getopt(argc, argv, "s:b:t:r:R:o:f:lwvhO:")) != EOF) {
+       while ((c = getopt(argc, argv, "t:o:f:lwvh")) != EOF) {
                switch (c) {
-                       case 's':
-                               def_thread.sequential = !!atoi(optarg);
-                               break;
-                       case 'b':
-                               def_thread.bs = atoi(optarg);
-                               def_thread.bs <<= 10;
-                               if (!def_thread.bs) {
-                                       printf("bad block size\n");
-                                       def_thread.bs = DEF_BS;
-                               }
-                               break;
                        case 't':
-                               def_thread.timeout = atoi(optarg);
-                               break;
-                       case 'r':
-                               repeatable = !!atoi(optarg);
-                               break;
-                       case 'R':
-                               rate_quit = !!atoi(optarg);
-                               break;
-                       case 'o':
-                               def_thread.odirect = !!atoi(optarg);
+                               def_timeout = atoi(optarg);
+                               idx++;
                                break;
                        case 'f':
-                               ini_file = strdup(optarg);
+                               ini_idx++;
+                               ini_file = realloc(ini_file, ini_idx * sizeof(char *));
+                               ini_file[ini_idx - 1] = strdup(optarg);
+                               idx++;
                                break;
                        case 'l':
                                write_lat_log = 1;
+                               idx++;
                                break;
                        case 'w':
                                write_bw_log = 1;
+                               idx++;
                                break;
-                       case 'O':
+                       case 'o':
                                f_out = fopen(optarg, "w+");
                                if (!f_out) {
                                        perror("fopen output");
                                        exit(1);
                                }
                                f_err = f_out;
+                               idx++;
                                break;
                        case 'h':
                                usage(argv[0]);
@@ -1014,12 +1011,19 @@ static void parse_cmd_line(int argc, char *argv[])
                }
        }
 
-       if (!ini_file && argc > 1 && argv[argc - 1][0] != '-')
-               ini_file = strdup(argv[argc - 1]);
+       while (idx < argc) {
+               ini_idx++;
+               ini_file = realloc(ini_file, ini_idx * sizeof(char *));
+               ini_file[ini_idx - 1] = strdup(argv[idx]);
+               idx++;
+       }
+               
        if (!f_out) {
                f_out = stdout;
                f_err = stderr;
        }
+
+       return ini_idx;
 }
 
 static void free_shm(void)
@@ -1068,21 +1072,28 @@ static int setup_thread_area(void)
 
 int parse_options(int argc, char *argv[])
 {
+       int job_files, i;
+
        if (setup_thread_area())
                return 1;
        if (fill_def_thread())
                return 1;
 
-       parse_cmd_line(argc, argv);
-
-       if (!ini_file) {
-               log_err("Need job file\n");
+       job_files = parse_cmd_line(argc, argv);
+       if (!job_files) {
+               log_err("Need job file(s)\n");
                usage(argv[0]);
                return 1;
        }
 
-       if (parse_jobs_ini(ini_file))
-               return 1;
+       for (i = 0; i < job_files; i++) {
+               if (fill_def_thread())
+                       return 1;
+               if (parse_jobs_ini(ini_file[i]))
+                       return 1;
+               free(ini_file[i]);
+       }
 
+       free(ini_file);
        return 0;
 }