projects
/
fio.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
[PATCH] Improve job/cmd line parsing error logging
[fio.git]
/
init.c
diff --git
a/init.c
b/init.c
index 6ad3c64c4221124d779ae982ac3b96ee12ced5bc..b004d89012bc44156ef28f1affc2d5329af8e999 100644
(file)
--- a/
init.c
+++ b/
init.c
@@
-932,6
+932,9
@@
int parse_jobs_ini(char *file, int stonewall_flag)
if (!ret) {
fsetpos(f, &off);
ret = add_job(td, name, 0);
if (!ret) {
fsetpos(f, &off);
ret = add_job(td, name, 0);
+ } else {
+ log_err("fio: job %s dropped\n", name);
+ put_job(td);
}
} while (!ret);
}
} while (!ret);
@@
-1054,7
+1057,12
@@
static int parse_cmd_line(int argc, char *argv[])
return 0;
}
return 0;
}
- parse_cmd_option(opt, val, options, td);
+ ret = parse_cmd_option(opt, val, options, td);
+ if (ret) {
+ log_err("fio: job dropped\n");
+ put_job(td);
+ td = NULL;
+ }
break;
}
default:
break;
}
default:
@@
-1184,7
+1192,6
@@
int parse_options(int argc, char *argv[])
if (!thread_number) {
log_err("No jobs defined(s)\n");
if (!thread_number) {
log_err("No jobs defined(s)\n");
- usage();
return 1;
}
return 1;
}