Introduce enum fio_q_status

[fio.git] / engines / rbd.c

diff --git a/engines/rbd.c b/engines/rbd.c
index 743387925e699ff871758b91882b46421ad51a6f..cf7337f00745198f21cd23379ea3362c8e6ee3cd 100644 (file)
--- a/engines/rbd.c
+++ b/engines/rbd.c
@@ -9,9 +9,6 @@
 
 #include "../fio.h"
 #include "../optgroup.h"
-#ifdef CONFIG_RBD_BLKIN
-#include <zipkin_c.h>
-#endif
 
 #ifdef CONFIG_RBD_POLL
 /* add for poll */
@@ -24,9 +21,6 @@ struct fio_rbd_iou {
        rbd_completion_t completion;
        int io_seen;
        int io_complete;
-#ifdef CONFIG_RBD_BLKIN
-       struct blkin_trace_info info;
-#endif
 };
 
 struct rbd_data {
@@ -146,7 +140,7 @@ static bool _fio_rbd_setup_poll(struct rbd_data *rbd)
        int r;
 
        /* add for rbd poll */
-       rbd->fd = eventfd(0, EFD_NONBLOCK);
+       rbd->fd = eventfd(0, EFD_SEMAPHORE);
        if (rbd->fd < 0) {
                log_err("eventfd failed.\n");
                return false;
@@ -366,25 +360,37 @@ static int rbd_iter_events(struct thread_data *td, unsigned int *events,
        int event_num = 0;
        struct fio_rbd_iou *fri = NULL;
        rbd_completion_t comps[min_evts];
+       uint64_t counter;
+       bool completed;
 
        struct pollfd pfd;
        pfd.fd = rbd->fd;
        pfd.events = POLLIN;
 
-       ret = poll(&pfd, 1, -1);
+       ret = poll(&pfd, 1, wait ? -1 : 0);
        if (ret <= 0)
                return 0;
-
-       assert(pfd.revents & POLLIN);
+       if (!(pfd.revents & POLLIN))
+               return 0;
 
        event_num = rbd_poll_io_events(rbd->image, comps, min_evts);
 
        for (i = 0; i < event_num; i++) {
                fri = rbd_aio_get_arg(comps[i]);
                io_u = fri->io_u;
+
+               /* best effort to decrement the semaphore */
+               ret = read(rbd->fd, &counter, sizeof(counter));
+               if (ret <= 0)
+                       log_err("rbd_iter_events failed to decrement semaphore.\n");
+
+               completed = fri_check_complete(rbd, io_u, events);
+               assert(completed);
+
+               this_events++;
+       }
 #else
        io_u_qiter(&td->io_u_all, io_u, i) {
-#endif
                if (!(io_u->flags & IO_U_F_FLIGHT))
                        continue;
                if (rbd_io_u_seen(io_u))
@@ -395,6 +401,7 @@ static int rbd_iter_events(struct thread_data *td, unsigned int *events,
                else if (wait)
                        rbd->sort_events[sidx++] = io_u;
        }
+#endif
 
        if (!wait || !sidx)
                return this_events;
@@ -455,7 +462,8 @@ static int fio_rbd_getevents(struct thread_data *td, unsigned int min,
        return events;
 }
 
-static int fio_rbd_queue(struct thread_data *td, struct io_u *io_u)
+static enum fio_q_status
+fio_rbd_queue(struct thread_data *td, struct io_u *io_u)
 {
        struct rbd_data *rbd = td->io_ops_data;
        struct fio_rbd_iou *fri = io_u->engine_data;
@@ -474,28 +482,16 @@ static int fio_rbd_queue(struct thread_data *td, struct io_u *io_u)
        }
 
        if (io_u->ddir == DDIR_WRITE) {
-#ifdef CONFIG_RBD_BLKIN
-               blkin_init_trace_info(&fri->info);
-               r = rbd_aio_write_traced(rbd->image, io_u->offset, io_u->xfer_buflen,
-                                        io_u->xfer_buf, fri->completion, &fri->info);
-#else
                r = rbd_aio_write(rbd->image, io_u->offset, io_u->xfer_buflen,
                                         io_u->xfer_buf, fri->completion);
-#endif
                if (r < 0) {
                        log_err("rbd_aio_write failed.\n");
                        goto failed_comp;
                }
 
        } else if (io_u->ddir == DDIR_READ) {
-#ifdef CONFIG_RBD_BLKIN
-               blkin_init_trace_info(&fri->info);
-               r = rbd_aio_read_traced(rbd->image, io_u->offset, io_u->xfer_buflen,
-                                       io_u->xfer_buf, fri->completion, &fri->info);
-#else
                r = rbd_aio_read(rbd->image, io_u->offset, io_u->xfer_buflen,
                                        io_u->xfer_buf, fri->completion);
-#endif
 
                if (r < 0) {
                        log_err("rbd_aio_read failed.\n");
@@ -517,6 +513,7 @@ static int fio_rbd_queue(struct thread_data *td, struct io_u *io_u)
        } else {
                dprint(FD_IO, "%s: Warning: unhandled ddir: %d\n", __func__,
                       io_u->ddir);
+               r = -EINVAL;
                goto failed_comp;
        }
 
@@ -597,14 +594,14 @@ static int fio_rbd_setup(struct thread_data *td)
        r = rbd_stat(rbd->image, &info, sizeof(info));
        if (r < 0) {
                log_err("rbd_status failed.\n");
-               goto disconnect;
+               goto cleanup;
        } else if (info.size == 0) {
                log_err("image size should be larger than zero.\n");
                r = -EINVAL;
-               goto disconnect;
+               goto cleanup;
        }
 
-       dprint(FD_IO, "rbd-engine: image size: %lu\n", info.size);
+       dprint(FD_IO, "rbd-engine: image size: %" PRIu64 "\n", info.size);
 
        /* taken from "net" engine. Pretend we deal with files,
         * even if we do not have any ideas about files.
@@ -618,13 +615,8 @@ static int fio_rbd_setup(struct thread_data *td)
        f = td->files[0];
        f->real_file_size = info.size;
 
-       /* disconnect, then we were only connected to determine
-        * the size of the RBD.
-        */
        return 0;
 
-disconnect:
-       _fio_rbd_disconnect(rbd);
 cleanup:
        fio_rbd_cleanup(td);
        return r;