client: ensure that cmd line arguments are always run
[fio.git] / client.c
index 5f0f710a052cc07330bdf4aa3e6c09fea13495f2..c8e4a4dcff728935859270d720d1bb6e062e8080 100644 (file)
--- a/client.c
+++ b/client.c
@@ -8,10 +8,11 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/wait.h>
-#include <sys/mman.h>
+#include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <netdb.h>
+#include <signal.h>
 
 #include "fio.h"
 #include "server.h"
@@ -25,15 +26,18 @@ struct fio_client {
        int fd;
 
        int state;
+       int skip_newline;
 
        uint16_t argc;
        char **argv;
 };
 
 enum {
+       Client_created          = 0,
        Client_connected        = 1,
        Client_started          = 2,
        Client_stopped          = 3,
+       Client_exited           = 4,
 };
 
 static FLIST_HEAD(client_list);
@@ -72,7 +76,7 @@ static struct fio_client *find_client_by_name(const char *name)
 
 static void remove_client(struct fio_client *client)
 {
-       dprint(FD_NET, "removed client <%s>\n", client->hostname);
+       dprint(FD_NET, "client: removed <%s>\n", client->hostname);
        flist_del(&client->list);
        nr_clients--;
 
@@ -83,35 +87,45 @@ static void remove_client(struct fio_client *client)
        free(client);
 }
 
-static void __fio_client_add_cmd_option(struct fio_client *client,
-                                       const char *opt)
+static int __fio_client_add_cmd_option(struct fio_client *client,
+                                      const char *opt)
 {
-       client->argc++;
+       int index;
+
+       if (client->argc == FIO_NET_CMD_JOBLINE_ARGV) {
+               log_err("fio: max cmd line number reached.\n");
+               log_err("fio: cmd line <%s> has been ignored.\n", opt);
+               return 1;
+       }
+
+       index = client->argc++;
        client->argv = realloc(client->argv, sizeof(char *) * client->argc);
-       client->argv[client->argc - 1] = strdup(opt);
+       client->argv[index] = strdup(opt);
+       dprint(FD_NET, "client: add cmd %d: %s\n", index, opt);
+       return 0;
 }
 
-void fio_client_add_cmd_option(const char *hostname, const char *opt)
+int fio_client_add_cmd_option(const char *hostname, const char *opt)
 {
        struct fio_client *client;
 
        if (!hostname || !opt)
-               return;
+               return 0;
 
        client = find_client_by_name(hostname);
        if (!client) {
                log_err("fio: unknown client %s\n", hostname);
-               return;
+               return 1;
        }
 
-       __fio_client_add_cmd_option(client, opt);
+       return __fio_client_add_cmd_option(client, opt);
 }
 
 void fio_client_add(const char *hostname)
 {
        struct fio_client *client;
 
-       dprint(FD_NET, "added client <%s>\n", hostname);
+       dprint(FD_NET, "client: added  <%s>\n", hostname);
        client = malloc(sizeof(*client));
        memset(client, 0, sizeof(*client));
 
@@ -128,7 +142,7 @@ static int fio_client_connect(struct fio_client *client)
 {
        int fd;
 
-       dprint(FD_NET, "connect to host %s\n", client->hostname);
+       dprint(FD_NET, "client: connect to host %s\n", client->hostname);
 
        memset(&client->addr, 0, sizeof(client->addr));
        client->addr.sin_family = AF_INET;
@@ -168,6 +182,8 @@ void fio_clients_terminate(void)
        struct flist_head *entry;
        struct fio_client *client;
 
+       dprint(FD_NET, "client: terminate clients\n");
+
        flist_for_each(entry, &client_list) {
                client = flist_entry(entry, struct fio_client, list);
 
@@ -177,6 +193,7 @@ void fio_clients_terminate(void)
 
 static void sig_int(int sig)
 {
+       dprint(FD_NET, "client: got sign %d\n", sig);
        fio_clients_terminate();
 }
 
@@ -197,6 +214,8 @@ static void client_signal_handler(void)
 
 static void probe_client(struct fio_client *client)
 {
+       dprint(FD_NET, "client: send probe\n");
+
        fio_net_send_simple_cmd(client->fd, FIO_NET_CMD_PROBE, 0);
        handle_client(client, 1);
 }
@@ -206,6 +225,8 @@ static int send_client_cmd_line(struct fio_client *client)
        struct cmd_line_pdu *pdu;
        int i, ret;
 
+       dprint(FD_NET, "client: send cmdline %d\n", client->argc);
+
        pdu = malloc(sizeof(*pdu));
        for (i = 0; i < client->argc; i++)
                strcpy((char *) pdu->argv[i], client->argv[i]);
@@ -222,6 +243,8 @@ int fio_clients_connect(void)
        struct flist_head *entry, *tmp;
        int ret;
 
+       dprint(FD_NET, "client: connect all\n");
+
        client_signal_handler();
 
        flist_for_each_safe(entry, tmp, &client_list) {
@@ -314,9 +337,12 @@ static void convert_io_stat(struct io_stat *dst, struct io_stat *src)
        dst->max_val    = le64_to_cpu(src->max_val);
        dst->min_val    = le64_to_cpu(src->min_val);
        dst->samples    = le64_to_cpu(src->samples);
-       /* FIXME */
-       dst->mean       = __le64_to_cpu(src->mean);
-       dst->S          = __le64_to_cpu(src->S);
+
+       /*
+        * Floats arrive as IEEE 754 encoded uint64_t, convert back to double
+        */
+       dst->mean.u.f   = fio_uint64_to_double(le64_to_cpu(dst->mean.u.i));
+       dst->S.u.f      = fio_uint64_to_double(le64_to_cpu(dst->S.u.i));
 }
 
 static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
@@ -341,7 +367,13 @@ static void convert_ts(struct thread_stat *dst, struct thread_stat *src)
        dst->minf               = le64_to_cpu(src->minf);
        dst->majf               = le64_to_cpu(src->majf);
        dst->clat_percentiles   = le64_to_cpu(src->clat_percentiles);
-       dst->percentile_list    = NULL;
+
+       for (i = 0; i < FIO_IO_U_LIST_MAX_LEN; i++) {
+               fio_fp64_t *fps = &src->percentile_list[i];
+               fio_fp64_t *fpd = &dst->percentile_list[i];
+
+               fpd->u.f = fio_uint64_to_double(le64_to_cpu(fps->u.i));
+       }
 
        for (i = 0; i < FIO_IO_U_MAP_NR; i++) {
                dst->io_u_map[i]        = le32_to_cpu(src->io_u_map[i]);
@@ -442,18 +474,23 @@ static void handle_probe(struct fio_net_cmd *cmd)
 {
        struct cmd_probe_pdu *probe = (struct cmd_probe_pdu *) cmd->payload;
 
-       log_info("Probe: hostname=%s, fio ver %u.%u.%u\n", probe->hostname,
-                       probe->fio_major, probe->fio_minor, probe->fio_patch);
+       log_info("Probe: hostname=%s, be=%u, fio ver %u.%u.%u\n",
+               probe->hostname, probe->bigendian, probe->fio_major,
+               probe->fio_minor, probe->fio_patch);
 }
 
 static int handle_client(struct fio_client *client, int one)
 {
        struct fio_net_cmd *cmd;
-       int done = 0;
+       int done = 0, did_cmd = 0;
+
+       dprint(FD_NET, "client: handle %s\n", client->hostname);
 
        while ((cmd = fio_net_recv_cmd(client->fd, 1)) != NULL) {
-               dprint(FD_NET, "%s: got cmd op %d\n", client->hostname,
-                                                       cmd->opcode);
+               did_cmd++;
+
+               dprint(FD_NET, "client: got cmd op %d from %s\n",
+                                       cmd->opcode, client->hostname);
 
                switch (cmd->opcode) {
                case FIO_NET_CMD_QUIT:
@@ -461,12 +498,18 @@ static int handle_client(struct fio_client *client, int one)
                        free(cmd);
                        done = 1;
                        break;
-               case FIO_NET_CMD_TEXT:
-                       fprintf(f_out, "Client <%s>: ", client->hostname);
-                       fwrite(cmd->payload, cmd->pdu_len, 1, f_out);
+               case FIO_NET_CMD_TEXT: {
+                       const char *buf = (const char *) cmd->payload;
+                       int fio_unused ret;
+
+                       if (!client->skip_newline)
+                               fprintf(f_out, "<%s> ", client->hostname);
+                       ret = fwrite(buf, cmd->pdu_len, 1, f_out);
                        fflush(f_out);
+                       client->skip_newline = strchr(buf, '\n') == NULL;
                        free(cmd);
                        break;
+                       }
                case FIO_NET_CMD_TS:
                        handle_ts(cmd);
                        free(cmd);
@@ -501,7 +544,7 @@ static int handle_client(struct fio_client *client, int one)
                        break;
        }
 
-       return 0;
+       return did_cmd;
 }
 
 int fio_handle_clients(void)
@@ -525,14 +568,16 @@ int fio_handle_clients(void)
 
                assert(i == nr_clients);
 
-               ret = poll(pfds, nr_clients, 100);
-               if (ret < 0) {
-                       if (errno == EINTR)
+               do {
+                       ret = poll(pfds, nr_clients, 100);
+                       if (ret < 0) {
+                               if (errno == EINTR)
+                                       continue;
+                               log_err("fio: poll clients: %s\n", strerror(errno));
+                               break;
+                       } else if (!ret)
                                continue;
-                       log_err("fio: poll clients: %s\n", strerror(errno));
-                       break;
-               } else if (!ret)
-                       continue;
+               } while (ret <= 0);
 
                for (i = 0; i < nr_clients; i++) {
                        if (!(pfds[i].revents & POLLIN))