t/run-fio-tests: a script to automate running fio tests

[fio.git] / backend.c

diff --git a/backend.c b/backend.c
index a92ec456609e1c6541e4896215cff78b8809d85f..1c339408fa5fd0338cdd0e98444b5a7a2fa509a8 100644 (file)
--- a/backend.c
+++ b/backend.c
@@ -281,6 +281,7 @@ static bool fio_io_sync(struct thread_data *td, struct fio_file *f)
 
        io_u->ddir = DDIR_SYNC;
        io_u->file = f;
+       io_u_set(td, io_u, IO_U_F_NO_FILE_PUT);
 
        if (td_io_prep(td, io_u)) {
                put_io_u(td, io_u);
@@ -314,7 +315,7 @@ requeue:
 
 static int fio_file_fsync(struct thread_data *td, struct fio_file *f)
 {
-       int ret;
+       int ret, ret2;
 
        if (fio_file_open(f))
                return fio_io_sync(td, f);
@@ -323,8 +324,10 @@ static int fio_file_fsync(struct thread_data *td, struct fio_file *f)
                return 1;
 
        ret = fio_io_sync(td, f);
-       td_io_close_file(td, f);
-       return ret;
+       ret2 = 0;
+       if (fio_file_open(f))
+               ret2 = td_io_close_file(td, f);
+       return (ret || ret2);
 }
 
 static inline void __update_ts_cache(struct thread_data *td)
@@ -1124,7 +1127,7 @@ reap:
                                td->error = 0;
                }
 
-               if (should_fsync(td) && td->o.end_fsync) {
+               if (should_fsync(td) && (td->o.end_fsync || td->o.fsync_on_close)) {
                        td_set_runstate(td, TD_FSYNCING);
 
                        for_each_file(td, f, i) {
@@ -1233,7 +1236,7 @@ static int init_io_u(struct thread_data *td)
                ptr = fio_memalign(cl_align, sizeof(*io_u), td_offload_overlap(td));
                if (!ptr) {
                        log_err("fio: unable to allocate aligned memory\n");
-                       break;
+                       return 1;
                }
 
                io_u = ptr;
@@ -1466,12 +1469,12 @@ static bool keep_running(struct thread_data *td)
 
 static int exec_string(struct thread_options *o, const char *string, const char *mode)
 {
-       size_t newlen = strlen(string) + strlen(o->name) + strlen(mode) + 9 + 1;
+       size_t newlen = strlen(string) + strlen(o->name) + strlen(mode) + 13 + 1;
        int ret;
        char *str;
 
        str = malloc(newlen);
-       sprintf(str, "%s &> %s.%s.txt", string, o->name, mode);
+       sprintf(str, "%s > %s.%s.txt 2>&1", string, o->name, mode);
 
        log_info("%s : Saving output of %s in %s.%s.txt\n",o->name, mode, o->name, mode);
        ret = system(str);
@@ -1542,7 +1545,7 @@ static void *thread_main(void *data)
        struct sk_out *sk_out = fd->sk_out;
        uint64_t bytes_done[DDIR_RWDIR_CNT];
        int deadlock_loop_cnt;
-       bool clear_state, did_some_io;
+       bool clear_state;
        int ret;
 
        sk_out_assign(sk_out);
@@ -1698,9 +1701,15 @@ static void *thread_main(void *data)
        if (!init_iolog(td))
                goto err;
 
+       if (td_io_init(td))
+               goto err;
+
        if (init_io_u(td))
                goto err;
 
+       if (td->io_ops->post_init && td->io_ops->post_init(td))
+               goto err;
+
        if (o->verify_async && verify_async_init(td))
                goto err;
 
@@ -1728,9 +1737,6 @@ static void *thread_main(void *data)
        if (!o->create_serialize && setup_files(td))
                goto err;
 
-       if (td_io_init(td))
-               goto err;
-
        if (!init_random_map(td))
                goto err;
 
@@ -1763,7 +1769,6 @@ static void *thread_main(void *data)
 
        memset(bytes_done, 0, sizeof(bytes_done));
        clear_state = false;
-       did_some_io = false;
 
        while (keep_running(td)) {
                uint64_t verify_bytes;
@@ -1841,9 +1846,6 @@ static void *thread_main(void *data)
                    td_ioengine_flagged(td, FIO_UNIDIR))
                        continue;
 
-               if (ddir_rw_sum(bytes_done))
-                       did_some_io = true;
-
                clear_io_state(td, 0);
 
                fio_gettime(&td->start, NULL);
@@ -1864,19 +1866,6 @@ static void *thread_main(void *data)
                        break;
        }
 
-       /*
-        * If td ended up with no I/O when it should have had,
-        * then something went wrong unless FIO_NOIO or FIO_DISKLESSIO.
-        * (Are we not missing other flags that can be ignored ?)
-        */
-       if (!td->error && (td->o.size || td->o.io_size) &&
-           !ddir_rw_sum(bytes_done) && !did_some_io && !td->o.create_only &&
-           !(td_ioengine_flagged(td, FIO_NOIO) ||
-             td_ioengine_flagged(td, FIO_DISKLESSIO)))
-               log_err("%s: No I/O performed by %s, "
-                        "perhaps try --debug=io option for details?\n",
-                        td->o.name, td->io_ops->name);
-
        /*
         * Acquire this lock if we were doing overlap checking in
         * offload mode so that we don't clean up this job while