projects
/
fio.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fio 1.27.4
[fio.git]
/
smalloc.c
diff --git
a/smalloc.c
b/smalloc.c
index 1c975df47ae3f6a6fcf6088ed1bc25e679e9eb2b..e82ef1da0b59faab23a706db1257808c3fb10bbb 100644
(file)
--- a/
smalloc.c
+++ b/
smalloc.c
@@
-14,7
+14,6
@@
#include "mutex.h"
#include "arch/arch.h"
#include "mutex.h"
#include "arch/arch.h"
-#define MP_SAFE /* define to make thread safe */
#define SMALLOC_REDZONE /* define to detect memory corruption */
#define SMALLOC_BPB 32 /* block size, bytes-per-bit in bitmap */
#define SMALLOC_REDZONE /* define to detect memory corruption */
#define SMALLOC_BPB 32 /* block size, bytes-per-bit in bitmap */
@@
-37,7
+36,6
@@
struct pool {
unsigned int nr_blocks; /* total blocks */
unsigned int next_non_full;
int fd; /* memory backing fd */
unsigned int nr_blocks; /* total blocks */
unsigned int next_non_full;
int fd; /* memory backing fd */
- char file[PATH_MAX]; /* filename for fd */
unsigned int mmap_size;
};
unsigned int mmap_size;
};
@@
-55,38
+53,32
@@
static struct fio_mutex *lock;
static inline void pool_lock(struct pool *pool)
{
static inline void pool_lock(struct pool *pool)
{
- if (pool->lock)
- fio_mutex_down(pool->lock);
+ fio_mutex_down(pool->lock);
}
static inline void pool_unlock(struct pool *pool)
{
}
static inline void pool_unlock(struct pool *pool)
{
- if (pool->lock)
- fio_mutex_up(pool->lock);
+ fio_mutex_up(pool->lock);
}
static inline void global_read_lock(void)
{
}
static inline void global_read_lock(void)
{
- if (lock)
- fio_mutex_down_read(lock);
+ fio_mutex_down_read(lock);
}
static inline void global_read_unlock(void)
{
}
static inline void global_read_unlock(void)
{
- if (lock)
- fio_mutex_up_read(lock);
+ fio_mutex_up_read(lock);
}
static inline void global_write_lock(void)
{
}
static inline void global_write_lock(void)
{
- if (lock)
- fio_mutex_down_write(lock);
+ fio_mutex_down_write(lock);
}
static inline void global_write_unlock(void)
{
}
static inline void global_write_unlock(void)
{
- if (lock)
- fio_mutex_up_write(lock);
+ fio_mutex_up_write(lock);
}
static inline int ptr_valid(struct pool *pool, void *ptr)
}
static inline int ptr_valid(struct pool *pool, void *ptr)
@@
-183,11
+175,11
@@
static int find_next_zero(int word, int start)
static int add_pool(struct pool *pool, unsigned int alloc_size)
{
static int add_pool(struct pool *pool, unsigned int alloc_size)
{
- void *ptr;
int fd, bitmap_blocks;
int fd, bitmap_blocks;
+ char file[] = "/tmp/.fio_smalloc.XXXXXX";
+ void *ptr;
- strcpy(pool->file, "/tmp/.fio_smalloc.XXXXXX");
- fd = mkstemp(pool->file);
+ fd = mkstemp(file);
if (fd < 0)
goto out_close;
if (fd < 0)
goto out_close;
@@
-218,26
+210,27
@@
static int add_pool(struct pool *pool, unsigned int alloc_size)
pool->map = ptr;
pool->bitmap = (void *) ptr + (pool->nr_blocks * SMALLOC_BPL);
pool->map = ptr;
pool->bitmap = (void *) ptr + (pool->nr_blocks * SMALLOC_BPL);
-#ifdef MP_SAFE
pool->lock = fio_mutex_init(1);
if (!pool->lock)
goto out_unlink;
pool->lock = fio_mutex_init(1);
if (!pool->lock)
goto out_unlink;
-#endif
+ /*
+ * Unlink pool file now. It wont get deleted until the fd is closed,
+ * which happens both for cleanup or unexpected quit. This way we
+ * don't leave temp files around in case of a crash.
+ */
+ unlink(file);
pool->fd = fd;
pool->fd = fd;
- global_write_lock();
nr_pools++;
nr_pools++;
- global_write_unlock();
return 0;
out_unlink:
fprintf(stderr, "smalloc: failed adding pool\n");
if (pool->map)
munmap(pool->map, pool->mmap_size);
return 0;
out_unlink:
fprintf(stderr, "smalloc: failed adding pool\n");
if (pool->map)
munmap(pool->map, pool->mmap_size);
- unlink(
pool->
file);
+ unlink(file);
out_close:
out_close:
- if (fd >= 0)
- close(fd);
+ close(fd);
return 1;
}
return 1;
}
@@
-245,16
+238,17
@@
void sinit(void)
{
int ret;
{
int ret;
-#ifdef MP_SAFE
lock = fio_mutex_rw_init();
lock = fio_mutex_rw_init();
-#endif
ret = add_pool(&mp[0], INITIAL_SIZE);
assert(!ret);
}
static void cleanup_pool(struct pool *pool)
{
ret = add_pool(&mp[0], INITIAL_SIZE);
assert(!ret);
}
static void cleanup_pool(struct pool *pool)
{
- unlink(pool->file);
+ /*
+ * This will also remove the temporary file we used as a backing
+ * store, it was already unlinked
+ */
close(pool->fd);
munmap(pool->map, pool->mmap_size);
close(pool->fd);
munmap(pool->map, pool->mmap_size);
@@
-442,7
+436,7
@@
void *smalloc(unsigned int size)
{
unsigned int i;
{
unsigned int i;
- global_
read
_lock();
+ global_
write
_lock();
i = last_pool;
do {
i = last_pool;
do {
@@
-451,7
+445,7
@@
void *smalloc(unsigned int size)
if (ptr) {
last_pool = i;
if (ptr) {
last_pool = i;
- global_
read
_unlock();
+ global_
write
_unlock();
return ptr;
}
}
return ptr;
}
}
@@
-464,15
+458,13
@@
void *smalloc(unsigned int size)
break;
else {
i = nr_pools;
break;
else {
i = nr_pools;
- global_read_unlock();
if (add_pool(&mp[nr_pools], size))
goto out;
if (add_pool(&mp[nr_pools], size))
goto out;
- global_read_lock();
}
} while (1);
}
} while (1);
- global_read_unlock();
out:
out:
+ global_write_unlock();
return NULL;
}
return NULL;
}