Commit | Line | Data |
---|---|---|
9f8f2064 JA |
1 | #include <stdio.h> |
2 | #include <string.h> | |
3 | #include <sys/time.h> | |
4 | #include <sys/types.h> | |
5 | #include <sys/stat.h> | |
6 | #include <dirent.h> | |
7 | #include <libgen.h> | |
8 | #include <math.h> | |
9 | ||
10 | #include "fio.h" | |
c97bd0fa | 11 | #include "smalloc.h" |
7c9b1bce | 12 | #include "diskutil.h" |
9f8f2064 JA |
13 | |
14 | static int last_majdev, last_mindev; | |
c97bd0fa | 15 | static struct disk_util *last_du; |
9f8f2064 | 16 | |
01743ee1 | 17 | static struct flist_head disk_list = FLIST_HEAD_INIT(disk_list); |
9f8f2064 | 18 | |
2db4ecca JA |
19 | static struct disk_util *__init_per_file_disk_util(struct thread_data *td, |
20 | int majdev, int mindev, char *path); | |
21 | ||
c97bd0fa JA |
22 | static void disk_util_free(struct disk_util *du) |
23 | { | |
24 | if (du == last_du) | |
25 | last_du = NULL; | |
26 | ||
b8d541d5 JA |
27 | while (!flist_empty(&du->slaves)) { |
28 | struct disk_util *slave; | |
29 | ||
30 | slave = flist_entry(du->slaves.next, struct disk_util, slavelist); | |
31 | flist_del(&slave->slavelist); | |
32 | slave->users--; | |
33 | } | |
34 | ||
c97bd0fa JA |
35 | fio_mutex_remove(du->lock); |
36 | sfree(du->name); | |
37 | sfree(du); | |
38 | } | |
39 | ||
9f8f2064 JA |
40 | static int get_io_ticks(struct disk_util *du, struct disk_util_stat *dus) |
41 | { | |
42 | unsigned in_flight; | |
43 | char line[256]; | |
44 | FILE *f; | |
45 | char *p; | |
5ec10eaa | 46 | int ret; |
9f8f2064 | 47 | |
cd991b9e JA |
48 | dprint(FD_DISKUTIL, "open stat file: %s\n", du->path); |
49 | ||
9f8f2064 JA |
50 | f = fopen(du->path, "r"); |
51 | if (!f) | |
52 | return 1; | |
53 | ||
54 | p = fgets(line, sizeof(line), f); | |
55 | if (!p) { | |
56 | fclose(f); | |
57 | return 1; | |
58 | } | |
59 | ||
cd991b9e JA |
60 | dprint(FD_DISKUTIL, "%s: %s", du->path, p); |
61 | ||
62 | ret = sscanf(p, "%u %u %llu %u %u %u %llu %u %u %u %u\n", &dus->ios[0], | |
5ec10eaa JA |
63 | &dus->merges[0], &dus->sectors[0], |
64 | &dus->ticks[0], &dus->ios[1], | |
65 | &dus->merges[1], &dus->sectors[1], | |
66 | &dus->ticks[1], &in_flight, | |
67 | &dus->io_ticks, &dus->time_in_queue); | |
9f8f2064 | 68 | fclose(f); |
cd991b9e JA |
69 | dprint(FD_DISKUTIL, "%s: stat read ok? %d\n", du->path, ret == 1); |
70 | return ret != 11; | |
9f8f2064 JA |
71 | } |
72 | ||
73 | static void update_io_tick_disk(struct disk_util *du) | |
74 | { | |
75 | struct disk_util_stat __dus, *dus, *ldus; | |
76 | struct timeval t; | |
77 | ||
c97bd0fa JA |
78 | if (!du->users) |
79 | return; | |
90b97ac3 JA |
80 | if (get_io_ticks(du, &__dus)) |
81 | return; | |
9f8f2064 JA |
82 | |
83 | dus = &du->dus; | |
84 | ldus = &du->last_dus; | |
85 | ||
86 | dus->sectors[0] += (__dus.sectors[0] - ldus->sectors[0]); | |
87 | dus->sectors[1] += (__dus.sectors[1] - ldus->sectors[1]); | |
88 | dus->ios[0] += (__dus.ios[0] - ldus->ios[0]); | |
89 | dus->ios[1] += (__dus.ios[1] - ldus->ios[1]); | |
90 | dus->merges[0] += (__dus.merges[0] - ldus->merges[0]); | |
91 | dus->merges[1] += (__dus.merges[1] - ldus->merges[1]); | |
92 | dus->ticks[0] += (__dus.ticks[0] - ldus->ticks[0]); | |
93 | dus->ticks[1] += (__dus.ticks[1] - ldus->ticks[1]); | |
94 | dus->io_ticks += (__dus.io_ticks - ldus->io_ticks); | |
95 | dus->time_in_queue += (__dus.time_in_queue - ldus->time_in_queue); | |
96 | ||
97 | fio_gettime(&t, NULL); | |
98 | du->msec += mtime_since(&du->time, &t); | |
99 | memcpy(&du->time, &t, sizeof(t)); | |
100 | memcpy(ldus, &__dus, sizeof(__dus)); | |
101 | } | |
102 | ||
103 | void update_io_ticks(void) | |
104 | { | |
01743ee1 | 105 | struct flist_head *entry; |
9f8f2064 JA |
106 | struct disk_util *du; |
107 | ||
cd991b9e JA |
108 | dprint(FD_DISKUTIL, "update io ticks\n"); |
109 | ||
01743ee1 JA |
110 | flist_for_each(entry, &disk_list) { |
111 | du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 JA |
112 | update_io_tick_disk(du); |
113 | } | |
114 | } | |
115 | ||
e11c410c | 116 | static struct disk_util *disk_util_exists(int major, int minor) |
9f8f2064 | 117 | { |
01743ee1 | 118 | struct flist_head *entry; |
9f8f2064 JA |
119 | struct disk_util *du; |
120 | ||
01743ee1 JA |
121 | flist_for_each(entry, &disk_list) { |
122 | du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 JA |
123 | |
124 | if (major == du->major && minor == du->minor) | |
e11c410c | 125 | return du; |
9f8f2064 JA |
126 | } |
127 | ||
e11c410c | 128 | return NULL; |
9f8f2064 JA |
129 | } |
130 | ||
67423013 ST |
131 | static int get_device_numbers(char *file_name, int *maj, int *min) |
132 | { | |
133 | struct stat st; | |
134 | int majdev, mindev; | |
135 | char tempname[PATH_MAX], *p; | |
136 | ||
137 | if (!lstat(file_name, &st)) { | |
138 | if (S_ISBLK(st.st_mode)) { | |
139 | majdev = major(st.st_rdev); | |
140 | mindev = minor(st.st_rdev); | |
141 | } else if (S_ISCHR(st.st_mode)) { | |
142 | majdev = major(st.st_rdev); | |
143 | mindev = minor(st.st_rdev); | |
144 | if (fio_lookup_raw(st.st_rdev, &majdev, &mindev)) | |
145 | return -1; | |
146 | } else if (S_ISFIFO(st.st_mode)) | |
147 | return -1; | |
148 | else { | |
149 | majdev = major(st.st_dev); | |
150 | mindev = minor(st.st_dev); | |
151 | } | |
152 | } else { | |
153 | /* | |
154 | * must be a file, open "." in that path | |
155 | */ | |
156 | strncpy(tempname, file_name, PATH_MAX - 1); | |
157 | p = dirname(tempname); | |
158 | if (stat(p, &st)) { | |
159 | perror("disk util stat"); | |
160 | return -1; | |
161 | } | |
162 | ||
163 | majdev = major(st.st_dev); | |
164 | mindev = minor(st.st_dev); | |
165 | } | |
166 | ||
167 | *min = mindev; | |
168 | *maj = majdev; | |
169 | ||
170 | return 0; | |
171 | } | |
172 | ||
173 | static int read_block_dev_entry(char *path, int *maj, int *min) | |
174 | { | |
175 | char line[256], *p; | |
176 | FILE *f; | |
177 | ||
178 | f = fopen(path, "r"); | |
179 | if (!f) { | |
180 | perror("open path"); | |
181 | return 1; | |
182 | } | |
183 | ||
184 | p = fgets(line, sizeof(line), f); | |
185 | fclose(f); | |
186 | ||
187 | if (!p) | |
188 | return 1; | |
189 | ||
190 | if (sscanf(p, "%u:%u", maj, min) != 2) | |
191 | return 1; | |
192 | ||
193 | return 0; | |
194 | } | |
195 | ||
67423013 | 196 | static void find_add_disk_slaves(struct thread_data *td, char *path, |
2db4ecca | 197 | struct disk_util *masterdu) |
67423013 ST |
198 | { |
199 | DIR *dirhandle = NULL; | |
200 | struct dirent *dirent = NULL; | |
201 | char slavesdir[PATH_MAX], temppath[PATH_MAX], slavepath[PATH_MAX]; | |
202 | struct disk_util *slavedu = NULL; | |
203 | int majdev, mindev; | |
204 | ssize_t linklen; | |
205 | ||
2db4ecca | 206 | sprintf(slavesdir, "%s/%s", path, "slaves"); |
67423013 ST |
207 | dirhandle = opendir(slavesdir); |
208 | if (!dirhandle) | |
209 | return; | |
210 | ||
211 | while ((dirent = readdir(dirhandle)) != NULL) { | |
2db4ecca JA |
212 | if (!strcmp(dirent->d_name, ".") || |
213 | !strcmp(dirent->d_name, "..")) | |
67423013 ST |
214 | continue; |
215 | ||
216 | sprintf(temppath, "%s/%s", slavesdir, dirent->d_name); | |
217 | /* Can we always assume that the slaves device entries | |
218 | * are links to the real directories for the slave | |
219 | * devices? | |
220 | */ | |
2db4ecca JA |
221 | linklen = readlink(temppath, slavepath, PATH_MAX - 0); |
222 | if (linklen < 0) { | |
67423013 ST |
223 | perror("readlink() for slave device."); |
224 | return; | |
225 | } | |
2db4ecca | 226 | slavepath[linklen] = '\0'; |
67423013 ST |
227 | |
228 | sprintf(temppath, "%s/%s/dev", slavesdir, slavepath); | |
229 | if (read_block_dev_entry(temppath, &majdev, &mindev)) { | |
230 | perror("Error getting slave device numbers."); | |
231 | return; | |
232 | } | |
233 | ||
b06de82e AB |
234 | /* |
235 | * See if this maj,min already exists | |
236 | */ | |
237 | slavedu = disk_util_exists(majdev, mindev); | |
238 | if (slavedu) | |
239 | continue; | |
240 | ||
67423013 ST |
241 | sprintf(temppath, "%s/%s", slavesdir, slavepath); |
242 | __init_per_file_disk_util(td, majdev, mindev, temppath); | |
243 | slavedu = disk_util_exists(majdev, mindev); | |
244 | ||
245 | /* Should probably use an assert here. slavedu should | |
246 | * always be present at this point. */ | |
b8d541d5 JA |
247 | if (slavedu) { |
248 | slavedu->users++; | |
67423013 | 249 | flist_add_tail(&slavedu->slavelist, &masterdu->slaves); |
b8d541d5 | 250 | } |
67423013 ST |
251 | } |
252 | ||
253 | closedir(dirhandle); | |
67423013 ST |
254 | } |
255 | ||
c97bd0fa JA |
256 | static struct disk_util *disk_util_add(struct thread_data * td, int majdev, |
257 | int mindev, char *path) | |
9f8f2064 JA |
258 | { |
259 | struct disk_util *du, *__du; | |
01743ee1 | 260 | struct flist_head *entry; |
9f8f2064 | 261 | |
cd991b9e JA |
262 | dprint(FD_DISKUTIL, "add maj/min %d/%d: %s\n", majdev, mindev, path); |
263 | ||
c97bd0fa | 264 | du = smalloc(sizeof(*du)); |
9f8f2064 | 265 | memset(du, 0, sizeof(*du)); |
01743ee1 | 266 | INIT_FLIST_HEAD(&du->list); |
9f8f2064 | 267 | sprintf(du->path, "%s/stat", path); |
c97bd0fa | 268 | du->name = smalloc_strdup(basename(path)); |
e11c410c | 269 | du->sysfs_root = path; |
9f8f2064 JA |
270 | du->major = majdev; |
271 | du->minor = mindev; | |
67423013 ST |
272 | INIT_FLIST_HEAD(&du->slavelist); |
273 | INIT_FLIST_HEAD(&du->slaves); | |
c97bd0fa JA |
274 | du->lock = fio_mutex_init(1); |
275 | du->users = 0; | |
9f8f2064 | 276 | |
01743ee1 JA |
277 | flist_for_each(entry, &disk_list) { |
278 | __du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 | 279 | |
cd991b9e JA |
280 | dprint(FD_DISKUTIL, "found %s in list\n", __du->name); |
281 | ||
9f8f2064 | 282 | if (!strcmp(du->name, __du->name)) { |
c97bd0fa JA |
283 | disk_util_free(du); |
284 | return __du; | |
9f8f2064 JA |
285 | } |
286 | } | |
287 | ||
cd991b9e JA |
288 | dprint(FD_DISKUTIL, "add %s to list\n", du->name); |
289 | ||
9f8f2064 JA |
290 | fio_gettime(&du->time, NULL); |
291 | get_io_ticks(du, &du->last_dus); | |
292 | ||
01743ee1 | 293 | flist_add_tail(&du->list, &disk_list); |
67423013 | 294 | find_add_disk_slaves(td, path, du); |
c97bd0fa | 295 | return du; |
9f8f2064 JA |
296 | } |
297 | ||
298 | static int check_dev_match(int majdev, int mindev, char *path) | |
299 | { | |
300 | int major, minor; | |
9f8f2064 | 301 | |
67423013 | 302 | if (read_block_dev_entry(path, &major, &minor)) |
9f8f2064 | 303 | return 1; |
9f8f2064 | 304 | |
c97bd0fa | 305 | if (majdev == major && mindev == minor) |
9f8f2064 | 306 | return 0; |
9f8f2064 | 307 | |
9f8f2064 JA |
308 | return 1; |
309 | } | |
310 | ||
ac0be2ac | 311 | static int find_block_dir(int majdev, int mindev, char *path, int link_ok) |
9f8f2064 JA |
312 | { |
313 | struct dirent *dir; | |
314 | struct stat st; | |
315 | int found = 0; | |
316 | DIR *D; | |
317 | ||
318 | D = opendir(path); | |
319 | if (!D) | |
320 | return 0; | |
321 | ||
322 | while ((dir = readdir(D)) != NULL) { | |
323 | char full_path[256]; | |
324 | ||
325 | if (!strcmp(dir->d_name, ".") || !strcmp(dir->d_name, "..")) | |
326 | continue; | |
327 | ||
328 | sprintf(full_path, "%s/%s", path, dir->d_name); | |
329 | ||
330 | if (!strcmp(dir->d_name, "dev")) { | |
331 | if (!check_dev_match(majdev, mindev, full_path)) { | |
332 | found = 1; | |
333 | break; | |
334 | } | |
335 | } | |
336 | ||
ac0be2ac JA |
337 | if (link_ok) { |
338 | if (stat(full_path, &st) == -1) { | |
339 | perror("stat"); | |
340 | break; | |
341 | } | |
342 | } else { | |
343 | if (lstat(full_path, &st) == -1) { | |
344 | perror("stat"); | |
345 | break; | |
346 | } | |
9f8f2064 JA |
347 | } |
348 | ||
349 | if (!S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode)) | |
350 | continue; | |
351 | ||
ac0be2ac | 352 | found = find_block_dir(majdev, mindev, full_path, 0); |
9f8f2064 JA |
353 | if (found) { |
354 | strcpy(path, full_path); | |
355 | break; | |
356 | } | |
357 | } | |
358 | ||
359 | closedir(D); | |
360 | return found; | |
361 | } | |
362 | ||
c97bd0fa JA |
363 | static struct disk_util *__init_per_file_disk_util(struct thread_data *td, |
364 | int majdev, int mindev, | |
365 | char *path) | |
9f8f2064 JA |
366 | { |
367 | struct stat st; | |
67423013 | 368 | char tmp[PATH_MAX]; |
9f8f2064 JA |
369 | char *p; |
370 | ||
67423013 ST |
371 | /* |
372 | * If there's a ../queue/ directory there, we are inside a partition. | |
373 | * Check if that is the case and jump back. For loop/md/dm etc we | |
374 | * are already in the right spot. | |
375 | */ | |
376 | sprintf(tmp, "%s/../queue", path); | |
377 | if (!stat(tmp, &st)) { | |
378 | p = dirname(path); | |
379 | sprintf(tmp, "%s/queue", p); | |
380 | if (stat(tmp, &st)) { | |
381 | log_err("unknown sysfs layout\n"); | |
c97bd0fa | 382 | return NULL; |
9f8f2064 | 383 | } |
67423013 ST |
384 | strncpy(tmp, p, PATH_MAX - 1); |
385 | sprintf(path, "%s", tmp); | |
9f8f2064 JA |
386 | } |
387 | ||
67423013 ST |
388 | if (td->o.ioscheduler && !td->sysfs_root) |
389 | td->sysfs_root = strdup(path); | |
390 | ||
c97bd0fa | 391 | return disk_util_add(td, majdev, mindev, path); |
67423013 ST |
392 | } |
393 | ||
c97bd0fa JA |
394 | static struct disk_util *init_per_file_disk_util(struct thread_data *td, |
395 | char *filename) | |
67423013 ST |
396 | { |
397 | ||
398 | char foo[PATH_MAX]; | |
399 | struct disk_util *du; | |
400 | int mindev, majdev; | |
401 | ||
c97bd0fa JA |
402 | if (get_device_numbers(filename, &majdev, &mindev)) |
403 | return NULL; | |
67423013 ST |
404 | |
405 | dprint(FD_DISKUTIL, "%s belongs to maj/min %d/%d\n", filename, majdev, | |
406 | mindev); | |
cd991b9e | 407 | |
e11c410c JA |
408 | du = disk_util_exists(majdev, mindev); |
409 | if (du) { | |
410 | if (td->o.ioscheduler && !td->sysfs_root) | |
411 | td->sysfs_root = strdup(du->sysfs_root); | |
412 | ||
c97bd0fa | 413 | return du; |
e11c410c | 414 | } |
9f8f2064 JA |
415 | |
416 | /* | |
417 | * for an fs without a device, we will repeatedly stat through | |
418 | * sysfs which can take oodles of time for thousands of files. so | |
419 | * cache the last lookup and compare with that before going through | |
420 | * everything again. | |
421 | */ | |
422 | if (mindev == last_mindev && majdev == last_majdev) | |
c97bd0fa | 423 | return last_du; |
9f8f2064 JA |
424 | |
425 | last_mindev = mindev; | |
426 | last_majdev = majdev; | |
5ec10eaa | 427 | |
9f8f2064 | 428 | sprintf(foo, "/sys/block"); |
ac0be2ac | 429 | if (!find_block_dir(majdev, mindev, foo, 1)) |
c97bd0fa | 430 | return NULL; |
9f8f2064 | 431 | |
c97bd0fa | 432 | return __init_per_file_disk_util(td, majdev, mindev, foo); |
67423013 | 433 | } |
9f8f2064 | 434 | |
c97bd0fa JA |
435 | static struct disk_util *__init_disk_util(struct thread_data *td, |
436 | struct fio_file *f) | |
67423013 ST |
437 | { |
438 | return init_per_file_disk_util(td, f->file_name); | |
9f8f2064 JA |
439 | } |
440 | ||
441 | void init_disk_util(struct thread_data *td) | |
442 | { | |
443 | struct fio_file *f; | |
444 | unsigned int i; | |
445 | ||
446 | if (!td->o.do_disk_util || | |
447 | (td->io_ops->flags & (FIO_DISKLESSIO | FIO_NODISKUTIL))) | |
448 | return; | |
449 | ||
450 | for_each_file(td, f, i) | |
c97bd0fa | 451 | f->du = __init_disk_util(td, f); |
9f8f2064 JA |
452 | } |
453 | ||
043b74b9 ST |
454 | static void aggregate_slaves_stats(struct disk_util *masterdu) |
455 | { | |
456 | struct disk_util_stat *dus; | |
457 | struct flist_head *entry; | |
458 | struct disk_util *slavedu; | |
459 | double util, max_util = 0; | |
460 | int slavecount = 0; | |
461 | ||
5e28df3c JA |
462 | unsigned merges[2] = { 0, }; |
463 | unsigned ticks[2] = { 0, }; | |
464 | unsigned time_in_queue = { 0, }; | |
465 | unsigned long long sectors[2] = { 0, }; | |
466 | unsigned ios[2] = { 0, }; | |
043b74b9 ST |
467 | |
468 | flist_for_each(entry, &masterdu->slaves) { | |
469 | slavedu = flist_entry(entry, struct disk_util, slavelist); | |
470 | dus = &slavedu->dus; | |
471 | ios[0] += dus->ios[0]; | |
472 | ios[1] += dus->ios[1]; | |
473 | merges[0] += dus->merges[0]; | |
474 | merges[1] += dus->merges[1]; | |
475 | sectors[0] += dus->sectors[0]; | |
476 | sectors[1] += dus->sectors[1]; | |
477 | ticks[0] += dus->ticks[0]; | |
478 | ticks[1] += dus->ticks[1]; | |
479 | time_in_queue += dus->time_in_queue; | |
480 | ++slavecount; | |
481 | ||
482 | util = (double) (100 * dus->io_ticks / (double) slavedu->msec); | |
483 | /* System utilization is the utilization of the | |
484 | * component with the highest utilization. | |
485 | */ | |
486 | if (util > max_util) | |
487 | max_util = util; | |
488 | ||
489 | } | |
490 | ||
491 | if (max_util > 100.0) | |
492 | max_util = 100.0; | |
493 | ||
494 | log_info(", aggrios=%u/%u, aggrmerge=%u/%u, aggrticks=%u/%u," | |
495 | " aggrin_queue=%u, aggrutil=%3.2f%%", | |
496 | ios[0]/slavecount, ios[1]/slavecount, | |
497 | merges[0]/slavecount, merges[1]/slavecount, | |
498 | ticks[0]/slavecount, ticks[1]/slavecount, | |
499 | time_in_queue/slavecount, max_util); | |
500 | ||
501 | } | |
502 | ||
9f8f2064 JA |
503 | void show_disk_util(void) |
504 | { | |
505 | struct disk_util_stat *dus; | |
01743ee1 | 506 | struct flist_head *entry, *next; |
9f8f2064 JA |
507 | struct disk_util *du; |
508 | double util; | |
509 | ||
01743ee1 | 510 | if (flist_empty(&disk_list)) |
0a839f30 JA |
511 | return; |
512 | ||
9f8f2064 JA |
513 | log_info("\nDisk stats (read/write):\n"); |
514 | ||
01743ee1 JA |
515 | flist_for_each(entry, &disk_list) { |
516 | du = flist_entry(entry, struct disk_util, list); | |
9f8f2064 JA |
517 | dus = &du->dus; |
518 | ||
519 | util = (double) 100 * du->dus.io_ticks / (double) du->msec; | |
520 | if (util > 100.0) | |
521 | util = 100.0; | |
522 | ||
67423013 ST |
523 | /* If this node is the slave of a master device, as |
524 | * happens in case of software RAIDs, inward-indent | |
525 | * this stats line to reflect a master-slave | |
526 | * relationship. Because the master device gets added | |
527 | * before the slave devices, we can safely assume that | |
528 | * the master's stats line has been displayed in a | |
529 | * previous iteration of this loop. | |
530 | */ | |
2db4ecca | 531 | if (!flist_empty(&du->slavelist)) |
67423013 ST |
532 | log_info(" "); |
533 | ||
5ec10eaa | 534 | log_info(" %s: ios=%u/%u, merge=%u/%u, ticks=%u/%u, " |
043b74b9 | 535 | "in_queue=%u, util=%3.2f%%", du->name, |
5ec10eaa JA |
536 | dus->ios[0], dus->ios[1], |
537 | dus->merges[0], dus->merges[1], | |
538 | dus->ticks[0], dus->ticks[1], | |
539 | dus->time_in_queue, util); | |
043b74b9 ST |
540 | |
541 | /* If the device has slaves, aggregate the stats for | |
542 | * those slave devices also. | |
543 | */ | |
2db4ecca | 544 | if (!flist_empty(&du->slaves)) |
043b74b9 ST |
545 | aggregate_slaves_stats(du); |
546 | ||
547 | log_info("\n"); | |
9f8f2064 JA |
548 | } |
549 | ||
550 | /* | |
551 | * now free the list | |
552 | */ | |
01743ee1 JA |
553 | flist_for_each_safe(entry, next, &disk_list) { |
554 | flist_del(entry); | |
555 | du = flist_entry(entry, struct disk_util, list); | |
c97bd0fa | 556 | disk_util_free(du); |
9f8f2064 JA |
557 | } |
558 | } |