IB/sa_query: Fix AH leak due to update_sm_ah() race
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Tue, 3 Mar 2009 22:30:01 +0000 (14:30 -0800)
committerRoland Dreier <rolandd@cisco.com>
Tue, 3 Mar 2009 22:30:01 +0000 (14:30 -0800)
Our testing uncovered a race condition in ib_sa_event():

spin_lock_irqsave(&port->ah_lock, flags);
if (port->sm_ah)
kref_put(&port->sm_ah->ref, free_sm_ah);
port->sm_ah = NULL;
spin_unlock_irqrestore(&port->ah_lock, flags);

schedule_work(&sa_dev->port[event->element.port_num -
    sa_dev->start_port].update_task);

If two events occur back-to-back (e.g., client-reregister and LID
change), both may pass the spinlock-protected code above before the
scheduled work updates the port->sm_ah handle.  Then if the scheduled
work ends up running twice, the second operation will then find a
non-NULL port->sm_ah, and will simply overwrite it in update_sm_ah --
resulting in an AH leak.

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/sa_query.c

index 7863a50d56f25cd8a465fcff0b4ebef6581a675f..1865049e80f7548be1c814e6a9bfc73229f5195a 100644 (file)
@@ -395,6 +395,8 @@ static void update_sm_ah(struct work_struct *work)
        }
 
        spin_lock_irq(&port->ah_lock);
+       if (port->sm_ah)
+               kref_put(&port->sm_ah->ref, free_sm_ah);
        port->sm_ah = new_ah;
        spin_unlock_irq(&port->ah_lock);