ALSA: pcm: Unexport snd_pcm_sgbuf_ops_page
authorTakashi Iwai <tiwai@suse.de>
Fri, 8 Nov 2019 09:46:41 +0000 (10:46 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 9 Nov 2019 17:02:53 +0000 (18:02 +0100)
The helper is no longer referred after the recent code refactoring.
Drop the export for saving some bits and future misuse.

Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20191108094641.20086-9-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/pcm.h
sound/core/pcm_local.h
sound/core/pcm_memory.c

index bbe6eb1ff5d2290e116a08b1bff5d186240ba39d..2c0aa884f5f1188d724ba6f9a8df50bd1701ad45 100644 (file)
@@ -1236,14 +1236,6 @@ static inline int snd_pcm_lib_alloc_vmalloc_32_buffer
  */
 #define snd_pcm_substream_sgbuf(substream) \
        snd_pcm_get_dma_buf(substream)->private_data
-
-struct page *snd_pcm_sgbuf_ops_page(struct snd_pcm_substream *substream,
-                                   unsigned long offset);
-#else /* !SND_DMA_SGBUF */
-/*
- * fake using a continuous buffer
- */
-#define snd_pcm_sgbuf_ops_page NULL
 #endif /* SND_DMA_SGBUF */
 
 /**
index 1161ab2d6a5bae6fc41ca5e5faab388ae7f687fe..5565e1c4196a0c0f3c991fdc2f0cecf041e3be3a 100644 (file)
@@ -67,4 +67,9 @@ static inline void snd_pcm_timer_done(struct snd_pcm_substream *substream) {}
 void __snd_pcm_xrun(struct snd_pcm_substream *substream);
 void snd_pcm_group_init(struct snd_pcm_group *group);
 
+#ifdef CONFIG_SND_DMA_SGBUF
+struct page *snd_pcm_sgbuf_ops_page(struct snd_pcm_substream *substream,
+                                   unsigned long offset);
+#endif
+
 #endif /* __SOUND_CORE_PCM_LOCAL_H */
index 17ee361ce791ec784a69ffc1428537011a45945f..286f333f8e4cd6334e2ce92c072884c79ed8350c 100644 (file)
@@ -255,7 +255,7 @@ void snd_pcm_lib_preallocate_pages_for_all(struct snd_pcm *pcm,
 EXPORT_SYMBOL(snd_pcm_lib_preallocate_pages_for_all);
 
 #ifdef CONFIG_SND_DMA_SGBUF
-/**
+/*
  * snd_pcm_sgbuf_ops_page - get the page struct at the given offset
  * @substream: the pcm substream instance
  * @offset: the buffer offset
@@ -273,7 +273,6 @@ struct page *snd_pcm_sgbuf_ops_page(struct snd_pcm_substream *substream, unsigne
                return NULL;
        return sgbuf->page_table[idx];
 }
-EXPORT_SYMBOL(snd_pcm_sgbuf_ops_page);
 #endif /* CONFIG_SND_DMA_SGBUF */
 
 /**