scsi: qla2xxx: correctly shift host byte
authorJohannes Thumshirn <jthumshirn@suse.de>
Mon, 9 Apr 2018 12:24:23 +0000 (14:24 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 10 Apr 2018 01:04:36 +0000 (21:04 -0400)
The SCSI host byte has to be shifted by 16 not 6.

As Bart pointed out this patch does not change any functionality because
DID_OK == 0, but a wrong shift is irritating for the reviewer.

Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_isr.c

index 7cacdc3408fa02712e6c58085a590441f03b9963..a47a582b039713072f93dafbd25651b0fc6ddd15 100644 (file)
@@ -2347,7 +2347,7 @@ done:
        bsg_job->reply_len = sizeof(struct fc_bsg_reply);
        /* Always return DID_OK, bsg will send the vendor specific response
         * in this case only */
-       sp->done(sp, DID_OK << 6);
+       sp->done(sp, DID_OK << 16);
 
 }