RDMA/nes: Pass correct size to ioremap_nocache()
authorJulia Lawall <julia@diku.dk>
Wed, 9 Dec 2009 23:21:57 +0000 (15:21 -0800)
committerRoland Dreier <rolandd@cisco.com>
Wed, 9 Dec 2009 23:21:57 +0000 (15:21 -0800)
The size argument to ioremap_nocache should be the size of desired
information, not the pointer to it.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression *x;
@@

x =
 <+...
*sizeof(x)
...+>// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Chien Tung <chien.tin.tung@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/nes/nes.c

index 88d31148cb36569d44e474057795a74d9b6a15b3..b9d09bafd6c132d6e052fb585e8329145bfa44ae 100644 (file)
@@ -521,7 +521,8 @@ static int __devinit nes_probe(struct pci_dev *pcidev, const struct pci_device_i
        spin_lock_init(&nesdev->indexed_regs_lock);
 
        /* Remap the PCI registers in adapter BAR0 to kernel VA space */
-       mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0), sizeof(mmio_regs));
+       mmio_regs = ioremap_nocache(pci_resource_start(pcidev, BAR_0),
+                                   pci_resource_len(pcidev, BAR_0));
        if (mmio_regs == NULL) {
                printk(KERN_ERR PFX "Unable to remap BAR0\n");
                ret = -EIO;