procfs: Use vtime aware kcpustat accessor to fetch CPUTIME_SYSTEM
authorFrederic Weisbecker <frederic@kernel.org>
Wed, 16 Oct 2019 02:56:58 +0000 (04:56 +0200)
committerIngo Molnar <mingo@kernel.org>
Tue, 29 Oct 2019 09:01:17 +0000 (10:01 +0100)
Now that we have a vtime safe kcpustat accessor for CPUTIME_SYSTEM, use
it to start fixing frozen kcpustat values on nohz_full CPUs.

Reported-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J . Wysocki <rjw@rjwysocki.net>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Wanpeng Li <wanpengli@tencent.com>
Link: https://lkml.kernel.org/r/20191016025700.31277-13-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
fs/proc/stat.c

index 80c305f206bba89a9cb1e6b72074fdf9e1d0e713..5c6bd0ae38022374d6bb1908ac1ccc05603b3e39 100644 (file)
@@ -124,7 +124,7 @@ static int show_stat(struct seq_file *p, void *v)
 
                user += kcs->cpustat[CPUTIME_USER];
                nice += kcs->cpustat[CPUTIME_NICE];
-               system += kcs->cpustat[CPUTIME_SYSTEM];
+               system += kcpustat_field(kcs, CPUTIME_SYSTEM, i);
                idle += get_idle_time(kcs, i);
                iowait += get_iowait_time(kcs, i);
                irq += kcs->cpustat[CPUTIME_IRQ];
@@ -162,7 +162,7 @@ static int show_stat(struct seq_file *p, void *v)
                /* Copy values here to work around gcc-2.95.3, gcc-2.96 */
                user = kcs->cpustat[CPUTIME_USER];
                nice = kcs->cpustat[CPUTIME_NICE];
-               system = kcs->cpustat[CPUTIME_SYSTEM];
+               system = kcpustat_field(kcs, CPUTIME_SYSTEM, i);
                idle = get_idle_time(kcs, i);
                iowait = get_iowait_time(kcs, i);
                irq = kcs->cpustat[CPUTIME_IRQ];