RDMA/hns: Modify qp will return errno when qp type is illegal
authorLijun Ou <oulijun@huawei.com>
Mon, 30 Jul 2018 12:20:28 +0000 (20:20 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 31 Jul 2018 02:42:44 +0000 (20:42 -0600)
Set for ret was missing in the error path here, resulting in incorrect
error code for modify_qp.

Signed-off-by: Lijun Ou <oulijun@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_hw_v2.c

index b4958422af940562d77dc8b85c2baeb8e9396aff..39842ece3c0f7a62e3a01ec9b91e64c438d53adc 100644 (file)
@@ -3447,6 +3447,7 @@ static int hns_roce_v2_modify_qp(struct ib_qp *ibqp,
                ;
        } else {
                dev_err(dev, "Illegal state for QP!\n");
+               ret = -EINVAL;
                goto out;
        }