cpufreq: Replace double NOT (!!) with single NOT (!)
authorViresh Kumar <viresh.kumar@linaro.org>
Thu, 14 Feb 2019 10:46:21 +0000 (16:16 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 14 Feb 2019 11:06:38 +0000 (12:06 +0100)
Double NOT (!!) operation is normally done to convert a non-zero value
to 1 and keep zero as is, but that isn't the requirement in this case.
All we wanted was to make sure that only one of the two routines isn't
set, i.e. either both function pointers are set or both are unset.

This can be done with a single NOT (!) operation as well.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/cpufreq.c

index 55e9795801a49e63f24d4098ebe8a46efd89149c..ad4e9991c3ccbfbd5b5320ba663a48c16c0b1908 100644 (file)
@@ -2505,7 +2505,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
                    driver_data->target) ||
             (driver_data->setpolicy && (driver_data->target_index ||
                    driver_data->target)) ||
-            (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||
+            (!driver_data->get_intermediate != !driver_data->target_intermediate) ||
             (!driver_data->online != !driver_data->offline))
                return -EINVAL;