drm/amdgpu/powerplay/smu7: fix AVFS handling with custom powerplay table
authorAlex Deucher <alexander.deucher@amd.com>
Fri, 8 Nov 2019 16:15:17 +0000 (11:15 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 11 Nov 2019 22:38:13 +0000 (17:38 -0500)
When a custom powerplay table is provided, we need to update
the OD VDDC flag to avoid AVFS being enabled when it shouldn't be.

Bug: https://bugzilla.kernel.org/show_bug.cgi?id=205393
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c

index c805c6fcdba202f8dc14acd1420a059d2dbc1253..390e7524bef444143cdae0465b8a5726cb8407de 100644 (file)
@@ -3969,6 +3969,13 @@ static int smu7_set_power_state_tasks(struct pp_hwmgr *hwmgr, const void *input)
                        "Failed to populate and upload SCLK MCLK DPM levels!",
                        result = tmp_result);
 
+       /*
+        * If a custom pp table is loaded, set DPMTABLE_OD_UPDATE_VDDC flag.
+        * That effectively disables AVFS feature.
+        */
+       if (hwmgr->hardcode_pp_table != NULL)
+               data->need_update_smu7_dpm_table |= DPMTABLE_OD_UPDATE_VDDC;
+
        tmp_result = smu7_update_avfs(hwmgr);
        PP_ASSERT_WITH_CODE((0 == tmp_result),
                        "Failed to update avfs voltages!",