ALSA: drivers: Remove superfluous snd_dma_continuous_data()
authorTakashi Iwai <tiwai@suse.de>
Tue, 5 Nov 2019 15:18:33 +0000 (16:18 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Nov 2019 14:47:41 +0000 (15:47 +0100)
The recent change (commit 08422d2c559d: "ALSA: memalloc: Allow NULL
device for SNDRV_DMA_TYPE_CONTINUOUS type") made the PCM preallocation
helper accepting NULL as the device pointer for the default usage.
Drop the snd_dma_continuous_data() usage that became superfluous from
the callers.

Link: https://lore.kernel.org/r/20191105151856.10785-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/dummy.c
sound/drivers/ml403-ac97cr.c
sound/drivers/pcsp/pcsp_lib.c

index aee7c04d49e524679d694e37709b680e2cb03e11..022a0db692e0153eb1eb42d1528fba932cf7aac6 100644 (file)
@@ -702,7 +702,7 @@ static int snd_card_dummy_pcm(struct snd_dummy *dummy, int device,
        if (!fake_buffer) {
                snd_pcm_lib_preallocate_pages_for_all(pcm,
                        SNDRV_DMA_TYPE_CONTINUOUS,
-                       snd_dma_continuous_data(GFP_KERNEL),
+                       NULL,
                        0, 64*1024);
        }
        return 0;
index a3c1c064d1b533bbef038f6437180ade5fc73b5d..70a6d1832698f9b2cfe20e0cf73f9a631e4e2639 100644 (file)
@@ -1242,7 +1242,7 @@ snd_ml403_ac97cr_pcm(struct snd_ml403_ac97cr *ml403_ac97cr, int device)
        ml403_ac97cr->pcm = pcm;
 
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
-                                         snd_dma_continuous_data(GFP_KERNEL),
+                                         NULL,
                                          64 * 1024,
                                          128 * 1024);
        return 0;
index 8f0f05bbc0819e7f187975e6a1c4ddd4c4672f4c..f91316bf01cb0c8ef69a6683a1d00f301249c30d 100644 (file)
@@ -352,8 +352,8 @@ int snd_pcsp_new_pcm(struct snd_pcsp *chip)
 
        snd_pcm_lib_preallocate_pages_for_all(chip->pcm,
                                              SNDRV_DMA_TYPE_CONTINUOUS,
-                                             snd_dma_continuous_data
-                                             (GFP_KERNEL), PCSP_BUFFER_SIZE,
+                                             NULL,
+                                             PCSP_BUFFER_SIZE,
                                              PCSP_BUFFER_SIZE);
 
        return 0;