workqueue: Use lockdep to assert IRQs are disabled/enabled
authorFrederic Weisbecker <frederic@kernel.org>
Mon, 6 Nov 2017 15:01:19 +0000 (16:01 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 8 Nov 2017 10:13:48 +0000 (11:13 +0100)
Use lockdep to check that IRQs are enabled or disabled as expected. This
way the sanity check only shows overhead when concurrency correctness
debug code is enabled.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Tejun Heo <tj@kernel.org>
Cc: David S . Miller <davem@davemloft.net>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1509980490-4285-4-git-send-email-frederic@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/workqueue.c

index 1070b21ba4aa764cde49810130fa8084c690e61e..13f67b5a0a0cb932922ed88cbb806c749789fa64 100644 (file)
@@ -1376,7 +1376,7 @@ static void __queue_work(int cpu, struct workqueue_struct *wq,
         * queued or lose PENDING.  Grabbing PENDING and queueing should
         * happen with IRQ disabled.
         */
-       WARN_ON_ONCE(!irqs_disabled());
+       lockdep_assert_irqs_disabled();
 
        debug_work_activate(work);