perf: Humanize lock flags in perf lock
authorFrederic Weisbecker <fweisbec@gmail.com>
Wed, 5 May 2010 21:57:25 +0000 (23:57 +0200)
committerFrederic Weisbecker <fweisbec@gmail.com>
Sun, 9 May 2010 11:45:27 +0000 (13:45 +0200)
Use an enum instead of plain constants for lock flags.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
tools/perf/builtin-lock.c

index 1e93179c2d3020593059723d31599900d29c7420..3b304ed4d2e9e44b93c9668bc0441677cdb1792e 100644 (file)
@@ -397,6 +397,11 @@ enum broken_state {
 
 static int bad_hist[BROKEN_MAX];
 
+enum acquire_flags {
+       TRY_LOCK = 1,
+       READ_LOCK = 2,
+};
+
 static void
 report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                        struct event *__event __used,
@@ -421,9 +426,9 @@ report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                if (!acquire_event->flag) {
                        seq->state = SEQ_STATE_ACQUIRING;
                } else {
-                       if (acquire_event->flag & 1)
+                       if (acquire_event->flag & TRY_LOCK)
                                ls->nr_trylock++;
-                       if (acquire_event->flag & 2)
+                       if (acquire_event->flag & READ_LOCK)
                                ls->nr_readlock++;
                        seq->state = SEQ_STATE_READ_ACQUIRED;
                        seq->read_count = 1;
@@ -431,7 +436,7 @@ report_lock_acquire_event(struct trace_acquire_event *acquire_event,
                }
                break;
        case SEQ_STATE_READ_ACQUIRED:
-               if (acquire_event->flag & 2) {
+               if (acquire_event->flag & READ_LOCK) {
                        seq->read_count++;
                        ls->nr_acquired++;
                        goto end;