loop: Make user notify for adding loop device failed
authorMinfei Huang <mnghuan@gmail.com>
Tue, 7 Jun 2016 02:05:15 +0000 (10:05 +0800)
committerJens Axboe <axboe@fb.com>
Tue, 12 Jul 2016 23:17:18 +0000 (16:17 -0700)
There is no error number returned if loop driver fails in function
alloc_disk to add new loop device. Add a correct error number to make
user notify in this case.

Signed-off-by: Minfei Huang <mnghuan@gmail.com>
Reviewed-by: Ming Lei <tom.leiming@gmail.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/loop.c

index 364d491d4bdd4643d93329c57ea3589bc7840ddc..075377eee0c0bcafed761e4034ab69e17ef9d5b8 100644 (file)
@@ -1765,6 +1765,7 @@ static int loop_add(struct loop_device **l, int i)
         */
        queue_flag_set_unlocked(QUEUE_FLAG_NOMERGES, lo->lo_queue);
 
+       err = -ENOMEM;
        disk = lo->lo_disk = alloc_disk(1 << part_shift);
        if (!disk)
                goto out_free_queue;