MIPS: mipsregs.h: Make read_c0_prid use const accessor
authorJames Hogan <jhogan@kernel.org>
Mon, 11 Dec 2017 16:13:15 +0000 (16:13 +0000)
committerJames Hogan <jhogan@kernel.org>
Tue, 9 Jan 2018 22:26:45 +0000 (22:26 +0000)
Make read_c0_prid() use the new constant accessor macros so that it can
potentially be optimised or removed by the compiler. This is
particularly important under virtualisation, where even with hardware
assisted virtualisation (VZ), access to the PRid register may need to be
emulated by the hypervisor.

In particular this helps eliminate the read of the PRid register in the
rather frequently called add_interrupt_randomness() (which calls into
arch/mips/include/asm/timex.h) when the prid is unused but the read
can't be removed due to the inline asm being marked __volatile__.

Reported-by: Yann LeDu <Yann.LeDu@imgtec.com>
Signed-off-by: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Maciej W. Rozycki <macro@mips.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/17923/

arch/mips/include/asm/mipsregs.h

index 9c409f2d89e69871539c6091e71003fba39d7552..7a59ad6e7f7d9d7e21a9ea727c38d4b2fb95dbc7 100644 (file)
@@ -1558,7 +1558,7 @@ do {                                                                      \
 #define read_c0_epc()          __read_ulong_c0_register($14, 0)
 #define write_c0_epc(val)      __write_ulong_c0_register($14, 0, val)
 
-#define read_c0_prid()         __read_32bit_c0_register($15, 0)
+#define read_c0_prid()         __read_const_32bit_c0_register($15, 0)
 
 #define read_c0_cmgcrbase()    __read_ulong_c0_register($15, 3)