trace: introduce missing mutex_unlock()
authorVegard Nossum <vegard.nossum@gmail.com>
Tue, 18 Nov 2008 18:22:13 +0000 (19:22 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 18 Nov 2008 20:37:15 +0000 (21:37 +0100)
Impact: fix tracing buffer mutex leak in case of allocation failure

This error was spotted by this semantic patch:

  http://www.emn.fr/x-info/coccinelle/mut.html

It looks correct as far as I can tell. Please review.

Signed-off-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/ring_buffer.c

index 036456cbb4f7e1ceecf929e37ed6de581866abda..f780e9552f913e5b9674a218b148f27364e82723 100644 (file)
@@ -617,6 +617,7 @@ int ring_buffer_resize(struct ring_buffer *buffer, unsigned long size)
                list_del_init(&page->list);
                free_buffer_page(page);
        }
+       mutex_unlock(&buffer->mutex);
        return -ENOMEM;
 }