lightnvm: fix "warning: ‘ret’ may be used uninitialized"
authorJeff Mahoney <jeffm@suse.com>
Fri, 6 May 2016 18:02:54 +0000 (20:02 +0200)
committerJens Axboe <axboe@fb.com>
Fri, 6 May 2016 18:51:10 +0000 (12:51 -0600)
This fixes the following warnings:
drivers/lightnvm/sysblk.c:125:9: warning: ‘ret’ may be used
uninitialized in this function

drivers/lightnvm/sysblk.c:275:15: warning: ‘ret’ may be used
uninitialized in this function

In both cases, ret is only set from within a loop that may not be entered.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Matias Bjørling <m@bjorling.me>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/lightnvm/sysblk.c

index 321de1f154c545a31710236f9850ac6ab9deef87..b1e1404e69513230123bd3ecd51dea9eed5f0bcc 100644 (file)
@@ -122,7 +122,7 @@ static int nvm_get_all_sysblks(struct nvm_dev *dev, struct sysblk_scan *s,
                                struct ppa_addr *ppas, nvm_bb_update_fn *fn)
 {
        struct ppa_addr dppa;
-       int i, ret;
+       int i, ret = 0;
 
        s->nr_ppas = 0;
 
@@ -272,7 +272,7 @@ static int nvm_write_and_verify(struct nvm_dev *dev, struct nvm_sb_info *info,
 {
        struct nvm_system_block nvmsb;
        void *buf;
-       int i, sect, ret, bufsz;
+       int i, sect, ret = 0, bufsz;
        struct ppa_addr *ppas;
 
        nvm_cpu_to_sysblk(&nvmsb, info);