arm64: dts: freescale: Add missing cooling device properties for CPUs
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 25 May 2018 05:40:02 +0000 (11:10 +0530)
committerShawn Guo <shawnguo@kernel.org>
Tue, 3 Jul 2018 07:01:09 +0000 (15:01 +0800)
The cooling device properties, like "#cooling-cells" and
"dynamic-power-coefficient", should either be present for all the CPUs
of a cluster or none. If these are present only for a subset of CPUs of
a cluster then things will start falling apart as soon as the CPUs are
brought online in a different order. For example, this will happen
because the operating system looks for such properties in the CPU node
it is trying to bring up, so that it can register a cooling device.

Add such missing properties.

Do minor rearrangement as well to keep ordering consistent.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
arch/arm64/boot/dts/freescale/fsl-ls2088a.dtsi

index 8f7ad1db525fefe8b3960016b84f7c5ae53c5803..b9f5d2ff4ff2934c0f7dcd6037312b6fe2dda4b6 100644 (file)
@@ -43,8 +43,8 @@
                        reg = <0x0>;
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
-                       #cooling-cells = <2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu1: cpu@1 {
@@ -54,6 +54,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu2: cpu@2 {
@@ -63,6 +64,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu3: cpu@3 {
@@ -72,6 +74,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                l2: l2-cache {
index ed76325adffd1dc8337f1d38902b79352f3d245b..65ce1c3cb5684f22698f153df5e212b652ba1eb8 100644 (file)
@@ -50,6 +50,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu2: cpu@2 {
@@ -59,6 +60,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu3: cpu@3 {
@@ -68,6 +70,7 @@
                        clocks = <&clockgen 1 0>;
                        next-level-cache = <&l2>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                l2: l2-cache {
index 292f186c5ee271d67e94fa516de038dfea131651..a07f612ab56b7be9453b80dd50023f1ded9569b9 100644 (file)
@@ -40,6 +40,7 @@
                        reg = <0x1>;
                        clocks = <&clockgen 1 0>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu2: cpu@2 {
@@ -48,6 +49,7 @@
                        reg = <0x2>;
                        clocks = <&clockgen 1 0>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu3: cpu@3 {
@@ -56,6 +58,7 @@
                        reg = <0x3>;
                        clocks = <&clockgen 1 0>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu4: cpu@100 {
@@ -73,6 +76,7 @@
                        reg = <0x101>;
                        clocks = <&clockgen 1 1>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu6: cpu@102 {
@@ -81,6 +85,7 @@
                        reg = <0x102>;
                        clocks = <&clockgen 1 1>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                cpu7: cpu@103 {
@@ -89,6 +94,7 @@
                        reg = <0x103>;
                        clocks = <&clockgen 1 1>;
                        cpu-idle-states = <&CPU_PH20>;
+                       #cooling-cells = <2>;
                };
 
                CPU_PH20: cpu-ph20 {
index 1292ab98ae9bd20a34775d3e0f815203264558e4..f9c1d30cf4a7df64d7e877d6be18fa156d16faa6 100644 (file)
@@ -29,6 +29,7 @@
                clocks = <&clockgen 1 0>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster0_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu2: cpu@100 {
@@ -48,6 +49,7 @@
                clocks = <&clockgen 1 1>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster1_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu4: cpu@200 {
@@ -67,6 +69,7 @@
                clocks = <&clockgen 1 2>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster2_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu6: cpu@300 {
@@ -86,6 +89,7 @@
                clocks = <&clockgen 1 3>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster3_l2>;
+               #cooling-cells = <2>;
        };
 
        cluster0_l2: l2-cache0 {
index d92ea6c11b8e5d8e4aacc517b563bca825eec3bd..7c882da3f6b0e176b9af449705c699322cdf4e0b 100644 (file)
@@ -29,6 +29,7 @@
                clocks = <&clockgen 1 0>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster0_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu2: cpu@100 {
@@ -48,6 +49,7 @@
                clocks = <&clockgen 1 1>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster1_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu4: cpu@200 {
@@ -67,6 +69,7 @@
                clocks = <&clockgen 1 2>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster2_l2>;
+               #cooling-cells = <2>;
        };
 
        cpu6: cpu@300 {
@@ -86,6 +89,7 @@
                clocks = <&clockgen 1 3>;
                cpu-idle-states = <&CPU_PW20>;
                next-level-cache = <&cluster3_l2>;
+               #cooling-cells = <2>;
        };
 
        cluster0_l2: l2-cache0 {