coccinelle: mini_lock: improve performance
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 21 May 2018 06:58:48 +0000 (08:58 +0200)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Tue, 22 May 2018 14:00:23 +0000 (23:00 +0900)
Replace <+... ...+> by ... when any.  <+... ...+> is slow, and in some
obscure cases involving backward jumps it doesn't force the unlock to
actually come after the end of the if.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/coccinelle/locks/mini_lock.cocci

index 47f649b0ea876593353ed045657b2632f17beb72..19c6ee5b986b2019d128142dbfb6ec0f84505000 100644 (file)
@@ -67,12 +67,14 @@ identifier lock,unlock;
 @@
 
 *lock(E1@p,...);
-<+... when != E1
+... when != E1
+    when any
 if (...) {
   ... when != E1
 *  return@r ...;
 }
-...+>
+... when != E1
+    when any
 *unlock@up(E1,...);
 
 @script:python depends on org@