drm: of: simplify component probe code
authorBaruch Siach <baruch@tkos.co.il>
Thu, 22 Feb 2018 19:22:50 +0000 (21:22 +0200)
committerArchit Taneja <archit@cradlewise.com>
Tue, 6 Mar 2018 08:35:00 +0000 (14:05 +0530)
Use positive logic for better readability. This also eliminates one
of_node_put() call, making the code shorter.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Archit Taneja <archit@cradlewise.com>
Link: https://patchwork.freedesktop.org/patch/msgid/61c56895d44117d80e7d82f04e729e29c60fadbd.1519327370.git.baruch@tkos.co.il
drivers/gpu/drm/drm_of.c

index 4c191c050e7dac2093abdbfbbd4e18d1efb182b2..1fe122461298e967997218292610e60d3eb0e999 100644 (file)
@@ -122,12 +122,10 @@ int drm_of_component_probe(struct device *dev,
                if (!port)
                        break;
 
-               if (!of_device_is_available(port->parent)) {
-                       of_node_put(port);
-                       continue;
-               }
+               if (of_device_is_available(port->parent))
+                       drm_of_component_match_add(dev, &match, compare_of,
+                                                  port);
 
-               drm_of_component_match_add(dev, &match, compare_of, port);
                of_node_put(port);
        }