fbdev: pxa3xx-gcu: remove redundant implementation of open()
authorMartin Kepplinger <martink@posteo.de>
Wed, 29 Oct 2014 19:22:57 +0000 (20:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Nov 2014 18:25:52 +0000 (10:25 -0800)
the miscdevice core now does the work in any case.

Signed-off-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/video/fbdev/pxa3xx-gcu.c

index 4df3657fe22114d90a99fb8f8b18a50063e81b3f..7678a94cea7fb5838edd1467ce12123188bff187 100644 (file)
@@ -373,15 +373,6 @@ static inline struct pxa3xx_gcu_priv *to_pxa3xx_gcu_priv(struct file *file)
        return container_of(dev, struct pxa3xx_gcu_priv, misc_dev);
 }
 
-/*
- * provide an empty .open callback, so the core sets file->private_data
- * for us.
- */
-static int pxa3xx_gcu_open(struct inode *inode, struct file *file)
-{
-       return 0;
-}
-
 static ssize_t
 pxa3xx_gcu_write(struct file *file, const char *buff,
                 size_t count, loff_t *offp)
@@ -580,7 +571,6 @@ pxa3xx_gcu_free_buffers(struct device *dev,
 
 static const struct file_operations pxa3xx_gcu_miscdev_fops = {
        .owner =                THIS_MODULE,
-       .open =                 pxa3xx_gcu_open,
        .write =                pxa3xx_gcu_write,
        .unlocked_ioctl =       pxa3xx_gcu_ioctl,
        .mmap =                 pxa3xx_gcu_mmap,