ALSA: pcm: Yet another missing check of non-cached buffer type
authorTakashi Iwai <tiwai@suse.de>
Fri, 8 Nov 2019 16:56:26 +0000 (17:56 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 9 Nov 2019 17:02:11 +0000 (18:02 +0100)
For non-x86 architectures, SNDRV_DMA_TYPE_DEV_UC should be treated
equivalent with SNDRV_DMA_TYPE_DEV, where the default mmap handler
still checks only about SNDRV_DMA_TYPE_DEV.  Make the check more
proper.

Note that all existing users of *_UC buffer types are x86-only, so
this doesn't fix any bug, but just for consistency.

Fixes: 42e748a0b325 ("ALSA: memalloc: Add non-cached buffer type")
Link: https://lore.kernel.org/r/20191108165626.5947-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c

index 998c63192ae4b8b906987c04574518e298abd02d..0c27009dc3df177b1cd87bda8a7d1171e3b35083 100644 (file)
@@ -3416,7 +3416,8 @@ int snd_pcm_lib_default_mmap(struct snd_pcm_substream *substream,
 #endif /* CONFIG_GENERIC_ALLOCATOR */
 #ifndef CONFIG_X86 /* for avoiding warnings arch/x86/mm/pat.c */
        if (IS_ENABLED(CONFIG_HAS_DMA) && !substream->ops->page &&
-           substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV)
+           (substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV ||
+            substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV_UC))
                return dma_mmap_coherent(substream->dma_buffer.dev.dev,
                                         area,
                                         substream->runtime->dma_area,