ARC: mm: do_page_fault refactor #2: remove short lived variable
authorVineet Gupta <vgupta@synopsys.com>
Tue, 14 May 2019 23:07:24 +0000 (16:07 -0700)
committerVineet Gupta <vgupta@synopsys.com>
Mon, 1 Jul 2019 18:02:22 +0000 (11:02 -0700)
Compiler will do this anyways, still..

No functional change.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
arch/arc/mm/fault.c

index be8ea91fcc8b562cfac381f9e6211c30d52165fb..a3a292c58e50be7482ddea1ff5a796e6c0930c53 100644 (file)
@@ -64,23 +64,18 @@ void do_page_fault(unsigned long address, struct pt_regs *regs)
        struct task_struct *tsk = current;
        struct mm_struct *mm = tsk->mm;
        int si_code = SEGV_MAPERR;
-       int ret;
        vm_fault_t fault;
        int write = regs->ecr_cause & ECR_C_PROTV_STORE;  /* ST/EX */
        unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
 
        /*
-        * We fault-in kernel-space virtual memory on-demand. The
-        * 'reference' page table is init_mm.pgd.
-        *
         * NOTE! We MUST NOT take any locks for this case. We may
         * be in an interrupt or a critical region, and should
         * only copy the information from the master page table,
         * nothing more.
         */
        if (address >= VMALLOC_START && !user_mode(regs)) {
-               ret = handle_kernel_vaddr_fault(address);
-               if (unlikely(ret))
+               if (unlikely(handle_kernel_vaddr_fault(address)))
                        goto no_context;
                else
                        return;