ALSA: usb: Remove superfluous snd_dma_continuous_data()
authorTakashi Iwai <tiwai@suse.de>
Tue, 5 Nov 2019 15:18:38 +0000 (16:18 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Nov 2019 14:47:41 +0000 (15:47 +0100)
The recent change (commit 08422d2c559d: "ALSA: memalloc: Allow NULL
device for SNDRV_DMA_TYPE_CONTINUOUS type") made the PCM preallocation
helper accepting NULL as the device pointer for the default usage.
Drop the snd_dma_continuous_data() usage that became superfluous from
the callers.

Link: https://lore.kernel.org/r/20191105151856.10785-7-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/line6/pcm.c
sound/usb/usx2y/usbusx2yaudio.c
sound/usb/usx2y/usx2yhwdeppcm.c

index f70211e6b174fdc18553a222630c58643a7fed34..9c437c716cfd9d679ce610a550a1123e55d922d0 100644 (file)
@@ -502,9 +502,7 @@ static int snd_line6_new_pcm(struct usb_line6 *line6, struct snd_pcm **pcm_ret)
 
        /* pre-allocation of buffers */
        snd_pcm_lib_preallocate_pages_for_all(pcm, SNDRV_DMA_TYPE_CONTINUOUS,
-                                             snd_dma_continuous_data
-                                             (GFP_KERNEL), 64 * 1024,
-                                             128 * 1024);
+                                             NULL, 64 * 1024, 128 * 1024);
        return 0;
 }
 
index 89fa287678fc36cb1e0334f4deac312152ede9de..25a0939f410a74b1e7721abf1e0835a89e5779a9 100644 (file)
@@ -970,13 +970,13 @@ static int usX2Y_audio_stream_new(struct snd_card *card, int playback_endpoint,
        if (playback_endpoint) {
                snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
                                              SNDRV_DMA_TYPE_CONTINUOUS,
-                                             snd_dma_continuous_data(GFP_KERNEL),
+                                             NULL,
                                              64*1024, 128*1024);
        }
 
        snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
                                      SNDRV_DMA_TYPE_CONTINUOUS,
-                                     snd_dma_continuous_data(GFP_KERNEL),
+                                     NULL,
                                      64*1024, 128*1024);
        usX2Y(card)->pcm_devs++;
 
index ac8960b6b2996428371fce15343b8ec0d7f67d1d..997493e839eec61e61913f6857b9637f2e19abbc 100644 (file)
@@ -728,11 +728,11 @@ int usX2Y_hwdep_pcm_new(struct snd_card *card)
        sprintf(pcm->name, NAME_ALLCAPS" hwdep Audio");
        snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream,
                                      SNDRV_DMA_TYPE_CONTINUOUS,
-                                     snd_dma_continuous_data(GFP_KERNEL),
+                                     NULL,
                                      64*1024, 128*1024);
        snd_pcm_lib_preallocate_pages(pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream,
                                      SNDRV_DMA_TYPE_CONTINUOUS,
-                                     snd_dma_continuous_data(GFP_KERNEL),
+                                     NULL,
                                      64*1024, 128*1024);
 
        return 0;