IB/mlx5: Fix leaking stack memory to userspace
authorJason Gunthorpe <jgg@mellanox.com>
Tue, 14 Aug 2018 21:33:52 +0000 (15:33 -0600)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 14 Aug 2018 21:35:12 +0000 (15:35 -0600)
mlx5_ib_create_qp_resp was never initialized and only the first 4 bytes
were written.

Fixes: 41d902cb7c32 ("RDMA/mlx5: Fix definition of mlx5_ib_create_qp_resp")
Cc: <stable@vger.kernel.org>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qp.c

index 351c2efceb355cab1f8b63474d0a835f37308fa2..6cba2a02d11bad71c555b236b9beaae8c29b9cfa 100644 (file)
@@ -1607,7 +1607,7 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd,
        struct mlx5_ib_resources *devr = &dev->devr;
        int inlen = MLX5_ST_SZ_BYTES(create_qp_in);
        struct mlx5_core_dev *mdev = dev->mdev;
-       struct mlx5_ib_create_qp_resp resp;
+       struct mlx5_ib_create_qp_resp resp = {};
        struct mlx5_ib_cq *send_cq;
        struct mlx5_ib_cq *recv_cq;
        unsigned long flags;