libnvdimm/label: Remove the dpa align check
authorAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Thu, 5 Sep 2019 15:46:01 +0000 (21:16 +0530)
committerDan Williams <dan.j.williams@intel.com>
Thu, 5 Sep 2019 23:11:14 +0000 (16:11 -0700)
There's no strict requirement why slot_valid() needs to check for page alignment
and it would seem to actively hurt cross-page-size compatibility. Let's
delete the check and rely on checksum validation.

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Link: https://lore.kernel.org/r/20190905154603.10349-6-aneesh.kumar@linux.ibm.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/label.c

index 73e197babc2ffb27e954234cf2c1aec64b5cb817..47a4828b8b310df76e5a19339cdc0036770182a9 100644 (file)
@@ -353,11 +353,6 @@ static bool slot_valid(struct nvdimm_drvdata *ndd,
        if (slot != __le32_to_cpu(nd_label->slot))
                return false;
 
-       /* check that DPA allocations are page aligned */
-       if ((__le64_to_cpu(nd_label->dpa)
-                               | __le64_to_cpu(nd_label->rawsize)) % SZ_4K)
-               return false;
-
        /* check checksum */
        if (namespace_label_has(ndd, checksum)) {
                u64 sum, sum_save;