projects
/
fio.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
HOWTO/manpage: update percentage explanation using '%'
[fio.git]
/
init.c
diff --git
a/init.c
b/init.c
index c9bf78f6223f00f36ab7c410f46f269464979db3..a4b5adb8e2f30bf7e20100b34db12cd4b8a8a341 100644
(file)
--- a/
init.c
+++ b/
init.c
@@
-356,10
+356,12
@@
static int setup_thread_area(void)
perror("shmat");
return 1;
}
perror("shmat");
return 1;
}
+ if (shm_attach_to_open_removed())
+ shmctl(shm_id, IPC_RMID, NULL);
#endif
memset(threads, 0, max_jobs * sizeof(struct thread_data));
#endif
memset(threads, 0, max_jobs * sizeof(struct thread_data));
- fio_debug_jobp = (
void *) threads + max_jobs * sizeof(struct thread_data
);
+ fio_debug_jobp = (
unsigned int *)(threads + max_jobs
);
*fio_debug_jobp = -1;
flow_init();
*fio_debug_jobp = -1;
flow_init();
@@
-432,8
+434,8
@@
static void copy_opt_list(struct thread_data *dst, struct thread_data *src)
/*
* Return a free job structure.
*/
/*
* Return a free job structure.
*/
-static struct thread_data *get_new_job(
int
global, struct thread_data *parent,
-
int
preserve_eo, const char *jobname)
+static struct thread_data *get_new_job(
bool
global, struct thread_data *parent,
+
bool
preserve_eo, const char *jobname)
{
struct thread_data *td;
{
struct thread_data *td;
@@
-457,6
+459,7
@@
static struct thread_data *get_new_job(int global, struct thread_data *parent,
copy_opt_list(td, parent);
td->io_ops = NULL;
copy_opt_list(td, parent);
td->io_ops = NULL;
+ td->io_ops_init = 0;
if (!preserve_eo)
td->eo = NULL;
if (!preserve_eo)
td->eo = NULL;
@@
-520,7
+523,7
@@
static int __setup_rate(struct thread_data *td, enum fio_ddir ddir)
td->rate_next_io_time[ddir] = 0;
td->rate_io_issue_bytes[ddir] = 0;
td->rate_next_io_time[ddir] = 0;
td->rate_io_issue_bytes[ddir] = 0;
- td->last_usec = 0;
+ td->last_usec
[ddir]
= 0;
return 0;
}
return 0;
}
@@
-564,6
+567,17
@@
static unsigned long long get_rand_start_delay(struct thread_data *td)
return delayrange;
}
return delayrange;
}
+/*
+ * <3 Johannes
+ */
+static unsigned int gcd(unsigned int m, unsigned int n)
+{
+ if (!n)
+ return m;
+
+ return gcd(n, m % n);
+}
+
/*
* Lazy way of fixing up options that depend on each other. We could also
* define option callback handlers, but this is easier.
/*
* Lazy way of fixing up options that depend on each other. We could also
* define option callback handlers, but this is easier.
@@
-573,7
+587,7
@@
static int fixup_options(struct thread_data *td)
struct thread_options *o = &td->o;
int ret = 0;
struct thread_options *o = &td->o;
int ret = 0;
-#ifndef
FIO_HAVE_PSHARED_MUTEX
+#ifndef
CONFIG_PSHARED
if (!o->use_thread) {
log_info("fio: this platform does not support process shared"
" mutexes, forcing use of threads. Use the 'thread'"
if (!o->use_thread) {
log_info("fio: this platform does not support process shared"
" mutexes, forcing use of threads. Use the 'thread'"
@@
-606,7
+620,7
@@
static int fixup_options(struct thread_data *td)
/*
* Reads can do overwrites, we always need to pre-create the file
*/
/*
* Reads can do overwrites, we always need to pre-create the file
*/
- if (td_read(td)
|| td_rw(td)
)
+ if (td_read(td))
o->overwrite = 1;
if (!o->min_bs[DDIR_READ])
o->overwrite = 1;
if (!o->min_bs[DDIR_READ])
@@
-739,10
+753,20
@@
static int fixup_options(struct thread_data *td)
o->verify_interval = o->min_bs[DDIR_WRITE];
else if (td_read(td) && o->verify_interval > o->min_bs[DDIR_READ])
o->verify_interval = o->min_bs[DDIR_READ];
o->verify_interval = o->min_bs[DDIR_WRITE];
else if (td_read(td) && o->verify_interval > o->min_bs[DDIR_READ])
o->verify_interval = o->min_bs[DDIR_READ];
+
+ /*
+ * Verify interval must be a factor or both min and max
+ * write size
+ */
+ if (o->verify_interval % o->min_bs[DDIR_WRITE] ||
+ o->verify_interval % o->max_bs[DDIR_WRITE])
+ o->verify_interval = gcd(o->min_bs[DDIR_WRITE],
+ o->max_bs[DDIR_WRITE]);
}
if (o->pre_read) {
}
if (o->pre_read) {
- o->invalidate_cache = 0;
+ if (o->invalidate_cache)
+ o->invalidate_cache = 0;
if (td_ioengine_flagged(td, FIO_PIPEIO)) {
log_info("fio: cannot pre-read files with an IO engine"
" that isn't seekable. Pre-read disabled.\n");
if (td_ioengine_flagged(td, FIO_PIPEIO)) {
log_info("fio: cannot pre-read files with an IO engine"
" that isn't seekable. Pre-read disabled.\n");
@@
-885,9
+909,9
@@
void td_fill_verify_state_seed(struct thread_data *td)
bool use64;
if (td->o.random_generator == FIO_RAND_GEN_TAUSWORTHE64)
bool use64;
if (td->o.random_generator == FIO_RAND_GEN_TAUSWORTHE64)
- use64 =
1
;
+ use64 =
true
;
else
else
- use64 =
0
;
+ use64 =
false
;
init_rand_seed(&td->verify_state, td->rand_seeds[FIO_RAND_VER_OFF],
use64);
init_rand_seed(&td->verify_state, td->rand_seeds[FIO_RAND_VER_OFF],
use64);
@@
-909,7
+933,9
@@
static void td_fill_rand_seeds_internal(struct thread_data *td, bool use64)
init_rand_seed(&td->file_size_state, td->rand_seeds[FIO_RAND_FILE_SIZE_OFF], use64);
init_rand_seed(&td->trim_state, td->rand_seeds[FIO_RAND_TRIM_OFF], use64);
init_rand_seed(&td->delay_state, td->rand_seeds[FIO_RAND_START_DELAY], use64);
init_rand_seed(&td->file_size_state, td->rand_seeds[FIO_RAND_FILE_SIZE_OFF], use64);
init_rand_seed(&td->trim_state, td->rand_seeds[FIO_RAND_TRIM_OFF], use64);
init_rand_seed(&td->delay_state, td->rand_seeds[FIO_RAND_START_DELAY], use64);
- init_rand_seed(&td->poisson_state, td->rand_seeds[FIO_RAND_POISSON_OFF], 0);
+ init_rand_seed(&td->poisson_state[0], td->rand_seeds[FIO_RAND_POISSON_OFF], 0);
+ init_rand_seed(&td->poisson_state[1], td->rand_seeds[FIO_RAND_POISSON2_OFF], 0);
+ init_rand_seed(&td->poisson_state[2], td->rand_seeds[FIO_RAND_POISSON3_OFF], 0);
init_rand_seed(&td->dedupe_state, td->rand_seeds[FIO_DEDUPE_OFF], false);
init_rand_seed(&td->zone_state, td->rand_seeds[FIO_RAND_ZONE_OFF], false);
init_rand_seed(&td->dedupe_state, td->rand_seeds[FIO_DEDUPE_OFF], false);
init_rand_seed(&td->zone_state, td->rand_seeds[FIO_RAND_ZONE_OFF], false);
@@
-941,9
+967,9
@@
void td_fill_rand_seeds(struct thread_data *td)
}
if (td->o.random_generator == FIO_RAND_GEN_TAUSWORTHE64)
}
if (td->o.random_generator == FIO_RAND_GEN_TAUSWORTHE64)
- use64 =
1
;
+ use64 =
true
;
else
else
- use64 =
0
;
+ use64 =
false
;
td_fill_rand_seeds_internal(td, use64);
td_fill_rand_seeds_internal(td, use64);
@@
-1000,7
+1026,7
@@
int ioengine_load(struct thread_data *td)
*/
if (origeo) {
memcpy(td->eo, origeo, td->io_ops->option_struct_size);
*/
if (origeo) {
memcpy(td->eo, origeo, td->io_ops->option_struct_size);
- options_mem_dupe(td->
eo, td->io_ops->options
);
+ options_mem_dupe(td->
io_ops->options, td->eo
);
} else {
memset(td->eo, 0, td->io_ops->option_struct_size);
fill_default_options(td->eo, td->io_ops->options);
} else {
memset(td->eo, 0, td->io_ops->option_struct_size);
fill_default_options(td->eo, td->io_ops->options);
@@
-1044,6
+1070,9
@@
static void init_flags(struct thread_data *td)
if (o->verify_async || o->io_submit_mode == IO_MODE_OFFLOAD)
td->flags |= TD_F_NEED_LOCK;
if (o->verify_async || o->io_submit_mode == IO_MODE_OFFLOAD)
td->flags |= TD_F_NEED_LOCK;
+
+ if (o->mem_type == MEM_CUDA_MALLOC)
+ td->flags &= ~TD_F_SCRAMBLE_BUFFERS;
}
static int setup_random_seeds(struct thread_data *td)
}
static int setup_random_seeds(struct thread_data *td)
@@
-1051,8
+1080,12
@@
static int setup_random_seeds(struct thread_data *td)
unsigned long seed;
unsigned int i;
unsigned long seed;
unsigned int i;
- if (!td->o.rand_repeatable && !fio_option_is_set(&td->o, rand_seed))
- return init_random_state(td, td->rand_seeds, sizeof(td->rand_seeds));
+ if (!td->o.rand_repeatable && !fio_option_is_set(&td->o, rand_seed)) {
+ int ret = init_random_seeds(td->rand_seeds, sizeof(td->rand_seeds));
+ if (!ret)
+ td_fill_rand_seeds(td);
+ return ret;
+ }
seed = td->o.rand_seed;
for (i = 0; i < 4; i++)
seed = td->o.rand_seed;
for (i = 0; i < 4; i++)
@@
-1094,7
+1127,7
@@
static char *make_filename(char *buf, size_t buf_size,struct thread_options *o,
if (!o->filename_format || !strlen(o->filename_format)) {
sprintf(buf, "%s.%d.%d", jobname, jobnum, filenum);
if (!o->filename_format || !strlen(o->filename_format)) {
sprintf(buf, "%s.%d.%d", jobname, jobnum, filenum);
- return
NULL
;
+ return
buf
;
}
for (f = &fpre_keywords[0]; f->keyword; f++)
}
for (f = &fpre_keywords[0]; f->keyword; f++)
@@
-1331,6
+1364,7
@@
static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
td->ts.slat_stat[i].min_val = ULONG_MAX;
td->ts.lat_stat[i].min_val = ULONG_MAX;
td->ts.bw_stat[i].min_val = ULONG_MAX;
td->ts.slat_stat[i].min_val = ULONG_MAX;
td->ts.lat_stat[i].min_val = ULONG_MAX;
td->ts.bw_stat[i].min_val = ULONG_MAX;
+ td->ts.iops_stat[i].min_val = ULONG_MAX;
}
td->ddir_seq_nr = o->ddir_seq_nr;
}
td->ddir_seq_nr = o->ddir_seq_nr;
@@
-1347,7
+1381,7
@@
static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
prev_group_jobs++;
if (setup_random_seeds(td)) {
prev_group_jobs++;
if (setup_random_seeds(td)) {
- td_verror(td, errno, "
init_random_state
");
+ td_verror(td, errno, "
setup_random_seeds
");
goto err;
}
goto err;
}
@@
-1508,10
+1542,10
@@
static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
ddir_str(o->td_ddir));
if (o->bs_is_seq_rand)
ddir_str(o->td_ddir));
if (o->bs_is_seq_rand)
- log_info("bs=
%s-%s,
%s-%s, bs_is_seq_rand, ",
+ log_info("bs=
(R) %s-%s, (W)
%s-%s, bs_is_seq_rand, ",
c1, c2, c3, c4);
else
c1, c2, c3, c4);
else
- log_info("bs=
%s-%s,%s-%s,
%s-%s, ",
+ log_info("bs=
(R) %s-%s, (W) %s-%s, (T)
%s-%s, ",
c1, c2, c3, c4, c5, c6);
log_info("ioengine=%s, iodepth=%u\n",
c1, c2, c3, c4, c5, c6);
log_info("ioengine=%s, iodepth=%u\n",
@@
-1537,7
+1571,7
@@
static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
*/
numjobs = o->numjobs;
while (--numjobs) {
*/
numjobs = o->numjobs;
while (--numjobs) {
- struct thread_data *td_new = get_new_job(
0, td, 1
, jobname);
+ struct thread_data *td_new = get_new_job(
false, td, true
, jobname);
if (!td_new)
goto err;
if (!td_new)
goto err;
@@
-1598,11
+1632,11
@@
void add_job_opts(const char **o, int client_type)
sprintf(jobname, "%s", o[i] + 5);
}
if (in_global && !td_parent)
sprintf(jobname, "%s", o[i] + 5);
}
if (in_global && !td_parent)
- td_parent = get_new_job(
1, &def_thread, 0
, jobname);
+ td_parent = get_new_job(
true, &def_thread, false
, jobname);
else if (!in_global && !td) {
if (!td_parent)
td_parent = &def_thread;
else if (!in_global && !td) {
if (!td_parent)
td_parent = &def_thread;
- td = get_new_job(
0, td_parent, 0
, jobname);
+ td = get_new_job(
false, td_parent, false
, jobname);
}
if (in_global)
fio_options_parse(td_parent, (char **) &o[i], 1);
}
if (in_global)
fio_options_parse(td_parent, (char **) &o[i], 1);
@@
-1654,7
+1688,7
@@
static int __parse_jobs_ini(struct thread_data *td,
char *file, int is_buf, int stonewall_flag, int type,
int nested, char *name, char ***popts, int *aopts, int *nopts)
{
char *file, int is_buf, int stonewall_flag, int type,
int nested, char *name, char ***popts, int *aopts, int *nopts)
{
-
unsigned int global = 0
;
+
bool global = false
;
char *string;
FILE *f;
char *p;
char *string;
FILE *f;
char *p;
@@
-1763,7
+1797,7
@@
static int __parse_jobs_ini(struct thread_data *td,
first_sect = 0;
}
first_sect = 0;
}
- td = get_new_job(global, &def_thread,
0
, name);
+ td = get_new_job(global, &def_thread,
false
, name);
if (!td) {
ret = 1;
break;
if (!td) {
ret = 1;
break;
@@
-1988,7
+2022,7
@@
static void usage(const char *name)
printf(" --version\t\tPrint version info and exit\n");
printf(" --help\t\tPrint this page\n");
printf(" --cpuclock-test\tPerform test/validation of CPU clock\n");
printf(" --version\t\tPrint version info and exit\n");
printf(" --help\t\tPrint this page\n");
printf(" --cpuclock-test\tPerform test/validation of CPU clock\n");
- printf(" --crctest=
type
\tTest speed of checksum functions\n");
+ printf(" --crctest=
[type]
\tTest speed of checksum functions\n");
printf(" --cmdhelp=cmd\t\tPrint command help, \"all\" for all of"
" them\n");
printf(" --enghelp=engine\tPrint ioengine help, or list"
printf(" --cmdhelp=cmd\t\tPrint command help, \"all\" for all of"
" them\n");
printf(" --enghelp=engine\tPrint ioengine help, or list"
@@
-2303,17
+2337,22
@@
int parse_cmd_line(int argc, char *argv[], int client_type)
case 'b':
write_bw_log = 1;
break;
case 'b':
write_bw_log = 1;
break;
- case 'o':
+ case 'o': {
+ FILE *tmp;
+
if (f_out && f_out != stdout)
fclose(f_out);
if (f_out && f_out != stdout)
fclose(f_out);
- f_out = fopen(optarg, "w+");
- if (!f_out) {
- perror("fopen output");
- exit(1);
+ tmp = fopen(optarg, "w+");
+ if (!tmp) {
+ log_err("fio: output file open error: %s\n", strerror(errno));
+ exit_val = 1;
+ do_exit++;
+ break;
}
}
- f_err = f_out;
+ f_err = f_out
= tmp
;
break;
break;
+ }
case 'm':
output_format = FIO_OUTPUT_TERSE;
break;
case 'm':
output_format = FIO_OUTPUT_TERSE;
break;
@@
-2365,8
+2404,7
@@
int parse_cmd_line(int argc, char *argv[], int client_type)
break;
case 'V':
terse_version = atoi(optarg);
break;
case 'V':
terse_version = atoi(optarg);
- if (!(terse_version == 2 || terse_version == 3 ||
- terse_version == 4)) {
+ if (!(terse_version >= 2 && terse_version <= 5)) {
log_err("fio: bad terse version format\n");
exit_val = 1;
do_exit++;
log_err("fio: bad terse version format\n");
exit_val = 1;
do_exit++;
@@
-2447,7
+2485,7
@@
int parse_cmd_line(int argc, char *argv[], int client_type)
if (is_section && skip_this_section(val))
continue;
if (is_section && skip_this_section(val))
continue;
- td = get_new_job(global, &def_thread,
1
, NULL);
+ td = get_new_job(global, &def_thread,
true
, NULL);
if (!td || ioengine_load(td)) {
if (td) {
put_job(td);
if (!td || ioengine_load(td)) {
if (td) {
put_job(td);
@@
-2685,7
+2723,7
@@
int parse_cmd_line(int argc, char *argv[], int client_type)
if (!ret) {
ret = add_job(td, td->o.name ?: "fio", 0, 0, client_type);
if (ret)
if (!ret) {
ret = add_job(td, td->o.name ?: "fio", 0, 0, client_type);
if (ret)
-
did_arg = 1
;
+
exit(1)
;
}
}
}
}
@@
-2697,9
+2735,6
@@
int parse_cmd_line(int argc, char *argv[], int client_type)
}
out_free:
}
out_free:
- if (pid_file)
- free(pid_file);
-
return ini_idx;
}
return ini_idx;
}
@@
-2768,7
+2803,7
@@
int parse_options(int argc, char *argv[])
if (did_arg)
return 0;
if (did_arg)
return 0;
- log_err("No job
s
(s) defined\n\n");
+ log_err("No job(s) defined\n\n");
if (!did_arg) {
usage(argv[0]);
if (!did_arg) {
usage(argv[0]);