gfio: change color of graphs

[fio.git] / gfio.c

diff --git a/gfio.c b/gfio.c
index e190d89ac942ff2e13f82fb65a9776cc0940e527..4d9d73da2ab376d6f7e23b6de5a4c36a3d4726f8 100644 (file)
--- a/gfio.c
+++ b/gfio.c
@@ -121,6 +121,18 @@ struct gfio_client {
        GtkWidget *disk_util_frame;
 };
 
+static void add_invisible_data(struct graph *g)
+{
+       /*
+        * This puts some invisible data into a graph so that it will
+        * initially have some grid lines instead of "No good data"
+        */
+       graph_add_label(g, "invisible");
+       graph_set_color(g, "invisible", INVISIBLE_COLOR, 0.0, 0.7);
+       graph_add_xy_data(g, "invisible", 0.0, 0.0);
+       graph_add_xy_data(g, "invisible", 1.0, 100.0);
+}
+
 static void setup_iops_graph(struct gui *ui)
 {
        if (ui->iops_graph)
@@ -128,12 +140,12 @@ static void setup_iops_graph(struct gui *ui)
        ui->iops_graph = graph_new(DRAWING_AREA_XDIM / 2.0,
                                        DRAWING_AREA_YDIM, gfio_graph_font);
        graph_title(ui->iops_graph, "IOPS");
-       graph_x_title(ui->iops_graph, "Time");
-       graph_y_title(ui->iops_graph, "IOPS");
+       graph_x_title(ui->iops_graph, "Time (secs)");
        graph_add_label(ui->iops_graph, "Read IOPS");
        graph_add_label(ui->iops_graph, "Write IOPS");
-       graph_set_color(ui->iops_graph, "Read IOPS", 0.7, 0.0, 0.0);
-       graph_set_color(ui->iops_graph, "Write IOPS", 0.0, 0.0, 0.7);
+       graph_set_color(ui->iops_graph, "Read IOPS", 0.13, 0.54, 0.13);
+       graph_set_color(ui->iops_graph, "Write IOPS", 1.0, 0.0, 0.0);
+       add_invisible_data(ui->iops_graph);
 }
 
 static void setup_bandwidth_graph(struct gui *ui)
@@ -143,12 +155,12 @@ static void setup_bandwidth_graph(struct gui *ui)
        ui->bandwidth_graph = graph_new(DRAWING_AREA_XDIM / 2.0,
                                        DRAWING_AREA_YDIM, gfio_graph_font);
        graph_title(ui->bandwidth_graph, "Bandwidth");
-       graph_x_title(ui->bandwidth_graph, "Time");
-       graph_y_title(ui->bandwidth_graph, "Bandwidth");
+       graph_x_title(ui->bandwidth_graph, "Time (secs)");
        graph_add_label(ui->bandwidth_graph, "Read Bandwidth");
        graph_add_label(ui->bandwidth_graph, "Write Bandwidth");
-       graph_set_color(ui->bandwidth_graph, "Read Bandwidth", 0.7, 0.0, 0.0);
-       graph_set_color(ui->bandwidth_graph, "Write Bandwidth", 0.0, 0.0, 0.7);
+       graph_set_color(ui->bandwidth_graph, "Read Bandwidth", 0.13, 0.54, 0.13);
+       graph_set_color(ui->bandwidth_graph, "Write Bandwidth", 1.0, 0.0, 0.0);
+       add_invisible_data(ui->bandwidth_graph);
 }
 
 static void clear_ui_info(struct gui *ui)
@@ -901,10 +913,8 @@ static void gfio_disk_util_op(struct fio_client *client, struct fio_net_cmd *cmd
 
        gdk_threads_enter();
 
-       if (!gc->results_widget) {
-               printf("no results!\n");
+       if (!gc->results_widget)
                goto out;
-       }
 
        if (!gc->disk_util_frame) {
                gc->disk_util_frame = gtk_frame_new("Disk utilization");
@@ -1720,8 +1730,6 @@ static void preferences(GtkWidget *w, gpointer data)
        }
 
        gfio_graph_font = strdup(gtk_font_button_get_font_name(GTK_FONT_BUTTON(font)));
-       printf("got font %s\n", gfio_graph_font);
-
        gtk_widget_destroy(dialog);
 }