[fio.git] / goptions.c

#include <locale.h>
#include <malloc.h>
#include <string.h>

#include <glib.h>
#include <cairo.h>
#include <gtk/gtk.h>

#include "fio.h"
#include "gfio.h"
#include "ghelpers.h"
#include "parse.h"

struct gopt {
	GtkWidget *box;
	unsigned int opt_index;
	unsigned int opt_type;
};

struct gopt_combo {
	struct gopt gopt;
	GtkWidget *combo;
};

struct gopt_int {
	struct gopt gopt;
	GtkWidget *spin;
};

struct gopt_bool {
	struct gopt gopt;
	GtkWidget *check;
};

struct gopt_str {
	struct gopt gopt;
	GtkWidget *entry;
};

#define GOPT_RANGE_SPIN	4

struct gopt_range {
	struct gopt gopt;
	GtkWidget *spins[GOPT_RANGE_SPIN];
};

struct gopt_str_multi {
	struct gopt gopt;
	GtkWidget *checks[PARSE_MAX_VP];
};

static GtkWidget *gopt_widgets[FIO_MAX_OPTS];

struct gopt_frame_widget {
	GtkWidget *vbox[2];
	unsigned int nr;
};
static struct gopt_frame_widget gopt_g_widgets[__FIO_OPT_G_NR];

static GtkWidget *gopt_get_group_frame(GtkWidget *box, unsigned int groupmask)
{
	unsigned int mask, group;
	struct opt_group *og;
	GtkWidget *frame, *hbox;
	struct gopt_frame_widget *gfw;

	if (!groupmask)
		return 0;

	mask = groupmask;
	og = opt_group_cat_from_mask(&mask);
	if (!og)
		return NULL;

	group = ffz(~groupmask);
	gfw = &gopt_g_widgets[group];
	if (!gfw->vbox[0]) {
		frame = gtk_frame_new(og->name);
		gtk_box_pack_start(GTK_BOX(box), frame, FALSE, FALSE, 3);
		hbox = gtk_hbox_new(FALSE, 0);
		gtk_container_add(GTK_CONTAINER(frame), hbox);
		gfw->vbox[0] = gtk_vbox_new(TRUE, 5);
		gfw->vbox[1] = gtk_vbox_new(TRUE, 5);
		gtk_box_pack_start(GTK_BOX(hbox), gfw->vbox[0], TRUE, TRUE, 5);
		gtk_box_pack_start(GTK_BOX(hbox), gfw->vbox[1], TRUE, TRUE, 5);
	}

	hbox = gtk_hbox_new(FALSE, 3);
	gtk_box_pack_start(GTK_BOX(gfw->vbox[gfw->nr++ & 1]), hbox, FALSE, FALSE, 5);
	return hbox;
}

/*
 * Mark children as invisible, if needed.
 */
static void gopt_set_children_visible(struct fio_option *parent, gboolean visible)
{
	struct fio_option *o;
	int i;

	/*
	 * This isn't super fast, but it should not be an issue. If it is, we
	 * can speed it up by caching the lookup at least. Or we can do it
	 * once, at init time.
	 */
	for (i = 0; fio_options[i].name; i++) {
		o = &fio_options[i];
		if (!o->parent || !o->hide)
			continue;

		if (strcmp(parent->name, o->parent))
			continue;

		if (gopt_widgets[i])
			gtk_widget_set_sensitive(gopt_widgets[i], visible);
	}
}

static void gopt_str_changed(GtkEntry *entry, gpointer data)
{
	struct gopt_str *s = (struct gopt_str *) data;
	struct fio_option *o = &fio_options[s->gopt.opt_index];
	const gchar *text;
	int set;

	text = gtk_entry_get_text(GTK_ENTRY(s->entry));
	set = strcmp(text, "") != 0;
	gopt_set_children_visible(o, set);
}

static void gopt_mark_index(struct gopt *gopt, unsigned int idx)
{
	assert(!gopt_widgets[idx]);
	gopt->opt_index = idx;
	gopt_widgets[idx] = gopt->box;
}

static struct gopt *gopt_new_str_store(struct fio_option *o, const char *text, unsigned int idx)
{
	struct gopt_str *s;
	GtkWidget *label;

	s = malloc(sizeof(*s));

	s->gopt.box = gtk_hbox_new(FALSE, 3);
	if (!o->lname)
		label = gtk_label_new(o->name);
	else
		label = gtk_label_new(o->lname);

	s->entry = gtk_entry_new();
	gopt_mark_index(&s->gopt, idx);
	if (text)
		gtk_entry_set_text(GTK_ENTRY(s->entry), text);
	gtk_entry_set_editable(GTK_ENTRY(s->entry), 1);
	g_signal_connect(GTK_OBJECT(s->entry), "changed", G_CALLBACK(gopt_str_changed), s);

	if (o->def)
		gtk_entry_set_text(GTK_ENTRY(s->entry), o->def);

	gtk_box_pack_start(GTK_BOX(s->gopt.box), s->entry, FALSE, FALSE, 0);
	gtk_box_pack_start(GTK_BOX(s->gopt.box), label, FALSE, FALSE, 0);
	return &s->gopt;
}

static void gopt_combo_changed(GtkComboBox *box, gpointer data)
{
	struct gopt_combo *c = (struct gopt_combo *) data;
	struct fio_option *o = &fio_options[c->gopt.opt_index];

	printf("combo %s changed\n", o->name);
}

static struct gopt_combo *__gopt_new_combo(struct fio_option *o, unsigned int idx)
{
	struct gopt_combo *c;
	GtkWidget *label;

	c = malloc(sizeof(*c));

	c->gopt.box = gtk_hbox_new(FALSE, 3);
	if (!o->lname)
		label = gtk_label_new(o->name);
	else
		label = gtk_label_new(o->lname);

	c->combo = gtk_combo_box_new_text();
	gopt_mark_index(&c->gopt, idx);
	g_signal_connect(GTK_OBJECT(c->combo), "changed", G_CALLBACK(gopt_combo_changed), c);

	gtk_box_pack_start(GTK_BOX(c->gopt.box), c->combo, FALSE, FALSE, 0);
	gtk_box_pack_start(GTK_BOX(c->gopt.box), label, FALSE, FALSE, 0);

	return c;
}

static struct gopt *gopt_new_combo_str(struct fio_option *o, const char *text, unsigned int idx)
{
	struct gopt_combo *combo;
	struct value_pair *vp;
	int i, active = 0;

	combo = __gopt_new_combo(o, idx);

	i = 0;
	vp = &o->posval[0];
	while (vp->ival) {
		gtk_combo_box_append_text(GTK_COMBO_BOX(combo->combo), vp->ival);
		if (o->def && !strcmp(vp->ival, o->def))
			active = i;
		if (text && !strcmp(vp->ival, text))
			active = i;
		vp++;
		i++;
	}

	gtk_combo_box_set_active(GTK_COMBO_BOX(combo->combo), active);
	return &combo->gopt;
}

static struct gopt *gopt_new_combo_int(struct fio_option *o, unsigned int *ip, unsigned int idx)
{
	struct gopt_combo *combo;
	struct value_pair *vp;
	int i, active = 0;

	combo = __gopt_new_combo(o, idx);

	i = 0;
	vp = &o->posval[0];
	while (vp->ival) {
		gtk_combo_box_append_text(GTK_COMBO_BOX(combo->combo), vp->ival);
		if (ip && vp->oval == *ip)
			active = i;
		vp++;
		i++;
	}

	gtk_combo_box_set_active(GTK_COMBO_BOX(combo->combo), active);
	return &combo->gopt;
}

static struct gopt *gopt_new_str_multi(struct fio_option *o, unsigned int idx)
{
	struct gopt_str_multi *m;
	struct value_pair *vp;
	GtkWidget *frame, *hbox;
	int i;

	m = malloc(sizeof(*m));
	m->gopt.box = gtk_hbox_new(FALSE, 3);
	gopt_mark_index(&m->gopt, idx);

	if (!o->lname)
		frame = gtk_frame_new(o->name);
	else
		frame = gtk_frame_new(o->lname);
	gtk_box_pack_start(GTK_BOX(m->gopt.box), frame, FALSE, FALSE, 3);

	hbox = gtk_hbox_new(FALSE, 3);
	gtk_container_add(GTK_CONTAINER(frame), hbox);

	i = 0;
	vp = &o->posval[0];
	while (vp->ival) {
		m->checks[i] = gtk_check_button_new_with_label(vp->ival);
		gtk_widget_set_tooltip_text(m->checks[i], vp->help);
		gtk_box_pack_start(GTK_BOX(hbox), m->checks[i], FALSE, FALSE, 3);
		vp++;
	}

	return &m->gopt;
}

static void gopt_int_changed(GtkSpinButton *spin, gpointer data)
{
	struct gopt_int *i = (struct gopt_int *) data;
	struct fio_option *o = &fio_options[i->gopt.opt_index];

	printf("int %s changed\n", o->name);
}

static struct gopt_int *__gopt_new_int(struct fio_option *o, unsigned long long *p,
				       unsigned int idx)
{
	unsigned long long defval;
	struct gopt_int *i;
	guint maxval, interval;
	GtkWidget *label;

	i = malloc(sizeof(*i));
	i->gopt.box = gtk_hbox_new(FALSE, 3);
	if (!o->lname)
		label = gtk_label_new(o->name);
	else
		label = gtk_label_new(o->lname);

	maxval = o->maxval;
	if (!maxval)
		maxval = UINT_MAX;

	defval = 0;
	if (p)
		defval = *p;
	else if (o->def) {
		long long val;

		check_str_bytes(o->def, &val, NULL);
		defval = val;
	}

	interval = 1.0;
	if (o->interval)
		interval = o->interval;

	i->spin = gtk_spin_button_new_with_range(o->minval, maxval, interval);
	gopt_mark_index(&i->gopt, idx);
	gtk_spin_button_set_update_policy(GTK_SPIN_BUTTON(i->spin), GTK_UPDATE_IF_VALID);
	gtk_spin_button_set_value(GTK_SPIN_BUTTON(i->spin), defval);
	g_signal_connect(G_OBJECT(i->spin), "value-changed", G_CALLBACK(gopt_int_changed), i);

	gtk_box_pack_start(GTK_BOX(i->gopt.box), i->spin, FALSE, FALSE, 0);
	gtk_box_pack_start(GTK_BOX(i->gopt.box), label, FALSE, FALSE, 0);

	return i;
}

static struct gopt *gopt_new_int(struct fio_option *o, unsigned int *ip, unsigned int idx)
{
	unsigned long long ullp;
	struct gopt_int *i;

	if (ip) {
		ullp = *ip;
		i = __gopt_new_int(o, &ullp, idx);
	} else
		i = __gopt_new_int(o, NULL, idx);

	return &i->gopt;
}

static struct gopt *gopt_new_ullong(struct fio_option *o, unsigned long long *p,
				    unsigned int idx)
{
	struct gopt_int *i;

	i = __gopt_new_int(o, p, idx);
	return &i->gopt;
}

static void gopt_bool_toggled(GtkToggleButton *button, gpointer data)
{
	struct gopt_bool *b = (struct gopt_bool *) data;
	struct fio_option *o = &fio_options[b->gopt.opt_index];
	gboolean set;

	set = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(b->check));
	gopt_set_children_visible(o, set);
}

static struct gopt *gopt_new_bool(struct fio_option *o, unsigned int *val, unsigned int idx)
{
	struct gopt_bool *b;
	GtkWidget *label;
	int defstate = 0;

	b = malloc(sizeof(*b));
	b->gopt.box = gtk_hbox_new(FALSE, 3);
	if (!o->lname)
		label = gtk_label_new(o->name);
	else
		label = gtk_label_new(o->lname);

	b->check = gtk_check_button_new();
	gopt_mark_index(&b->gopt, idx);
	if (val)
		defstate = *val;
	else if (o->def && !strcmp(o->def, "1"))
		defstate = 1;

	if (o->neg)
		defstate = !defstate;

	gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(b->check), defstate);
	g_signal_connect(G_OBJECT(b->check), "toggled", G_CALLBACK(gopt_bool_toggled), b);

	gtk_box_pack_start(GTK_BOX(b->gopt.box), b->check, FALSE, FALSE, 0);
	gtk_box_pack_start(GTK_BOX(b->gopt.box), label, FALSE, FALSE, 0);
	return &b->gopt;
}

/*
 * These are paired 0/1 and 2/3. 0/2 are min values, 1/3 are max values.
 * If the max is made smaller than min, adjust min down.
 * If the min is made larger than max, adjust the max.
 */
static void range_value_changed(GtkSpinButton *spin, gpointer data)
{
	struct gopt_range *r = (struct gopt_range *) data;
	int changed = -1, i;
	gint val, mval;

	for (i = 0; i < GOPT_RANGE_SPIN; i++) {
		if (GTK_SPIN_BUTTON(r->spins[i]) == spin) {
			changed = i;
			break;
		}
	}

	assert(changed != -1);

	/*
	 * Min changed
	 */
	if (changed == 0 || changed == 2) {
		GtkWidget *mspin = r->spins[changed + 1];

		val = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(r->spins[changed]));
		mval = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(mspin));
		if (val > mval)
			gtk_spin_button_set_value(GTK_SPIN_BUTTON(mspin), val);
	} else {
		GtkWidget *mspin = r->spins[changed - 1];

		val = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(r->spins[changed]));
		mval = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(mspin));
		if (val < mval)
			gtk_spin_button_set_value(GTK_SPIN_BUTTON(mspin), val);
	}
}

static struct gopt *gopt_new_int_range(struct fio_option *o, unsigned int **ip,
				       unsigned int idx)
{
	struct gopt_range *r;
	gint maxval, defval;
	GtkWidget *label;
	guint interval;
	int i;

	r = malloc(sizeof(*r));
	r->gopt.box = gtk_hbox_new(FALSE, 3);
	gopt_mark_index(&r->gopt, idx);
	if (!o->lname)
		label = gtk_label_new(o->name);
	else
		label = gtk_label_new(o->lname);

	maxval = o->maxval;
	if (!maxval)
		maxval = INT_MAX;

	defval = 0;
	if (o->def) {
		long long val;

		check_str_bytes(o->def, &val, NULL);
		defval = val;
	}

	interval = 1.0;
	if (o->interval)
		interval = o->interval;

	for (i = 0; i < GOPT_RANGE_SPIN; i++) {
		r->spins[i] = gtk_spin_button_new_with_range(o->minval, maxval, interval);
		gtk_spin_button_set_update_policy(GTK_SPIN_BUTTON(r->spins[i]), GTK_UPDATE_IF_VALID);
		if (ip)
			gtk_spin_button_set_value(GTK_SPIN_BUTTON(r->spins[i]), *ip[i]);
		else
			gtk_spin_button_set_value(GTK_SPIN_BUTTON(r->spins[i]), defval);

		gtk_box_pack_start(GTK_BOX(r->gopt.box), r->spins[i], FALSE, FALSE, 0);
		g_signal_connect(G_OBJECT(r->spins[i]), "value-changed", G_CALLBACK(range_value_changed), r);
	}

	gtk_box_pack_start(GTK_BOX(r->gopt.box), label, FALSE, FALSE, 0);
	return &r->gopt;
}

static void gopt_add_option(GtkWidget *hbox, struct fio_option *o,
			    unsigned int opt_index, struct thread_options *to)
{
	struct gopt *go = NULL;

	switch (o->type) {
	case FIO_OPT_STR_VAL:
	case FIO_OPT_STR_VAL_TIME: {
		unsigned long long *ullp = NULL;

		if (o->off1)
			ullp = td_var(to, o->off1);

		go = gopt_new_ullong(o, ullp, opt_index);
		break;
		}
	case FIO_OPT_INT: {
		unsigned int *ip = NULL;

		if (o->off1)
			ip = td_var(to, o->off1);

		go = gopt_new_int(o, ip, opt_index);
		break;
		}
	case FIO_OPT_STR_SET:
	case FIO_OPT_BOOL: {
		unsigned int *ip = NULL;

		if (o->off1)
			ip = td_var(to, o->off1);

		go = gopt_new_bool(o, ip, opt_index);
		break;
		}
	case FIO_OPT_STR: {
		if (o->posval[0].ival) {
			unsigned int *ip = NULL;

			if (o->off1)
				ip = td_var(to, o->off1);

			go = gopt_new_combo_int(o, ip, opt_index);
		} else {
			/* TODO: usually ->cb, or unsigned int pointer */
			go = gopt_new_str_store(o, NULL, opt_index);
		}

		break;
		}
	case FIO_OPT_STR_STORE: {
		char *text = NULL;

		if (o->off1) {
			char **p = td_var(to, o->off1);
			text = *p;
		}

		if (!o->posval[0].ival) {
			go = gopt_new_str_store(o, text, opt_index);
			break;
		}

		go = gopt_new_combo_str(o, text, opt_index);
		break;
		}
	case FIO_OPT_STR_MULTI:
		go = gopt_new_str_multi(o, opt_index);
		break;
	case FIO_OPT_RANGE: {
		unsigned int *ip[4] = { td_var(to, o->off1),
					td_var(to, o->off2),
					td_var(to, o->off3),
					td_var(to, o->off4) };

		go = gopt_new_int_range(o, ip, opt_index);
		break;
		}
	/* still need to handle this one */
	case FIO_OPT_FLOAT_LIST:
		break;
	case FIO_OPT_DEPRECATED:
		break;
	default:
		printf("ignore type %u\n", o->type);
		break;
	}

	if (go) {
		GtkWidget *dest;

		if (o->help)
			gtk_widget_set_tooltip_text(go->box, o->help);

		go->opt_type = o->type;

		dest = gopt_get_group_frame(hbox, o->group);
		if (!dest)
			gtk_box_pack_start(GTK_BOX(hbox), go->box, FALSE, FALSE, 5);
		else
			gtk_box_pack_start(GTK_BOX(dest), go->box, FALSE, FALSE, 5);
	}
}

static void gopt_add_options(GtkWidget **vboxes, struct thread_options *to)
{
	GtkWidget *hbox = NULL;
	int i;

	for (i = 0; fio_options[i].name; i++) {
		struct fio_option *o = &fio_options[i];
		unsigned int mask = o->category;
		struct opt_group *og;

		while ((og = opt_group_from_mask(&mask)) != NULL) {
			GtkWidget *vbox = vboxes[ffz(~og->mask)];

			hbox = gtk_hbox_new(FALSE, 3);
			gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 5);
			gopt_add_option(hbox, o, i, to);
		}
	}
}

static GtkWidget *gopt_add_group_tab(GtkWidget *notebook, struct opt_group *og)
{
	GtkWidget *box, *vbox, *scroll;

	scroll = gtk_scrolled_window_new(NULL, NULL);
	gtk_container_set_border_width(GTK_CONTAINER(scroll), 5);
	gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scroll), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);

	vbox = gtk_vbox_new(FALSE, 3);
	box = gtk_hbox_new(FALSE, 0);
	gtk_box_pack_start(GTK_BOX(vbox), box, FALSE, FALSE, 5);
	gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scroll), vbox);
	gtk_notebook_append_page(GTK_NOTEBOOK(notebook), scroll, gtk_label_new(og->name));

	return vbox;
}

static void gopt_add_group_tabs(GtkWidget *notebook, GtkWidget **vbox)
{
	struct opt_group *og;
	unsigned int i;

	i = 0;
	do {
		unsigned int mask = (1U << i);

		og = opt_group_from_mask(&mask);
		if (!og)
			break;
		vbox[i] = gopt_add_group_tab(notebook, og);
		i++;
	} while (1);
}

void gopt_get_options_window(GtkWidget *window, struct thread_options *o)
{
	GtkWidget *dialog, *notebook;
	GtkWidget *vboxes[__FIO_OPT_C_NR];

	dialog = gtk_dialog_new_with_buttons("Fio options",
			GTK_WINDOW(window), GTK_DIALOG_DESTROY_WITH_PARENT,
			GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
			GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT, NULL);

	gtk_widget_set_size_request(GTK_WIDGET(dialog), 1024, 768);

	notebook = gtk_notebook_new();
	gtk_notebook_set_scrollable(GTK_NOTEBOOK(notebook), 1);
	gtk_notebook_popup_enable(GTK_NOTEBOOK(notebook));
	gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), notebook, TRUE, TRUE, 5);

	gopt_add_group_tabs(notebook, vboxes);

	gopt_add_options(vboxes, o);

	gtk_widget_show_all(dialog);

	gtk_dialog_run(GTK_DIALOG(dialog));

	gtk_widget_destroy(dialog);
}
Commit	Line	Data
9af4a244 JA	1	#include <locale.h>
	2	#include <malloc.h>
	3	#include <string.h>
	4
	5	#include <glib.h>
	6	#include <cairo.h>
	7	#include <gtk/gtk.h>
	8
	9	#include "fio.h"
	10	#include "gfio.h"
	11	#include "ghelpers.h"
	12	#include "parse.h"
	13
	14	struct gopt {
	15	GtkWidget *box;
	16	unsigned int opt_index;
	17	unsigned int opt_type;
	18	};
	19
	20	struct gopt_combo {
	21	struct gopt gopt;
	22	GtkWidget *combo;
	23	};
	24
	25	struct gopt_int {
	26	struct gopt gopt;
	27	GtkWidget *spin;
	28	};
	29
	30	struct gopt_bool {
	31	struct gopt gopt;
	32	GtkWidget *check;
	33	};
	34
	35	struct gopt_str {
	36	struct gopt gopt;
	37	GtkWidget *entry;
	38	};
	39
1da10c19 JA	40	#define GOPT_RANGE_SPIN 4
1da10c19 JA	41
9af4a244 JA	42	struct gopt_range {
9af4a244 JA	43	struct gopt gopt;
1da10c19	44	GtkWidget *spins[GOPT_RANGE_SPIN];
9af4a244 JA	45	};
9af4a244 JA	46
7386d4ae JA	47	struct gopt_str_multi {
	48	struct gopt gopt;
	49	GtkWidget *checks[PARSE_MAX_VP];
	50	};
	51
e8b0e958	52	static GtkWidget *gopt_widgets[FIO_MAX_OPTS];
ec0218ff	53
e8b0e958 JA	54	struct gopt_frame_widget {
	55	GtkWidget *vbox[2];
	56	unsigned int nr;
	57	};
	58	static struct gopt_frame_widget gopt_g_widgets[__FIO_OPT_G_NR];
ec0218ff	59
e8b0e958	60	static GtkWidget gopt_get_group_frame(GtkWidget box, unsigned int groupmask)
ec0218ff	61	{
e8b0e958 JA	62	unsigned int mask, group;
	63	struct opt_group *og;
	64	GtkWidget frame, hbox;
	65	struct gopt_frame_widget *gfw;
	66
	67	if (!groupmask)
	68	return 0;
	69
	70	mask = groupmask;
	71	og = opt_group_cat_from_mask(&mask);
	72	if (!og)
	73	return NULL;
	74
	75	group = ffz(~groupmask);
	76	gfw = &gopt_g_widgets[group];
	77	if (!gfw->vbox[0]) {
	78	frame = gtk_frame_new(og->name);
	79	gtk_box_pack_start(GTK_BOX(box), frame, FALSE, FALSE, 3);
	80	hbox = gtk_hbox_new(FALSE, 0);
	81	gtk_container_add(GTK_CONTAINER(frame), hbox);
	82	gfw->vbox[0] = gtk_vbox_new(TRUE, 5);
	83	gfw->vbox[1] = gtk_vbox_new(TRUE, 5);
	84	gtk_box_pack_start(GTK_BOX(hbox), gfw->vbox[0], TRUE, TRUE, 5);
	85	gtk_box_pack_start(GTK_BOX(hbox), gfw->vbox[1], TRUE, TRUE, 5);
ec0218ff	86	}
e8b0e958 JA	87
	88	hbox = gtk_hbox_new(FALSE, 3);
	89	gtk_box_pack_start(GTK_BOX(gfw->vbox[gfw->nr++ & 1]), hbox, FALSE, FALSE, 5);
	90	return hbox;
ec0218ff	91	}
b6caa836 JA	92
	93	/*
	94	* Mark children as invisible, if needed.
	95	*/
	96	static void gopt_set_children_visible(struct fio_option *parent, gboolean visible)
	97	{
	98	struct fio_option *o;
	99	int i;
	100
	101	/*
	102	* This isn't super fast, but it should not be an issue. If it is, we
	103	* can speed it up by caching the lookup at least. Or we can do it
	104	* once, at init time.
	105	*/
	106	for (i = 0; fio_options[i].name; i++) {
	107	o = &fio_options[i];
ec0218ff	108	if (!o->parent \|\| !o->hide)
b6caa836 JA	109	continue;
	110
	111	if (strcmp(parent->name, o->parent))
	112	continue;
	113
e8b0e958 JA	114	if (gopt_widgets[i])
e8b0e958 JA	115	gtk_widget_set_sensitive(gopt_widgets[i], visible);
b6caa836 JA	116	}
	117	}
	118
	119	static void gopt_str_changed(GtkEntry *entry, gpointer data)
	120	{
	121	struct gopt_str s = (struct gopt_str ) data;
	122	struct fio_option *o = &fio_options[s->gopt.opt_index];
	123	const gchar *text;
	124	int set;
	125
	126	text = gtk_entry_get_text(GTK_ENTRY(s->entry));
	127	set = strcmp(text, "") != 0;
	128	gopt_set_children_visible(o, set);
	129	}
	130
ec0218ff	131	static void gopt_mark_index(struct gopt *gopt, unsigned int idx)
b6caa836	132	{
e8b0e958	133	assert(!gopt_widgets[idx]);
b6caa836	134	gopt->opt_index = idx;
e8b0e958	135	gopt_widgets[idx] = gopt->box;
b6caa836 JA	136	}
	137
	138	static struct gopt gopt_new_str_store(struct fio_option o, const char *text, unsigned int idx)
9af4a244 JA	139	{
	140	struct gopt_str *s;
	141	GtkWidget *label;
	142
	143	s = malloc(sizeof(*s));
	144
	145	s->gopt.box = gtk_hbox_new(FALSE, 3);
e8b0e958 JA	146	if (!o->lname)
	147	label = gtk_label_new(o->name);
	148	else
	149	label = gtk_label_new(o->lname);
9af4a244 JA	150
9af4a244 JA	151	s->entry = gtk_entry_new();
ec0218ff	152	gopt_mark_index(&s->gopt, idx);
789f4ccd JA	153	if (text)
789f4ccd JA	154	gtk_entry_set_text(GTK_ENTRY(s->entry), text);
9af4a244	155	gtk_entry_set_editable(GTK_ENTRY(s->entry), 1);
b6caa836	156	g_signal_connect(GTK_OBJECT(s->entry), "changed", G_CALLBACK(gopt_str_changed), s);
9af4a244 JA	157
	158	if (o->def)
	159	gtk_entry_set_text(GTK_ENTRY(s->entry), o->def);
	160
	161	gtk_box_pack_start(GTK_BOX(s->gopt.box), s->entry, FALSE, FALSE, 0);
e8b0e958	162	gtk_box_pack_start(GTK_BOX(s->gopt.box), label, FALSE, FALSE, 0);
9af4a244 JA	163	return &s->gopt;
	164	}
	165
b6caa836	166	static void gopt_combo_changed(GtkComboBox *box, gpointer data)
9af4a244	167	{
b6caa836 JA	168	struct gopt_combo c = (struct gopt_combo ) data;
	169	struct fio_option *o = &fio_options[c->gopt.opt_index];
	170
	171	printf("combo %s changed\n", o->name);
	172	}
	173
	174	static struct gopt_combo __gopt_new_combo(struct fio_option o, unsigned int idx)
	175	{
	176	struct gopt_combo *c;
9af4a244	177	GtkWidget *label;
9af4a244	178
b6caa836	179	c = malloc(sizeof(*c));
9af4a244	180
b6caa836	181	c->gopt.box = gtk_hbox_new(FALSE, 3);
e8b0e958 JA	182	if (!o->lname)
	183	label = gtk_label_new(o->name);
	184	else
	185	label = gtk_label_new(o->lname);
9af4a244	186
b6caa836	187	c->combo = gtk_combo_box_new_text();
ec0218ff	188	gopt_mark_index(&c->gopt, idx);
b6caa836 JA	189	g_signal_connect(GTK_OBJECT(c->combo), "changed", G_CALLBACK(gopt_combo_changed), c);
b6caa836 JA	190
e8b0e958 JA	191	gtk_box_pack_start(GTK_BOX(c->gopt.box), c->combo, FALSE, FALSE, 0);
	192	gtk_box_pack_start(GTK_BOX(c->gopt.box), label, FALSE, FALSE, 0);
	193
b6caa836	194	return c;
39f04336 JA	195	}
39f04336 JA	196
b6caa836	197	static struct gopt gopt_new_combo_str(struct fio_option o, const char *text, unsigned int idx)
39f04336 JA	198	{
	199	struct gopt_combo *combo;
	200	struct value_pair *vp;
	201	int i, active = 0;
	202
b6caa836	203	combo = __gopt_new_combo(o, idx);
39f04336	204
9af4a244 JA	205	i = 0;
	206	vp = &o->posval[0];
	207	while (vp->ival) {
	208	gtk_combo_box_append_text(GTK_COMBO_BOX(combo->combo), vp->ival);
	209	if (o->def && !strcmp(vp->ival, o->def))
	210	active = i;
39f04336 JA	211	if (text && !strcmp(vp->ival, text))
39f04336 JA	212	active = i;
9af4a244 JA	213	vp++;
	214	i++;
	215	}
	216
	217	gtk_combo_box_set_active(GTK_COMBO_BOX(combo->combo), active);
	218	return &combo->gopt;
	219	}
	220
b6caa836	221	static struct gopt gopt_new_combo_int(struct fio_option o, unsigned int *ip, unsigned int idx)
9af4a244	222	{
39f04336 JA	223	struct gopt_combo *combo;
	224	struct value_pair *vp;
	225	int i, active = 0;
	226
b6caa836	227	combo = __gopt_new_combo(o, idx);
39f04336 JA	228
	229	i = 0;
	230	vp = &o->posval[0];
	231	while (vp->ival) {
	232	gtk_combo_box_append_text(GTK_COMBO_BOX(combo->combo), vp->ival);
	233	if (ip && vp->oval == *ip)
	234	active = i;
	235	vp++;
	236	i++;
	237	}
	238
	239	gtk_combo_box_set_active(GTK_COMBO_BOX(combo->combo), active);
	240	return &combo->gopt;
	241	}
	242
7386d4ae JA	243	static struct gopt gopt_new_str_multi(struct fio_option o, unsigned int idx)
	244	{
	245	struct gopt_str_multi *m;
	246	struct value_pair *vp;
	247	GtkWidget frame, hbox;
	248	int i;
	249
	250	m = malloc(sizeof(*m));
	251	m->gopt.box = gtk_hbox_new(FALSE, 3);
	252	gopt_mark_index(&m->gopt, idx);
	253
	254	if (!o->lname)
	255	frame = gtk_frame_new(o->name);
	256	else
	257	frame = gtk_frame_new(o->lname);
	258	gtk_box_pack_start(GTK_BOX(m->gopt.box), frame, FALSE, FALSE, 3);
	259
	260	hbox = gtk_hbox_new(FALSE, 3);
	261	gtk_container_add(GTK_CONTAINER(frame), hbox);
	262
	263	i = 0;
	264	vp = &o->posval[0];
	265	while (vp->ival) {
	266	m->checks[i] = gtk_check_button_new_with_label(vp->ival);
	267	gtk_widget_set_tooltip_text(m->checks[i], vp->help);
	268	gtk_box_pack_start(GTK_BOX(hbox), m->checks[i], FALSE, FALSE, 3);
	269	vp++;
	270	}
	271
	272	return &m->gopt;
	273	}
	274
b6caa836 JA	275	static void gopt_int_changed(GtkSpinButton *spin, gpointer data)
	276	{
	277	struct gopt_int i = (struct gopt_int ) data;
	278	struct fio_option *o = &fio_options[i->gopt.opt_index];
	279
	280	printf("int %s changed\n", o->name);
	281	}
	282
	283	static struct gopt_int __gopt_new_int(struct fio_option o, unsigned long long *p,
	284	unsigned int idx)
39f04336 JA	285	{
39f04336 JA	286	unsigned long long defval;
9af4a244	287	struct gopt_int *i;
20eb06bd	288	guint maxval, interval;
9af4a244 JA	289	GtkWidget *label;
	290
	291	i = malloc(sizeof(*i));
	292	i->gopt.box = gtk_hbox_new(FALSE, 3);
e8b0e958 JA	293	if (!o->lname)
	294	label = gtk_label_new(o->name);
	295	else
	296	label = gtk_label_new(o->lname);
9af4a244 JA	297
	298	maxval = o->maxval;
	299	if (!maxval)
39f04336	300	maxval = UINT_MAX;
9af4a244 JA	301
9af4a244 JA	302	defval = 0;
39f04336 JA	303	if (p)
	304	defval = *p;
	305	else if (o->def) {
9af4a244 JA	306	long long val;
	307
	308	check_str_bytes(o->def, &val, NULL);
	309	defval = val;
	310	}
	311
20eb06bd JA	312	interval = 1.0;
	313	if (o->interval)
	314	interval = o->interval;
	315
	316	i->spin = gtk_spin_button_new_with_range(o->minval, maxval, interval);
ec0218ff	317	gopt_mark_index(&i->gopt, idx);
9af4a244 JA	318	gtk_spin_button_set_update_policy(GTK_SPIN_BUTTON(i->spin), GTK_UPDATE_IF_VALID);
9af4a244 JA	319	gtk_spin_button_set_value(GTK_SPIN_BUTTON(i->spin), defval);
e8b0e958	320	g_signal_connect(G_OBJECT(i->spin), "value-changed", G_CALLBACK(gopt_int_changed), i);
9af4a244 JA	321
9af4a244 JA	322	gtk_box_pack_start(GTK_BOX(i->gopt.box), i->spin, FALSE, FALSE, 0);
e8b0e958	323	gtk_box_pack_start(GTK_BOX(i->gopt.box), label, FALSE, FALSE, 0);
b6caa836 JA	324
b6caa836 JA	325	return i;
9af4a244 JA	326	}
9af4a244 JA	327
b6caa836	328	static struct gopt gopt_new_int(struct fio_option o, unsigned int *ip, unsigned int idx)
39f04336 JA	329	{
39f04336 JA	330	unsigned long long ullp;
b6caa836	331	struct gopt_int *i;
39f04336 JA	332
	333	if (ip) {
	334	ullp = *ip;
b6caa836 JA	335	i = __gopt_new_int(o, &ullp, idx);
	336	} else
	337	i = __gopt_new_int(o, NULL, idx);
	338
	339	return &i->gopt;
	340	}
39f04336	341
b6caa836 JA	342	static struct gopt gopt_new_ullong(struct fio_option o, unsigned long long *p,
	343	unsigned int idx)
	344	{
	345	struct gopt_int *i;
	346
	347	i = __gopt_new_int(o, p, idx);
	348	return &i->gopt;
39f04336 JA	349	}
39f04336 JA	350
b6caa836	351	static void gopt_bool_toggled(GtkToggleButton *button, gpointer data)
39f04336	352	{
b6caa836 JA	353	struct gopt_bool b = (struct gopt_bool ) data;
	354	struct fio_option *o = &fio_options[b->gopt.opt_index];
	355	gboolean set;
	356
	357	set = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(b->check));
	358	gopt_set_children_visible(o, set);
39f04336 JA	359	}
39f04336 JA	360
b6caa836	361	static struct gopt gopt_new_bool(struct fio_option o, unsigned int *val, unsigned int idx)
9af4a244 JA	362	{
	363	struct gopt_bool *b;
	364	GtkWidget *label;
	365	int defstate = 0;
	366
	367	b = malloc(sizeof(*b));
	368	b->gopt.box = gtk_hbox_new(FALSE, 3);
e8b0e958 JA	369	if (!o->lname)
	370	label = gtk_label_new(o->name);
	371	else
	372	label = gtk_label_new(o->lname);
9af4a244 JA	373
9af4a244 JA	374	b->check = gtk_check_button_new();
ec0218ff	375	gopt_mark_index(&b->gopt, idx);
39f04336 JA	376	if (val)
	377	defstate = *val;
	378	else if (o->def && !strcmp(o->def, "1"))
9af4a244 JA	379	defstate = 1;
9af4a244 JA	380
d872fb4c JA	381	if (o->neg)
	382	defstate = !defstate;
	383
9af4a244	384	gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(b->check), defstate);
b6caa836	385	g_signal_connect(G_OBJECT(b->check), "toggled", G_CALLBACK(gopt_bool_toggled), b);
9af4a244 JA	386
9af4a244 JA	387	gtk_box_pack_start(GTK_BOX(b->gopt.box), b->check, FALSE, FALSE, 0);
e8b0e958	388	gtk_box_pack_start(GTK_BOX(b->gopt.box), label, FALSE, FALSE, 0);
9af4a244 JA	389	return &b->gopt;
	390	}
	391
1da10c19 JA	392	/*
	393	* These are paired 0/1 and 2/3. 0/2 are min values, 1/3 are max values.
	394	* If the max is made smaller than min, adjust min down.
	395	* If the min is made larger than max, adjust the max.
	396	*/
	397	static void range_value_changed(GtkSpinButton *spin, gpointer data)
	398	{
	399	struct gopt_range r = (struct gopt_range ) data;
	400	int changed = -1, i;
	401	gint val, mval;
	402
	403	for (i = 0; i < GOPT_RANGE_SPIN; i++) {
	404	if (GTK_SPIN_BUTTON(r->spins[i]) == spin) {
	405	changed = i;
	406	break;
	407	}
	408	}
	409
	410	assert(changed != -1);
	411
	412	/*
	413	* Min changed
	414	*/
	415	if (changed == 0 \|\| changed == 2) {
	416	GtkWidget *mspin = r->spins[changed + 1];
	417
	418	val = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(r->spins[changed]));
	419	mval = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(mspin));
	420	if (val > mval)
	421	gtk_spin_button_set_value(GTK_SPIN_BUTTON(mspin), val);
	422	} else {
	423	GtkWidget *mspin = r->spins[changed - 1];
	424
	425	val = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(r->spins[changed]));
	426	mval = gtk_spin_button_get_value_as_int(GTK_SPIN_BUTTON(mspin));
	427	if (val < mval)
	428	gtk_spin_button_set_value(GTK_SPIN_BUTTON(mspin), val);
	429	}
	430	}
	431
b6caa836 JA	432	static struct gopt gopt_new_int_range(struct fio_option o, unsigned int **ip,
b6caa836 JA	433	unsigned int idx)
9af4a244 JA	434	{
	435	struct gopt_range *r;
	436	gint maxval, defval;
	437	GtkWidget *label;
20eb06bd	438	guint interval;
9af4a244 JA	439	int i;
	440
	441	r = malloc(sizeof(*r));
	442	r->gopt.box = gtk_hbox_new(FALSE, 3);
ec0218ff	443	gopt_mark_index(&r->gopt, idx);
e8b0e958 JA	444	if (!o->lname)
	445	label = gtk_label_new(o->name);
	446	else
	447	label = gtk_label_new(o->lname);
9af4a244 JA	448
	449	maxval = o->maxval;
	450	if (!maxval)
	451	maxval = INT_MAX;
	452
	453	defval = 0;
	454	if (o->def) {
	455	long long val;
	456
	457	check_str_bytes(o->def, &val, NULL);
	458	defval = val;
	459	}
	460
20eb06bd JA	461	interval = 1.0;
	462	if (o->interval)
	463	interval = o->interval;
	464
1da10c19	465	for (i = 0; i < GOPT_RANGE_SPIN; i++) {
20eb06bd	466	r->spins[i] = gtk_spin_button_new_with_range(o->minval, maxval, interval);
9af4a244	467	gtk_spin_button_set_update_policy(GTK_SPIN_BUTTON(r->spins[i]), GTK_UPDATE_IF_VALID);
39f04336 JA	468	if (ip)
	469	gtk_spin_button_set_value(GTK_SPIN_BUTTON(r->spins[i]), *ip[i]);
	470	else
	471	gtk_spin_button_set_value(GTK_SPIN_BUTTON(r->spins[i]), defval);
9af4a244 JA	472
9af4a244 JA	473	gtk_box_pack_start(GTK_BOX(r->gopt.box), r->spins[i], FALSE, FALSE, 0);
1da10c19	474	g_signal_connect(G_OBJECT(r->spins[i]), "value-changed", G_CALLBACK(range_value_changed), r);
9af4a244 JA	475	}
9af4a244 JA	476
e8b0e958	477	gtk_box_pack_start(GTK_BOX(r->gopt.box), label, FALSE, FALSE, 0);
9af4a244 JA	478	return &r->gopt;
	479	}
	480
	481	static void gopt_add_option(GtkWidget hbox, struct fio_option o,
789f4ccd	482	unsigned int opt_index, struct thread_options *to)
9af4a244 JA	483	{
	484	struct gopt *go = NULL;
	485
	486	switch (o->type) {
39f04336 JA	487	case FIO_OPT_STR_VAL:
	488	case FIO_OPT_STR_VAL_TIME: {
	489	unsigned long long *ullp = NULL;
	490
	491	if (o->off1)
	492	ullp = td_var(to, o->off1);
789f4ccd	493
b6caa836	494	go = gopt_new_ullong(o, ullp, opt_index);
9af4a244	495	break;
789f4ccd	496	}
39f04336 JA	497	case FIO_OPT_INT: {
	498	unsigned int *ip = NULL;
	499
	500	if (o->off1)
	501	ip = td_var(to, o->off1);
	502
b6caa836	503	go = gopt_new_int(o, ip, opt_index);
9af4a244	504	break;
39f04336	505	}
9af4a244	506	case FIO_OPT_STR_SET:
39f04336 JA	507	case FIO_OPT_BOOL: {
	508	unsigned int *ip = NULL;
	509
	510	if (o->off1)
	511	ip = td_var(to, o->off1);
	512
b6caa836	513	go = gopt_new_bool(o, ip, opt_index);
39f04336 JA	514	break;
	515	}
	516	case FIO_OPT_STR: {
d872fb4c JA	517	if (o->posval[0].ival) {
d872fb4c JA	518	unsigned int *ip = NULL;
39f04336	519
d872fb4c JA	520	if (o->off1)
	521	ip = td_var(to, o->off1);
	522
	523	go = gopt_new_combo_int(o, ip, opt_index);
	524	} else {
	525	/* TODO: usually ->cb, or unsigned int pointer */
	526	go = gopt_new_str_store(o, NULL, opt_index);
	527	}
39f04336	528
9af4a244	529	break;
39f04336 JA	530	}
	531	case FIO_OPT_STR_STORE: {
	532	char *text = NULL;
	533
d3944493	534	if (o->off1) {
39f04336 JA	535	char **p = td_var(to, o->off1);
	536	text = *p;
	537	}
	538
9af4a244	539	if (!o->posval[0].ival) {
b6caa836	540	go = gopt_new_str_store(o, text, opt_index);
9af4a244 JA	541	break;
9af4a244 JA	542	}
39f04336	543
b6caa836	544	go = gopt_new_combo_str(o, text, opt_index);
39f04336 JA	545	break;
39f04336 JA	546	}
9af4a244	547	case FIO_OPT_STR_MULTI:
7386d4ae	548	go = gopt_new_str_multi(o, opt_index);
9af4a244	549	break;
39f04336 JA	550	case FIO_OPT_RANGE: {
	551	unsigned int *ip[4] = { td_var(to, o->off1),
	552	td_var(to, o->off2),
	553	td_var(to, o->off3),
	554	td_var(to, o->off4) };
	555
b6caa836	556	go = gopt_new_int_range(o, ip, opt_index);
9af4a244	557	break;
39f04336	558	}
9af4a244 JA	559	/* still need to handle this one */
	560	case FIO_OPT_FLOAT_LIST:
	561	break;
	562	case FIO_OPT_DEPRECATED:
	563	break;
	564	default:
	565	printf("ignore type %u\n", o->type);
	566	break;
	567	}
	568
	569	if (go) {
e8b0e958 JA	570	GtkWidget *dest;
e8b0e958 JA	571
9af4a244 JA	572	if (o->help)
9af4a244 JA	573	gtk_widget_set_tooltip_text(go->box, o->help);
e8b0e958	574
9af4a244	575	go->opt_type = o->type;
e8b0e958 JA	576
	577	dest = gopt_get_group_frame(hbox, o->group);
	578	if (!dest)
	579	gtk_box_pack_start(GTK_BOX(hbox), go->box, FALSE, FALSE, 5);
	580	else
	581	gtk_box_pack_start(GTK_BOX(dest), go->box, FALSE, FALSE, 5);
9af4a244 JA	582	}
	583	}
	584
789f4ccd	585	static void gopt_add_options(GtkWidget *vboxes, struct thread_options to)
9af4a244 JA	586	{
	587	GtkWidget *hbox = NULL;
	588	int i;
	589
	590	for (i = 0; fio_options[i].name; i++) {
	591	struct fio_option *o = &fio_options[i];
	592	unsigned int mask = o->category;
	593	struct opt_group *og;
	594
	595	while ((og = opt_group_from_mask(&mask)) != NULL) {
	596	GtkWidget *vbox = vboxes[ffz(~og->mask)];
	597
	598	hbox = gtk_hbox_new(FALSE, 3);
	599	gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 5);
789f4ccd	600	gopt_add_option(hbox, o, i, to);
9af4a244 JA	601	}
	602	}
	603	}
	604
	605	static GtkWidget gopt_add_group_tab(GtkWidget notebook, struct opt_group *og)
	606	{
	607	GtkWidget box, vbox, *scroll;
	608
	609	scroll = gtk_scrolled_window_new(NULL, NULL);
	610	gtk_container_set_border_width(GTK_CONTAINER(scroll), 5);
	611	gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scroll), GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
	612
	613	vbox = gtk_vbox_new(FALSE, 3);
	614	box = gtk_hbox_new(FALSE, 0);
	615	gtk_box_pack_start(GTK_BOX(vbox), box, FALSE, FALSE, 5);
	616	gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scroll), vbox);
	617	gtk_notebook_append_page(GTK_NOTEBOOK(notebook), scroll, gtk_label_new(og->name));
	618
	619	return vbox;
	620	}
	621
	622	static void gopt_add_group_tabs(GtkWidget notebook, GtkWidget *vbox)
	623	{
	624	struct opt_group *og;
ec0218ff	625	unsigned int i;
9af4a244	626
ec0218ff	627	i = 0;
9af4a244 JA	628	do {
	629	unsigned int mask = (1U << i);
	630
	631	og = opt_group_from_mask(&mask);
	632	if (!og)
	633	break;
	634	vbox[i] = gopt_add_group_tab(notebook, og);
	635	i++;
	636	} while (1);
	637	}
	638
789f4ccd	639	void gopt_get_options_window(GtkWidget window, struct thread_options o)
9af4a244 JA	640	{
9af4a244 JA	641	GtkWidget dialog, notebook;
e8b0e958	642	GtkWidget *vboxes[__FIO_OPT_C_NR];
9af4a244 JA	643
	644	dialog = gtk_dialog_new_with_buttons("Fio options",
	645	GTK_WINDOW(window), GTK_DIALOG_DESTROY_WITH_PARENT,
	646	GTK_STOCK_OK, GTK_RESPONSE_ACCEPT,
	647	GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT, NULL);
	648
	649	gtk_widget_set_size_request(GTK_WIDGET(dialog), 1024, 768);
	650
	651	notebook = gtk_notebook_new();
	652	gtk_notebook_set_scrollable(GTK_NOTEBOOK(notebook), 1);
	653	gtk_notebook_popup_enable(GTK_NOTEBOOK(notebook));
	654	gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), notebook, TRUE, TRUE, 5);
	655
	656	gopt_add_group_tabs(notebook, vboxes);
	657
789f4ccd	658	gopt_add_options(vboxes, o);
9af4a244 JA	659
	660	gtk_widget_show_all(dialog);
	661
	662	gtk_dialog_run(GTK_DIALOG(dialog));
	663
	664	gtk_widget_destroy(dialog);
	665	}